You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/07/22 16:25:25 UTC

[jira] Created: (MAVEN-1387) Dependency checking for named jars

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MAVEN-1387

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-1387
    Summary: Dependency checking for named jars
       Type: Improvement

     Status: Unassigned

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven

   Assignee: 
   Reporter: Steve Molloy

    Created: Thu, 22 Jul 2004 10:23 AM
    Updated: Thu, 22 Jul 2004 10:23 AM

Description:
SNAPSHOT dependencies should always be checked and the newest version downloaded. But since the AbstractArtifact checks the artifact name itself to determine if it's a SNAPSHOT, artifacts not following the <artifactId>-<version>.<type> standard (built outside Maven for example) are not considered SNAPSHOT even if you add the flag because the jar name doesn't contain the keyword.

I think it would make sense to change the behavior of the isArtifact method of AbstractArtifact to check th eversion of the dependency rather then its name. Thus, instead of:

return getDependency().getArtifact().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

You would have:

return getDependency().getVersion().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

This way, even if you had a jar someJar.jar, you could still get the latest version each build by adding the SNAPSHOT version tag as usual. And it wouldn't change the behavior for the artifacts created by Maven since the version would also be SNAPSHOT.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MAVEN-1387) Dependency checking for named jars

Posted by ji...@codehaus.org.
Message:

   The following issue has been closed.

   Resolver: Brett Porter
       Date: Thu, 23 Sep 2004 3:04 AM

fixed - to commit
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MAVEN-1387

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-1387
    Summary: Dependency checking for named jars
       Type: Improvement

     Status: Closed
 Resolution: FIXED

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven
   Fix Fors:
             1.0.1

   Assignee: Brett Porter
   Reporter: Steve Molloy

    Created: Thu, 22 Jul 2004 10:23 AM
    Updated: Thu, 23 Sep 2004 3:04 AM

Description:
SNAPSHOT dependencies should always be checked and the newest version downloaded. But since the AbstractArtifact checks the artifact name itself to determine if it's a SNAPSHOT, artifacts not following the <artifactId>-<version>.<type> standard (built outside Maven for example) are not considered SNAPSHOT even if you add the flag because the jar name doesn't contain the keyword.

I think it would make sense to change the behavior of the isArtifact method of AbstractArtifact to check th eversion of the dependency rather then its name. Thus, instead of:

return getDependency().getArtifact().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

You would have:

return getDependency().getVersion().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

This way, even if you had a jar someJar.jar, you could still get the latest version each build by adding the SNAPSHOT version tag as usual. And it wouldn't change the behavior for the artifacts created by Maven since the version would also be SNAPSHOT.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MAVEN-1387) Dependency checking for named jars

Posted by ji...@codehaus.org.
The following issue has been updated:

    Updater: Brett Porter (mailto:brett@codehaus.org)
       Date: Fri, 23 Jul 2004 1:15 PM
    Changes:
             Fix Version changed to 1.0.1
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MAVEN-1387?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MAVEN-1387

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-1387
    Summary: Dependency checking for named jars
       Type: Improvement

     Status: Reopened

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven
   Fix Fors:
             1.0.1

   Assignee: 
   Reporter: Steve Molloy

    Created: Thu, 22 Jul 2004 10:23 AM
    Updated: Fri, 23 Jul 2004 1:15 PM

Description:
SNAPSHOT dependencies should always be checked and the newest version downloaded. But since the AbstractArtifact checks the artifact name itself to determine if it's a SNAPSHOT, artifacts not following the <artifactId>-<version>.<type> standard (built outside Maven for example) are not considered SNAPSHOT even if you add the flag because the jar name doesn't contain the keyword.

I think it would make sense to change the behavior of the isArtifact method of AbstractArtifact to check th eversion of the dependency rather then its name. Thus, instead of:

return getDependency().getArtifact().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

You would have:

return getDependency().getVersion().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

This way, even if you had a jar someJar.jar, you could still get the latest version each build by adding the SNAPSHOT version tag as usual. And it wouldn't change the behavior for the artifacts created by Maven since the version would also be SNAPSHOT.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MAVEN-1387) Dependency checking for named jars

Posted by ji...@codehaus.org.
Message:

   The following issue has been reopened.

   Reopener: Brett Porter
       Date: Fri, 23 Jul 2004 1:15 PM

ok, will make SNAPSHOT version force SNAPSHOT handling
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MAVEN-1387

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-1387
    Summary: Dependency checking for named jars
       Type: Improvement

     Status: Reopened

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven
   Fix Fors:
             1.0.1

   Assignee: 
   Reporter: Steve Molloy

    Created: Thu, 22 Jul 2004 10:23 AM
    Updated: Fri, 23 Jul 2004 1:15 PM

Description:
SNAPSHOT dependencies should always be checked and the newest version downloaded. But since the AbstractArtifact checks the artifact name itself to determine if it's a SNAPSHOT, artifacts not following the <artifactId>-<version>.<type> standard (built outside Maven for example) are not considered SNAPSHOT even if you add the flag because the jar name doesn't contain the keyword.

I think it would make sense to change the behavior of the isArtifact method of AbstractArtifact to check th eversion of the dependency rather then its name. Thus, instead of:

return getDependency().getArtifact().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

You would have:

return getDependency().getVersion().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

This way, even if you had a jar someJar.jar, you could still get the latest version each build by adding the SNAPSHOT version tag as usual. And it wouldn't change the behavior for the artifacts created by Maven since the version would also be SNAPSHOT.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MAVEN-1387) Dependency checking for named jars

Posted by ji...@codehaus.org.
Message:

   The following issue has been closed.

   Resolver: Brett Porter
       Date: Fri, 23 Jul 2004 2:21 AM

munging filenames in the repository will gve undefined results such as this.
---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MAVEN-1387

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-1387
    Summary: Dependency checking for named jars
       Type: Improvement

     Status: Closed
 Resolution: WON'T FIX

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven

   Assignee: 
   Reporter: Steve Molloy

    Created: Thu, 22 Jul 2004 10:23 AM
    Updated: Fri, 23 Jul 2004 2:21 AM

Description:
SNAPSHOT dependencies should always be checked and the newest version downloaded. But since the AbstractArtifact checks the artifact name itself to determine if it's a SNAPSHOT, artifacts not following the <artifactId>-<version>.<type> standard (built outside Maven for example) are not considered SNAPSHOT even if you add the flag because the jar name doesn't contain the keyword.

I think it would make sense to change the behavior of the isArtifact method of AbstractArtifact to check th eversion of the dependency rather then its name. Thus, instead of:

return getDependency().getArtifact().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

You would have:

return getDependency().getVersion().indexOf( MavenConstants.SNAPSHOT_SIGNIFIER ) > 0;

This way, even if you had a jar someJar.jar, you could still get the latest version each build by adding the SNAPSHOT version tag as usual. And it wouldn't change the behavior for the artifacts created by Maven since the version would also be SNAPSHOT.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org