[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11864: [Bug] [Master] WorkflowExecuteRunnable will face a infinite loop #11838

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11864:
URL: https://github.com/apache/dolphinscheduler/pull/11864#discussion_r966051153


##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteThreadPool.java:
##########
@@ -101,7 +101,8 @@ public void submitStateEvent(StateEvent stateEvent) {
      * Handle the events belong to the given workflow.
      */
     public void executeEvent(final WorkflowExecuteRunnable workflowExecuteThread) {
-        if (!workflowExecuteThread.isStart() || workflowExecuteThread.eventSize() == 0) {
+        if (!workflowExecuteThread.isStart() || workflowExecuteThread.isHandingEvent()

Review Comment:
   Why we need to do this change, if the `workflowExecuteThread` is handing event, it should be filter by `if (multiThreadFilterMap.containsKey(workflowExecuteThread.getKey()))`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org