[jira] [Commented] (CASSANDRA-12681) Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.

["Jeff Jirsa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-12681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515172#comment-15515172 ] 

Jeff Jirsa commented on CASSANDRA-12681:
----------------------------------------

This has been mentioned in the past (typos in KS replication settings can cause queries to fail, in particular), so it's clearly a pain point for multiple people, but we should note that this un-does the backwards-compatibility changes of CASSANDRA-4795 from 2013. At the time, it was noted that unknown options were a horrible thing to do, but also recognized that people were using it for various reasons. 

Maybe it IS time to reconsider CASSANDRA-4795 - it's been 3 years, hopefully people have stopped abusing the schema.


> Reject empty options and invalid DC names in replication configuration while creating or altering a keyspace.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-12681
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-12681
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Distributed Metadata
>            Reporter: Nachiket Patil
>            Assignee: Nachiket Patil
>            Priority: Minor
>         Attachments: trunkpatch.diff, v3.0patch.diff
>
>
> Add some restrictions around create / alter keyspace with NetworkTopologyStrategy:
> 1. Do not accept empty replication configuration (no DC options after class). Cassandra checks that SimpleStrategy must have replication_factor option but does not check that at least one DC should be present in the options for NetworkTopologyStrategy.
> 2. Cassandra accepts any random string as DC name replication option for NetworkTopologyStrategy while creating or altering keyspaces. Add a restriction that the options specified is valid datacenter name. Using incorrect value or simple mistake in typing the DC name can cause outage in production environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)