You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Glen Daniels <gl...@thoughtcraft.com> on 2007/03/04 19:27:58 UTC

[axis2] Code in kernel module reformatted

Hey folks:

I just ran IDEA's code reformatter over the kernel module, with some 
options which I believe match our coding style.  I checked it in 
(http://svn.apache.org/viewvc?view=rev&rev=514453) with no other changes 
except formatting.  Please take a glance at the diffs if you like - it 
does things like rationalize spacing, remove whitespace in blank lines 
and at the end of lines, align parameters, wrap at 100 columns, etc.

As discussed earlier, I think we should start running this over the 
codebase right before each release's branch is cut.

Yours for cleaner code,
--Glen

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: [axis2] Code in kernel module reformatted

Posted by Glen Daniels <gl...@thoughtcraft.com>.
FYI, you'll find it at

https://svn.apache.org/repos/asf/webservices/axis2/trunk/java/etc/IDEA/

What I'd really like long term is for us to automate this and run it 
perhaps weekly alongside the automated build - in general there should 
be very few changes after the initial run and it can keep things tidy in 
between.

--Glen

Davanum Srinivas wrote:
> It's already checked into svn. Please go ahead and add a link to it
> from the developer guidelines.
> 
> -- dims
> 
> On 3/5/07, Sanjaya Karunasena <sa...@wso2.com> wrote:
>> While having it checked in, shall we have the template available for 
>> download
>> in the website under developer guidelines? It's good if we can have 
>> templates
>> available for eclipse and netbeans too. I guess commiters who use 
>> those IDEs
>> will volunteer.
>>
>> Thanks
>> Sanjaya
>>
>> On Monday 05 March 2007 12:56, David Illsley wrote:
>> > hehe. I don't use IDEA but I don't see any harm.
>> > David
>> >
>> > On 04/03/07, Eran Chinthaka <ch...@opensource.lk> wrote:
>> > > -----BEGIN PGP SIGNED MESSAGE-----
>> > > Hash: SHA1
>> > >
>> > > Glen,
>> > >
>> > > Can we please have your code formatting template (commit to svn?) as
>> > > some people asked for it and then we all can directly use it.
>> > >
>> > > <Fun>Since most people are using IDEA, I don't think you need to 
>> worry
>> > > about the other IDEs :)</Fun>
>> > >
>> > > - -- Chinthaka
>> > >
>> > > Glen Daniels wrote:
>> > > > Hey folks:
>> > > >
>> > > > I just ran IDEA's code reformatter over the kernel module, with 
>> some
>> > > > options which I believe match our coding style.  I checked it in
>> > > > (http://svn.apache.org/viewvc?view=rev&rev=514453) with no other
>> > > > changes except formatting.  Please take a glance at the diffs if 
>> you
>> > > > like - it does things like rationalize spacing, remove 
>> whitespace in
>> > > > blank lines and at the end of lines, align parameters, wrap at 100
>> > > > columns, etc.
>> > > >
>> > > > As discussed earlier, I think we should start running this over the
>> > > > codebase right before each release's branch is cut.
>> > > >
>> > > > Yours for cleaner code,
>> > > > --Glen
>> > > >
>> > > > 
>> ---------------------------------------------------------------------
>> > > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> > > > For additional commands, e-mail: axis-dev-help@ws.apache.org
>> > >
>> > > -----BEGIN PGP SIGNATURE-----
>> > > Version: GnuPG v1.4.3 (GNU/Linux)
>> > > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>> > >
>> > > iD8DBQFF60RGjON2uBzUhh8RAq81AKCTn2PSWGEL75Y3ldpz3oMvD6wnuQCfQD73
>> > > QuIzhQ7xLUc4MKRwtezPK/M=
>> > > =ooTF
>> > > -----END PGP SIGNATURE-----
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> > > For additional commands, e-mail: axis-dev-help@ws.apache.org
>>
>> -- 
>> Senior Software Architect
>> WSO2 Inc.
>>
>> ==================================================
>> "Opportunity is missed by most people because it is dressed in 
>> overalls and
>> looks like work."
>> - Thomas Edison
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: axis-dev-help@ws.apache.org
>>
>>
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: [axis2] Code in kernel module reformatted

Posted by Davanum Srinivas <da...@gmail.com>.
It's already checked into svn. Please go ahead and add a link to it
from the developer guidelines.

-- dims

On 3/5/07, Sanjaya Karunasena <sa...@wso2.com> wrote:
> While having it checked in, shall we have the template available for download
> in the website under developer guidelines? It's good if we can have templates
> available for eclipse and netbeans too. I guess commiters who use those IDEs
> will volunteer.
>
> Thanks
> Sanjaya
>
> On Monday 05 March 2007 12:56, David Illsley wrote:
> > hehe. I don't use IDEA but I don't see any harm.
> > David
> >
> > On 04/03/07, Eran Chinthaka <ch...@opensource.lk> wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Glen,
> > >
> > > Can we please have your code formatting template (commit to svn?) as
> > > some people asked for it and then we all can directly use it.
> > >
> > > <Fun>Since most people are using IDEA, I don't think you need to worry
> > > about the other IDEs :)</Fun>
> > >
> > > - -- Chinthaka
> > >
> > > Glen Daniels wrote:
> > > > Hey folks:
> > > >
> > > > I just ran IDEA's code reformatter over the kernel module, with some
> > > > options which I believe match our coding style.  I checked it in
> > > > (http://svn.apache.org/viewvc?view=rev&rev=514453) with no other
> > > > changes except formatting.  Please take a glance at the diffs if you
> > > > like - it does things like rationalize spacing, remove whitespace in
> > > > blank lines and at the end of lines, align parameters, wrap at 100
> > > > columns, etc.
> > > >
> > > > As discussed earlier, I think we should start running this over the
> > > > codebase right before each release's branch is cut.
> > > >
> > > > Yours for cleaner code,
> > > > --Glen
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > > > For additional commands, e-mail: axis-dev-help@ws.apache.org
> > >
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1.4.3 (GNU/Linux)
> > > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> > >
> > > iD8DBQFF60RGjON2uBzUhh8RAq81AKCTn2PSWGEL75Y3ldpz3oMvD6wnuQCfQD73
> > > QuIzhQ7xLUc4MKRwtezPK/M=
> > > =ooTF
> > > -----END PGP SIGNATURE-----
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: axis-dev-help@ws.apache.org
>
> --
> Senior Software Architect
> WSO2 Inc.
>
> ==================================================
> "Opportunity is missed by most people because it is dressed in overalls and
> looks like work."
> - Thomas Edison
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>


-- 
Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web Services Developers

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: [axis2] Code in kernel module reformatted

Posted by Sanjaya Karunasena <sa...@wso2.com>.
While having it checked in, shall we have the template available for download 
in the website under developer guidelines? It's good if we can have templates 
available for eclipse and netbeans too. I guess commiters who use those IDEs 
will volunteer.

Thanks
Sanjaya

On Monday 05 March 2007 12:56, David Illsley wrote:
> hehe. I don't use IDEA but I don't see any harm.
> David
>
> On 04/03/07, Eran Chinthaka <ch...@opensource.lk> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Glen,
> >
> > Can we please have your code formatting template (commit to svn?) as
> > some people asked for it and then we all can directly use it.
> >
> > <Fun>Since most people are using IDEA, I don't think you need to worry
> > about the other IDEs :)</Fun>
> >
> > - -- Chinthaka
> >
> > Glen Daniels wrote:
> > > Hey folks:
> > >
> > > I just ran IDEA's code reformatter over the kernel module, with some
> > > options which I believe match our coding style.  I checked it in
> > > (http://svn.apache.org/viewvc?view=rev&rev=514453) with no other
> > > changes except formatting.  Please take a glance at the diffs if you
> > > like - it does things like rationalize spacing, remove whitespace in
> > > blank lines and at the end of lines, align parameters, wrap at 100
> > > columns, etc.
> > >
> > > As discussed earlier, I think we should start running this over the
> > > codebase right before each release's branch is cut.
> > >
> > > Yours for cleaner code,
> > > --Glen
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: axis-dev-help@ws.apache.org
> >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.3 (GNU/Linux)
> > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> >
> > iD8DBQFF60RGjON2uBzUhh8RAq81AKCTn2PSWGEL75Y3ldpz3oMvD6wnuQCfQD73
> > QuIzhQ7xLUc4MKRwtezPK/M=
> > =ooTF
> > -----END PGP SIGNATURE-----
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-dev-help@ws.apache.org

-- 
Senior Software Architect
WSO2 Inc.

==================================================
“Opportunity is missed by most people because it is dressed in overalls and 
looks like work.”
- Thomas Edison

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: [axis2] Code in kernel module reformatted

Posted by David Illsley <da...@gmail.com>.
hehe. I don't use IDEA but I don't see any harm.
David

On 04/03/07, Eran Chinthaka <ch...@opensource.lk> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Glen,
>
> Can we please have your code formatting template (commit to svn?) as
> some people asked for it and then we all can directly use it.
>
> <Fun>Since most people are using IDEA, I don't think you need to worry
> about the other IDEs :)</Fun>
>
> - -- Chinthaka
>
> Glen Daniels wrote:
> > Hey folks:
> >
> > I just ran IDEA's code reformatter over the kernel module, with some
> > options which I believe match our coding style.  I checked it in
> > (http://svn.apache.org/viewvc?view=rev&rev=514453) with no other changes
> > except formatting.  Please take a glance at the diffs if you like - it
> > does things like rationalize spacing, remove whitespace in blank lines
> > and at the end of lines, align parameters, wrap at 100 columns, etc.
> >
> > As discussed earlier, I think we should start running this over the
> > codebase right before each release's branch is cut.
> >
> > Yours for cleaner code,
> > --Glen
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-dev-help@ws.apache.org
> >
> >
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFF60RGjON2uBzUhh8RAq81AKCTn2PSWGEL75Y3ldpz3oMvD6wnuQCfQD73
> QuIzhQ7xLUc4MKRwtezPK/M=
> =ooTF
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>


-- 
David Illsley - IBM Web Services Development

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: [axis2] Code in kernel module reformatted

Posted by Eran Chinthaka <ch...@opensource.lk>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Glen,

Can we please have your code formatting template (commit to svn?) as
some people asked for it and then we all can directly use it.

<Fun>Since most people are using IDEA, I don't think you need to worry
about the other IDEs :)</Fun>

- -- Chinthaka

Glen Daniels wrote:
> Hey folks:
> 
> I just ran IDEA's code reformatter over the kernel module, with some
> options which I believe match our coding style.  I checked it in
> (http://svn.apache.org/viewvc?view=rev&rev=514453) with no other changes
> except formatting.  Please take a glance at the diffs if you like - it
> does things like rationalize spacing, remove whitespace in blank lines
> and at the end of lines, align parameters, wrap at 100 columns, etc.
> 
> As discussed earlier, I think we should start running this over the
> codebase right before each release's branch is cut.
> 
> Yours for cleaner code,
> --Glen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
> 
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF60RGjON2uBzUhh8RAq81AKCTn2PSWGEL75Y3ldpz3oMvD6wnuQCfQD73
QuIzhQ7xLUc4MKRwtezPK/M=
=ooTF
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Re: [axis2] Code in kernel module reformatted

Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
+1!

Sanjiva.

Glen Daniels wrote:
> Hey folks:
> 
> I just ran IDEA's code reformatter over the kernel module, with some 
> options which I believe match our coding style.  I checked it in 
> (http://svn.apache.org/viewvc?view=rev&rev=514453) with no other changes 
> except formatting.  Please take a glance at the diffs if you like - it 
> does things like rationalize spacing, remove whitespace in blank lines 
> and at the end of lines, align parameters, wrap at 100 columns, etc.
> 
> As discussed earlier, I think we should start running this over the 
> codebase right before each release's branch is cut.
> 
> Yours for cleaner code,
> --Glen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
> 
> 

-- 
Sanjiva Weerawarana, Ph.D.
Founder & Director; Lanka Software Foundation; http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Director; Open Source Initiative; http://www.opensource.org/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org