You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/11/28 07:39:49 UTC

[GitHub] [james-project] vttranlina commented on a diff in pull request #1334: [PERF] Reduce memory allocation upon S3BlobStoreDAO::save(InputStream)

vttranlina commented on code in PR #1334:
URL: https://github.com/apache/james-project/pull/1334#discussion_r1033203581


##########
server/blob/blob-s3/src/main/java/org/apache/james/blob/objectstorage/aws/S3BlobStoreDAO.java:
##########
@@ -326,6 +326,13 @@ public Mono<Void> save(BucketName bucketName, BlobId blobId, ByteSource content)
         }
     }
 
+    private Flux<ByteBuffer> chunkStream(int chunkSize, InputStream stream) {
+        if (chunkSize == 0L) {

Review Comment:
   Convert chunkSize from Long to Int, and compare `L` here?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org