[GitHub] [hudi] yanghua commented on a change in pull request #2445: [HUDI-1633] Make callback return HoodieWriteStat

[GitBox <gi...@apache.org>]

yanghua commented on a change in pull request #2445:
URL: https://github.com/apache/hudi/pull/2445#discussion_r655845818



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/callback/common/HoodieWriteCommitCallbackMessage.java
##########
@@ -41,13 +44,19 @@
    */
   private String basePath;
 
+  /**
+   * HoodieWriteStat.

Review comment:
       Please refactor the comment.

##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/callback/common/HoodieWriteCommitCallbackMessage.java
##########
@@ -41,13 +44,19 @@
    */
   private String basePath;
 
+  /**
+   * HoodieWriteStat.
+   */
+  private List<HoodieWriteStat> hoodieWriteStat;
+
   public HoodieWriteCommitCallbackMessage() {
   }
 
-  public HoodieWriteCommitCallbackMessage(String commitTime, String tableName, String basePath) {
+  public HoodieWriteCommitCallbackMessage(String commitTime, String tableName, String basePath, List<HoodieWriteStat> hoodieWriteStat) {

Review comment:
       Let's remove all the setters and mark all fields to be final.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org