[GitHub] [ozone] aswinshakil commented on a diff in pull request #3847: HDDS-3419. Throw exception when healthy nodes are not sufficient

[GitBox <gi...@apache.org>]

aswinshakil commented on code in PR #3847:
URL: https://github.com/apache/ozone/pull/3847#discussion_r998725874


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java:
##########
@@ -124,6 +124,15 @@ List<DatanodeDetails> filterViableNodes(
     // get nodes in HEALTHY state
     List<DatanodeDetails> healthyNodes =
         nodeManager.getNodes(NodeStatus.inServiceHealthy());
+    if (healthyNodes.size() < nodesRequired) {

Review Comment:
   We are checking this at multiple places here itself. For eg, We reassign `healthyNodes` with `filterNodesWithSpace()`, itself has check for `nodesWithSpace` which is returned back so theoretically `nodesWithSpace <= healthyNodes`.
   https://github.com/apache/ozone/blob/1ff97328b7de88bc35c1665f1c90c0782b3cf7e2/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/SCMCommonPlacementPolicy.java#L226-L242
   
   I don't think this is fixing the problem, I tried running the test with just modifying this line, and it worked.
   https://github.com/apache/ozone/blob/4454e6b368bc5aedaba509eeb85422daeda393bf/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestRatisPipelineCreateAndDestroy.java#L148-L149
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org