You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/08/02 13:05:55 UTC
[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/475
CB-11652 Update run and emulate to skip build
This PR moves handling of `--nobuild` option to CLI. CLI previously has delegated this logic to platform's
`run` method but since introducing `before_deploy` hook we call platform's `build` and `run` separately and now need to handle this option here.
JIRA issue: [CB-11652](https://issues.apache.org/jira/browse/CB-11652)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-11652
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/475.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #475
----
commit 9e4bc845e8d86e174a992a514d9b2292bdda74f1
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-08-02T12:08:24Z
CB-11652 Update run and emulate to skip build
We need to add this conditional logic to cordova's `run` and
`emulate` methods to skip build when `--nobuild` option is
specified. CLI previously has delegated this logic to platform's
`run` method but since introducing `before_deploy` hook we call
platform's `build` and `run` separately and so we need to handle
this option in CLI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-lib/pull/475
You should also check test failures if they occur after squashing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/475
@daserge. @sgrebnov, PTAL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/475
## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/475?src=pr) is 80.68% (diff: 100%)
> Merging [#475](https://codecov.io/gh/apache/cordova-lib/pull/475?src=pr) into [master](https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr) will increase coverage by **0.01%**
```diff
@@ master #475 diff @@
==========================================
Files 68 68
Lines 5400 5404 +4
Methods 856 856
Messages 0 0
Branches 1044 1048 +4
==========================================
+ Hits 4356 4360 +4
Misses 1044 1044
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [a0d8e28...9e4bc84](https://codecov.io/gh/apache/cordova-lib/compare/a0d8e283348f3e99b80ede16220dca845d62d4ae...9e4bc845e8d86e174a992a514d9b2292bdda74f1?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #475: CB-11652 Update run and emulate to skip build
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/475#discussion_r73153070
--- Diff: cordova-lib/src/cordova/emulate.js ---
@@ -42,20 +46,17 @@ module.exports = function emulate(options) {
}).then(function() {
// Deploy in parallel (output gets intermixed though...)
return Q.all(options.platforms.map(function(platform) {
- // This is needed as .build modifies opts
- var optsClone = _.clone(options.options);
- return platform_lib
- .getPlatformApi(platform)
- .build(options.options)
- .then(function() {
- return hooksRunner.fire('before_deploy', options);
- })
- .then(function() {
- optsClone.nobuild = true;
- return platform_lib
- .getPlatformApi(platform)
- .run(optsClone);
- });
+
+ var emulatePromise = options.options.nobuild ? Q() :
--- End diff --
Should this also be called `buildPromise`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-lib/pull/475
Thanks, @daserge, updated. Is this good to go now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #475: CB-11652 Update run and emulate to skip build
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the issue:
https://github.com/apache/cordova-lib/pull/475
Yes, LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org