You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/09 16:24:15 UTC

[GitHub] [shardingsphere] avalon5666 opened a new pull request #7725: Fix mysql binlog type decode

avalon5666 opened a new pull request #7725:
URL: https://github.com/apache/shardingsphere/pull/7725


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7725: Fix mysql binlog type decode

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7725:
URL: https://github.com/apache/shardingsphere/pull/7725#issuecomment-706328986


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=h1) Report
   > Merging [#7725](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3134fbf3700f0871f8593754d6f4f2f0d93dacef?el=desc) will **increase** coverage by `42.38%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7725/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #7725       +/-   ##
   =============================================
   + Coverage     32.81%   75.20%   +42.38%     
   + Complexity     2381      516     -1865     
   =============================================
     Files          1417     1401       -16     
     Lines        104847    22434    -82413     
     Branches       9523     4043     -5480     
   =============================================
   - Hits          34408    16871    -17537     
   + Misses        67754     4474    -63280     
   + Partials       2685     1089     -1596     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/value/string/MySQLStringBinlogProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxTdHJpbmdCaW5sb2dQcm90b2NvbFZhbHVlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ndition/engine/ShardingConditionEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1NoYXJkaW5nQ29uZGl0aW9uRW5naW5lRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/impl/ConditionValueBetweenOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVCZXR3ZWVuT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `69.23% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/impl/ConditionValueCompareOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVDb21wYXJlT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `80.95% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...harding/route/datatime/DatetimeServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2RhdGF0aW1lL0RhdGV0aW1lU2VydmljZUZhY3RvcnkuamF2YQ==) | | | |
   | [.../sql/parser/autogen/SQL92StatementBaseVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi90YXJnZXQvZ2VuZXJhdGVkLXNvdXJjZXMvYW50bHI0L29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9hdXRvZ2VuL1NRTDkyU3RhdGVtZW50QmFzZVZpc2l0b3IuamF2YQ==) | | | |
   | [.../sharding/route/time/TimeServiceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL1RpbWVTZXJ2aWNlQ29uZmlndXJhdGlvbi5qYXZh) | | | |
   | [...phere/sql/parser/autogen/MySQLStatementParser.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC90YXJnZXQvZ2VuZXJhdGVkLXNvdXJjZXMvYW50bHI0L29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9hdXRvZ2VuL015U1FMU3RhdGVtZW50UGFyc2VyLmphdmE=) | | | |
   | ... and [43 more](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=footer). Last update [3134fbf...1b7461c](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7725: Fix mysql binlog type decode

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7725:
URL: https://github.com/apache/shardingsphere/pull/7725#issuecomment-706328986


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=h1) Report
   > Merging [#7725](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3134fbf3700f0871f8593754d6f4f2f0d93dacef?el=desc) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7725/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7725      +/-   ##
   ============================================
   - Coverage     32.81%   32.80%   -0.01%     
   - Complexity     2381     2383       +2     
   ============================================
     Files          1417     1416       -1     
     Lines        104847   104840       -7     
     Branches       9523     9523              
   ============================================
   - Hits          34408    34396      -12     
   - Misses        67754    67757       +3     
   - Partials       2685     2687       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/value/string/MySQLStringBinlogProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxTdHJpbmdCaW5sb2dQcm90b2NvbFZhbHVlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...ext/transaction/GovernanceTransactionContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS1jb3JlLWNvbnRleHQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29udGV4dC90cmFuc2FjdGlvbi9Hb3Zlcm5hbmNlVHJhbnNhY3Rpb25Db250ZXh0cy5qYXZh) | `93.33% <0.00%> (-6.67%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ndition/engine/ShardingConditionEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1NoYXJkaW5nQ29uZGl0aW9uRW5naW5lRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/impl/ConditionValueBetweenOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVCZXR3ZWVuT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `69.23% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/impl/ConditionValueCompareOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVDb21wYXJlT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `80.95% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../sharding/route/time/TimeServiceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL1RpbWVTZXJ2aWNlQ29uZmlndXJhdGlvbi5qYXZh) | | | |
   | [...ding/route/time/spi/SQLServerDatabaseSQLEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL3NwaS9TUUxTZXJ2ZXJEYXRhYmFzZVNRTEVudHJ5LmphdmE=) | | | |
   | [...e/sharding/route/time/spi/SPIDataBaseSQLEntry.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL3NwaS9TUElEYXRhQmFzZVNRTEVudHJ5LmphdmE=) | | | |
   | [...e/sharding/route/time/impl/TimeServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL2ltcGwvVGltZVNlcnZpY2VGYWN0b3J5LmphdmE=) | | | |
   | ... and [24 more](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=footer). Last update [3134fbf...9e66d70](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Lucas-307 commented on a change in pull request #7725: Fix mysql binlog type decode

Posted by GitBox <gi...@apache.org>.
Lucas-307 commented on a change in pull request #7725:
URL: https://github.com/apache/shardingsphere/pull/7725#discussion_r502736666



##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/binlog/row/column/value/string/MySQLStringBinlogProtocolValue.java
##########
@@ -31,18 +31,32 @@
     
     @Override
     public Serializable read(final MySQLBinlogColumnDef columnDef, final MySQLPacketPayload payload) {
-        switch (MySQLColumnType.valueOf(columnDef.getColumnMeta() >> 8)) {
+        int type = columnDef.getColumnMeta() >> 8;
+        int length = columnDef.getColumnMeta() & 0xff;
+        // unpack type & length, see https://bugs.mysql.com/bug.php?id=37426.
+        if ((type & 0x30) != 0x30) {
+            length += ((type & 0x30) ^ 0x30) << 4;
+            type |= 0x30;
+        }
+        switch (MySQLColumnType.valueOf(type)) {
             case MYSQL_TYPE_ENUM:
-                return readEnumValue(columnDef.getColumnMeta() & 0xff, payload);
+                return readEnumValue(length, payload);
             case MYSQL_TYPE_SET:
                 return payload.getByteBuf().readByte();
             case MYSQL_TYPE_STRING:
-                return payload.readStringFix(payload.getByteBuf().readUnsignedByte());
+                return payload.readStringFix(readActualLength(payload, length));

Review comment:
       please make sure args is in the same order.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #7725: Fix mysql binlog type decode

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #7725:
URL: https://github.com/apache/shardingsphere/pull/7725


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7725: Fix mysql binlog type decode

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7725:
URL: https://github.com/apache/shardingsphere/pull/7725#issuecomment-706328986


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=h1) Report
   > Merging [#7725](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3134fbf3700f0871f8593754d6f4f2f0d93dacef?el=desc) will **increase** coverage by `42.38%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7725/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #7725       +/-   ##
   =============================================
   + Coverage     32.81%   75.20%   +42.38%     
   + Complexity     2381      516     -1865     
   =============================================
     Files          1417     1401       -16     
     Lines        104847    22434    -82413     
     Branches       9523     4043     -5480     
   =============================================
   - Hits          34408    16872    -17536     
   + Misses        67754     4474    -63280     
   + Partials       2685     1088     -1597     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...n/value/string/MySQLStringBinlogProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxTdHJpbmdCaW5sb2dQcm90b2NvbFZhbHVlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `78.00% <0.00%> (-2.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...ndition/engine/ShardingConditionEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZW5naW5lL1NoYXJkaW5nQ29uZGl0aW9uRW5naW5lRmFjdG9yeS5qYXZh) | `100.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/impl/ConditionValueBetweenOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVCZXR3ZWVuT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `69.23% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...r/impl/ConditionValueCompareOperatorGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS9jb25kaXRpb24vZ2VuZXJhdG9yL2ltcGwvQ29uZGl0aW9uVmFsdWVDb21wYXJlT3BlcmF0b3JHZW5lcmF0b3IuamF2YQ==) | `80.95% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...harding/route/datatime/DatetimeServiceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2RhdGF0aW1lL0RhdGV0aW1lU2VydmljZUZhY3RvcnkuamF2YQ==) | | | |
   | [.../sql/parser/autogen/SQL92StatementBaseVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi90YXJnZXQvZ2VuZXJhdGVkLXNvdXJjZXMvYW50bHI0L29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9hdXRvZ2VuL1NRTDkyU3RhdGVtZW50QmFzZVZpc2l0b3IuamF2YQ==) | | | |
   | [.../sharding/route/time/TimeServiceConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL1RpbWVTZXJ2aWNlQ29uZmlndXJhdGlvbi5qYXZh) | | | |
   | [...phere/sql/parser/autogen/MySQLStatementParser.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC90YXJnZXQvZ2VuZXJhdGVkLXNvdXJjZXMvYW50bHI0L29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9hdXRvZ2VuL015U1FMU3RhdGVtZW50UGFyc2VyLmphdmE=) | | | |
   | [...rding/route/time/impl/DatabaseDatetimeService.java](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctdGltZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9yb3V0ZS90aW1lL2ltcGwvRGF0YWJhc2VEYXRldGltZVNlcnZpY2UuamF2YQ==) | | | |
   | ... and [42 more](https://codecov.io/gh/apache/shardingsphere/pull/7725/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=footer). Last update [3134fbf...1b7461c](https://codecov.io/gh/apache/shardingsphere/pull/7725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org