You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Matteo Merli <mm...@yahoo-inc.com> on 2015/04/10 23:31:42 UTC
Review Request 33093: Collect stats with sub-milliseconds precision
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33093/
-----------------------------------------------------------
Review request for bookkeeper.
Bugs: BOOKKEEPER-849
https://issues.apache.org/jira/browse/BOOKKEEPER-849
Repository: bookkeeper-git
Description
-------
Most operations in Bookie are taking <1ms. Stats should be collected in nanos , expecially since latencies are already measured in nanos.
Diffs
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java 9036182
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 8b40853
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java 9fbe866
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 1a69692
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java 7384330
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java fe223af
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java b41d15a
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java eb145bd
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java 1b92d09
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java e548f3d
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java b247616
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBaseV3.java ebff526
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 1dbc850
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java 385cf02
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java 0351778
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java 719c937
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java ebb9ebe
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java 02154e5
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/MathUtils.java 32571fa
bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleOpStatsLogger.java 29308a8
bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache/bookkeeper/stats/CodahaleOpStatsTest.java d7f64e9
bookkeeper-stats-providers/twitter-ostrich-provider/src/main/java/org/apache/bookkeeper/stats/twitter/ostrich/OpStatsLoggerImpl.java ba969ba
bookkeeper-stats-providers/twitter-science-provider/src/main/java/org/apache/bookkeeper/stats/twitter/science/OpStatsLoggerImpl.java ac236f6
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/NullStatsLogger.java 21a103d
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/OpStatsLogger.java ca0477f
Diff: https://reviews.apache.org/r/33093/diff/
Testing
-------
Thanks,
Matteo Merli
Re: Review Request 33093: Collect stats with sub-milliseconds
precision
Posted by Sijie Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33093/#review79993
-----------------------------------------------------------
Ship it!
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/OpStatsLogger.java
<https://reviews.apache.org/r/33093/#comment129718>
remove trailing spaces?
- Sijie Guo
On April 10, 2015, 9:31 p.m., Matteo Merli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33093/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 9:31 p.m.)
>
>
> Review request for bookkeeper.
>
>
> Bugs: BOOKKEEPER-849
> https://issues.apache.org/jira/browse/BOOKKEEPER-849
>
>
> Repository: bookkeeper-git
>
>
> Description
> -------
>
> Most operations in Bookie are taking <1ms. Stats should be collected in nanos , expecially since latencies are already measured in nanos.
>
>
> Diffs
> -----
>
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java 9036182
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 8b40853
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java 9fbe866
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 1a69692
> bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java 7384330
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java fe223af
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java b41d15a
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java eb145bd
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java 1b92d09
> bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java e548f3d
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java b247616
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBaseV3.java ebff526
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 1dbc850
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java 385cf02
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java 0351778
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java 719c937
> bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java ebb9ebe
> bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java 02154e5
> bookkeeper-server/src/main/java/org/apache/bookkeeper/util/MathUtils.java 32571fa
> bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleOpStatsLogger.java 29308a8
> bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache/bookkeeper/stats/CodahaleOpStatsTest.java d7f64e9
> bookkeeper-stats-providers/twitter-ostrich-provider/src/main/java/org/apache/bookkeeper/stats/twitter/ostrich/OpStatsLoggerImpl.java ba969ba
> bookkeeper-stats-providers/twitter-science-provider/src/main/java/org/apache/bookkeeper/stats/twitter/science/OpStatsLoggerImpl.java ac236f6
> bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/NullStatsLogger.java 21a103d
> bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/OpStatsLogger.java ca0477f
>
> Diff: https://reviews.apache.org/r/33093/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Matteo Merli
>
>
Re: Review Request 33093: Collect stats with sub-milliseconds
precision
Posted by Matteo Merli <mm...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33093/
-----------------------------------------------------------
(Updated April 14, 2015, 5:11 p.m.)
Review request for bookkeeper.
Changes
-------
Removed trailing spaces
Bugs: BOOKKEEPER-849
https://issues.apache.org/jira/browse/BOOKKEEPER-849
Repository: bookkeeper-git
Description
-------
Most operations in Bookie are taking <1ms. Stats should be collected in nanos , expecially since latencies are already measured in nanos.
Diffs (updated)
-----
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookKeeperServerStats.java 9036182
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 8b40853
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/EntryMemTable.java 9fbe866
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java 1a69692
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java 7384330
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerCreateOp.java fe223af
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java b41d15a
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java eb145bd
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingAddOp.java 1b92d09
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java e548f3d
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java b247616
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBaseV3.java ebff526
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java 1dbc850
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java 385cf02
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessorV3.java 0351778
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessor.java 719c937
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/WriteEntryProcessorV3.java ebb9ebe
bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java 02154e5
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/MathUtils.java 32571fa
bookkeeper-stats-providers/codahale-metrics-provider/src/main/java/org/apache/bookkeeper/stats/CodahaleOpStatsLogger.java 29308a8
bookkeeper-stats-providers/codahale-metrics-provider/src/test/java/org/apache/bookkeeper/stats/CodahaleOpStatsTest.java d7f64e9
bookkeeper-stats-providers/twitter-ostrich-provider/src/main/java/org/apache/bookkeeper/stats/twitter/ostrich/OpStatsLoggerImpl.java ba969ba
bookkeeper-stats-providers/twitter-science-provider/src/main/java/org/apache/bookkeeper/stats/twitter/science/OpStatsLoggerImpl.java ac236f6
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/NullStatsLogger.java 21a103d
bookkeeper-stats/src/main/java/org/apache/bookkeeper/stats/OpStatsLogger.java ca0477f
Diff: https://reviews.apache.org/r/33093/diff/
Testing
-------
Thanks,
Matteo Merli