[GitHub] [tinkerpop] simonz-bq commented on pull request #1472: TINKERPOP-2379 Make defaults consistent with Java

[GitBox <gi...@apache.org>]

simonz-bq commented on pull request #1472:
URL: https://github.com/apache/tinkerpop/pull/1472#issuecomment-917306703


   I updated the PR with the following changes:
   
   - Use maxSimultaneousUsagePerConnection as the equivalent for the MaxInProcessPerConnection in .NET
   - Added JIRA number in title
   - Added description in upgrading for users section
   - Squashed the commits (I'm used to just doing this when merging in the PR)
   
   I think this is a reasonable state for the PR to be in until more discussion is done.
   
   @spmallette The timeouts matched when there was an equivalent option. In JavaScript, I did not see any current configuration for the clients in a way that was changing similar fields as the other languages. Maybe it is worth investigating settings in the underlying clients but I believe that to be outside of the scope of this ticket. Doing something like that requires an agreement that we *do* want to change the default configuration of a different library, and even beyond that it also requires a discussion of whether or not it should be exposed as configuration for the user.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org