[GitHub] [airflow] mik-laj commented on a diff in pull request #22223: DatabricksSqlOperator - switch to databricks-sql-connector 2.x

[GitBox <gi...@apache.org>]

mik-laj commented on code in PR #22223:
URL: https://github.com/apache/airflow/pull/22223#discussion_r856933335


##########
airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -52,14 +43,40 @@ def __init__(
         http_path: Optional[str] = None,
         sql_endpoint_name: Optional[str] = None,
         session_configuration: Optional[Dict[str, str]] = None,
+        http_headers: Optional[List[Tuple[str, str]]] = None,
+        catalog: Optional[str] = None,
+        schema: Optional[str] = None,
+        **kwargs,
     ) -> None:
+        """
+        Initializes DatabricksSqlHook

Review Comment:
   Please move documentarion for init, because it is not visible in reference doc. See: https://www.sphinx-doc.org/en/master/usage/extensions/autodoc.html by default, option autoclass_content is set to class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org