[jira] [Resolved] (CALCITE-3196) In Frameworks, add BasePrepareAction (a functional interface) and deprecate PrepareAction

["Julian Hyde (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CALCITE-3196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-3196.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.21.0

Fixed in [1c5de1c|https://github.com/julianhyde/calcite/commit/1c5de1c].

[~danny0405] I saw you logged a PR. I should have said that I was already working on this - in fact had already fixed it, just needed to test. Sorry we duplicated work.

> In Frameworks, add BasePrepareAction (a functional interface) and deprecate PrepareAction
> -----------------------------------------------------------------------------------------
>
>                 Key: CALCITE-3196
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3196
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Danny Chan
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.21.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In {{Frameworks}}, add {{interface BasePrepareAction}} (a functional interface) and deprecate {{abstract class PrepareAction}}. Because {{PrepareAction}} has a field ({{FrameworkConfig config}}), it cannot be implemented using a lambda. It is simpler and clearer to pass {{config}} as an argument to all methods where it is needed.
> {{PrepareAction}} was introduced in CALCITE-247.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)