You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jonas (JIRA)" <ji...@apache.org> on 2008/06/20 16:49:45 UTC

[jira] Created: (WICKET-1711) Improve Locale fallback in BundleStringResourceLoader

Improve Locale fallback in BundleStringResourceLoader
-----------------------------------------------------

                 Key: WICKET-1711
                 URL: https://issues.apache.org/jira/browse/WICKET-1711
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.4-M2, 1.3.3
            Reporter: Jonas
            Priority: Minor
         Attachments: wicket-1711.patch

While https://issues.apache.org/jira/browse/WICKET-1415 fixed the NPE in BundleStringResourceLoader,
Locale.getDefault() is a bad choice to get the locale from, as it is determined by the default locale of the jvm
running the servlet container. I think it's a big coincidence if the jvm default locale is actually the one the user wants
to see in the webapp - Session#getLocale() would probably be a better default.

Attached is a patch against current trunk (1.4)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1711) Improve Locale fallback in BundleStringResourceLoader

Posted by "Jonas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonas updated WICKET-1711:
--------------------------

    Attachment: wicket-1711.patch

> Improve Locale fallback in BundleStringResourceLoader
> -----------------------------------------------------
>
>                 Key: WICKET-1711
>                 URL: https://issues.apache.org/jira/browse/WICKET-1711
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.3, 1.4-M2
>            Reporter: Jonas
>            Priority: Minor
>         Attachments: wicket-1711.patch
>
>
> While https://issues.apache.org/jira/browse/WICKET-1415 fixed the NPE in BundleStringResourceLoader,
> Locale.getDefault() is a bad choice to get the locale from, as it is determined by the default locale of the jvm
> running the servlet container. I think it's a big coincidence if the jvm default locale is actually the one the user wants
> to see in the webapp - Session#getLocale() would probably be a better default.
> Attached is a patch against current trunk (1.4)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1711) Improve Locale fallback in BundleStringResourceLoader

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1711.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-M3
                   1.3.4
         Assignee: Igor Vaynberg

> Improve Locale fallback in BundleStringResourceLoader
> -----------------------------------------------------
>
>                 Key: WICKET-1711
>                 URL: https://issues.apache.org/jira/browse/WICKET-1711
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.3.3, 1.4-M2
>            Reporter: Jonas
>            Assignee: Igor Vaynberg
>            Priority: Minor
>             Fix For: 1.3.4, 1.4-M3
>
>         Attachments: wicket-1711.patch
>
>
> While https://issues.apache.org/jira/browse/WICKET-1415 fixed the NPE in BundleStringResourceLoader,
> Locale.getDefault() is a bad choice to get the locale from, as it is determined by the default locale of the jvm
> running the servlet container. I think it's a big coincidence if the jvm default locale is actually the one the user wants
> to see in the webapp - Session#getLocale() would probably be a better default.
> Attached is a patch against current trunk (1.4)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.