You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "M4n5ter (via GitHub)" <gi...@apache.org> on 2026/09/06 01:41:47 UTC
[PR] fix(desktop): restore forward scrolling in shared Session history [maka]
M4n5ter opened a new pull request, #4886:
URL: https://github.com/apache/maka/pull/4886
<details open>
<summary>English</summary>
## Problem
Scrolling upward in a shared Session loads older turns into a bounded transcript window and evicts newer turns. Scrolling back down could not reload those turns: Desktop only exposed backward paging. The history trigger also requested older pages on downward movement, while returning to a previously written tail offset could be mistaken for an automatic-scroll echo.
## Changes
- Add forward paging through the existing Session observation surface, available to both Owners and Guests without changing Host protocol or permissions.
- Share adjacent-page loading and validation in the replica. Retain the reading turn while enforcing the existing cache bounds; forward requests start after the visible turn's last resident record.
- Load only toward the reader's scroll direction, handle wheels at either range edge, and leave nested scrollable tool outputs alone.
- Stop treating a previous automatic offset as an echo after the viewport has left it.
## Validation
- Regression tests cover complete and sparse Guest transcripts, repeated backward/forward traversal, bounded residency, in-flight discard, renderer-scoped IPC, visible-turn anchors, and scroll direction.
- Desktop and UI unit suites, Desktop type checks, changed-file lint, and ASF header checks pass.
- Isolated Chromium harness using the actual replica, scroll hook, and prompt rail: the baseline remains at turn 35 after scrolling back down in a 40-turn transcript; the fix reloads turns 36–39. Two full backward/forward traversals, idle request stability, and prompt-anchor navigation also pass.
The browser validation uses a projected transcript fixture, not a live Windows-to-macOS P2P session.
</details>
<details>
<summary>中文</summary>
## 问题
共享 Session 向上滚动时,有界 transcript 窗口加载较早的轮次并淘汰较新的轮次,但 Desktop 只有向前补页接口,向下滚动无法将它们加载回来。此外,原有触发逻辑会在向下滚动时请求更早的历史;回到曾经自动写入的尾部坐标时,还可能被误判为自动滚动回声。
## 修改
- 在现有 Session 观察接口中补齐向后加载,Owner 和 Guest 共用,不修改 Host 协议或权限。
- 复用相邻分页的加载与校验,保护正在阅读的轮次并保持现有缓存边界;向后请求从可见轮次最后一条驻留记录之后开始。
- 按用户滚动方向加载,处理窗口两端无法继续移动的滚轮输入,不抢占嵌套工具输出的滚动。
- 视口离开自动写入的位置后,不再将返回旧坐标视为自动滚动回声。
## 验证
- 回归测试覆盖完整历史、Guest 稀疏序号、反复双向翻页、驻留上限、加载中淘汰、renderer 范围校验、可见轮次锚点与滚动方向。
- Desktop 和 UI 单元测试、Desktop 类型检查、修改文件 lint、ASF 版权头检查通过。
- 隔离 Chromium 页面使用实际 replica、滚动 hook 和 prompt rail:40 轮历史中,旧实现向下滚动仍停在第 35 轮,修复后自动补回第 36–39 轮;完整往返两轮、静置无额外请求及 anchor 点击定位均通过。
浏览器验证使用 Guest 投影视图测试数据,尚未在真实 Windows–macOS P2P 会话上复测。
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(desktop): restore forward scrolling in shared Session history [maka]
Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #4886:
URL: https://github.com/apache/maka/pull/4886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org