[GitHub] [arrow] davidhcoe commented on a diff in pull request #37885: GH-35243: [C#] Implement MapType

["davidhcoe (via GitHub)" <gi...@apache.org>]

davidhcoe commented on code in PR #37885:
URL: https://github.com/apache/arrow/pull/37885#discussion_r1338632006


##########
csharp/test/Apache.Arrow.Tests/ArrowArrayConcatenatorTests.cs:
##########
@@ -495,6 +500,47 @@ public void Visit(UnionType type)
                         new[] { stringResultBuilder.Build().Data, intResultBuilder.Build().Data }));
             }
 
+            public void Visit(MapType type)
+            {
+                MapArray.Builder resultBuilder = new MapArray.Builder(type).Reserve(_baseDataTotalElementCount);
+                //Todo : Support various types

Review Comment:
   what other types?



##########
csharp/src/Apache.Arrow/C/CArrowSchemaImporter.cs:
##########
@@ -206,6 +206,12 @@ public ArrowType GetAsType()
 
                     return new FixedSizeListType(childField, width);
                 }
+                else if (format == "+m")
+                {
+                    return new MapType(
+                        ParseChildren("map").Single(),
+                        (_cSchema->flags & CArrowSchema.ArrowFlagMapKeysSorted) != 0);
+                }
 
                 // TODO: Map type and large list type

Review Comment:
   TODO: large list type



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org