[jira] [Created] (SPARK-4805) BlockTransferMessage.toByteArray() trips assertion

["Sean Owen (JIRA)" <ji...@apache.org>]

Sean Owen created SPARK-4805:
--------------------------------

             Summary: BlockTransferMessage.toByteArray() trips assertion
                 Key: SPARK-4805
                 URL: https://issues.apache.org/jira/browse/SPARK-4805
             Project: Spark
          Issue Type: Bug
          Components: Shuffle
    Affects Versions: 1.1.0
            Reporter: Sean Owen


The {{ByteBuf}} below is allocated to have enough room to encode just the message, but a type byte is written too. The buffer resizes and is left with capacity, which is a minor waste. But when assertions are on, it fails the assertion below. This is triggered by unit tests, but the Java test for this wasn't running. You can verify that a simple "+1" in the allocated size fixes it.

{code}
  public byte[] toByteArray() {
    ByteBuf buf = Unpooled.buffer(encodedLength());
    buf.writeByte(type().id);
    encode(buf);
    assert buf.writableBytes() == 0 : "Writable bytes remain: " + buf.writableBytes();
    return buf.array();
  }
{code}

[~ilikerps]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org