You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Adrian Trenaman (JIRA)" <ji...@apache.org> on 2010/08/20 17:10:16 UTC
[jira] Created: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
features:listUrl should print the repository names as well as the Url.
-----------------------------------------------------------------------
Key: KARAF-148
URL: https://issues.apache.org/jira/browse/KARAF-148
Project: Karaf
Issue Type: Improvement
Affects Versions: 2.0.0
Reporter: Adrian Trenaman
Fix For: 2.2.0
Attachments: KARAF-148.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902440#action_12902440 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
$ svn ci -m "[KARAF-148] features:listUrl should print the repository names as well as the Url."
Adding features/command/src/main/java/org/apache/karaf/features/command/ListRepositoriesCommand.java
Sending features/command/src/main/java/org/apache/karaf/features/command/ListUrlCommand.java
Sending features/command/src/main/resources/OSGI-INF/blueprint/features-command.xml
Transmitting file data ...
Committed revision 989104.
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Moulliard reassigned KARAF-148:
---------------------------------------
Assignee: Charles Moulliard
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Charles Moulliard
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear reassigned KARAF-148:
------------------------------------
Assignee: Jamie goodyear (was: Charles Moulliard)
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Adrian Trenaman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Trenaman updated KARAF-148:
----------------------------------
Attachment: KARAF-148-ListRepositories.patch
Hi Jamie,
Here's the latest patch with the ListRepositories command. Enjoy!
Best,
Ade
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear resolved KARAF-148.
----------------------------------
Resolution: Fixed
New command listRepositories added, original listUrl command output restored.
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901645#action_12901645 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
Thanks Ade! I'll check out the patch and apply it asap :)
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902427#action_12902427 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
It appears that your original patch was committed silently in rev 988118. I'm going to revert the listUrl command back to it's proper form and include your listRepository command.
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (KARAF-148) features:listUrl should
print the repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901645#action_12901645 ]
Jamie goodyear edited comment on KARAF-148 at 8/23/10 7:53 PM:
---------------------------------------------------------------
Thanks Ade! I'll check out the patch and apply it asap :)
There is currently an issue with loading features commands on trunk, will try this patch when that is resolved.
was (Author: jgoodyear):
Thanks Ade! I'll check out the patch and apply it asap :)
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901384#action_12901384 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
Hi Ade,
I like the idea of this new command. I'm always concerned with the idea of presenting a lot of information on the terminal by default -- makes it difficult to use when on a constrained screen (netbook, iphone/blackberry). Will be watching for a new patch :)
Cheers,
Jamie
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Charles Moulliard
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901234#action_12901234 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
Current list format:
{code}
karaf@root> features:listUrl
mvn:org.apache.karaf/apache-karaf/2.0.1-SNAPSHOT/xml/features valid
{code}
Proposed list format:
{code}
karaf@root> features:listUrl
Repository Repository URL
karaf-2.0.1-SNAPSHOT mvn:org.apache.karaf/apache-karaf/2.0.1-SNAPSHOT/xml/features valid
karaf@root>
{code}
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902444#action_12902444 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
Thanks Adrian for the set of patches! :)
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901236#action_12901236 ]
Jamie goodyear commented on KARAF-148:
--------------------------------------
The patch looks great, thanks Adrian. Just thinking that the repository name should be optional when calling "features:listUrl". The command should return the minimal information requested by default, then perhaps give verbose information if requested (eg "features:listUrl -v"). If users think that the verbose output should be the default than I'd be happy to make this change :)
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Adrian Trenaman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrian Trenaman updated KARAF-148:
----------------------------------
Attachment: KARAF-148.patch
Proposed fix attached
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Adrian Trenaman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901307#action_12901307 ]
Adrian Trenaman commented on KARAF-148:
---------------------------------------
Hi Jamie,
I know what you mean about keeping the results minimal: it makes it easier if we're using these commands in scripts. Here's a counter proposal: why don't we
a) leave features:listUrl as it is, just listing the URLs.
b) create a new command features:listRepositories that lists the repository names.
c) add a '-v' flag to listRepositories that prints out the repository name *and* the repository URL (and any other information we want)
I'd be happy to implement this if you'll agree to commit!
Cheers,
Ade.
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Fix For: 2.2.0
>
> Attachments: KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (KARAF-148) features:listUrl should print the
repository names as well as the Url.
Posted by "Jamie goodyear (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-148 started by Jamie goodyear.
> features:listUrl should print the repository names as well as the Url.
> -----------------------------------------------------------------------
>
> Key: KARAF-148
> URL: https://issues.apache.org/jira/browse/KARAF-148
> Project: Karaf
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Adrian Trenaman
> Assignee: Jamie goodyear
> Fix For: 2.2.0
>
> Attachments: KARAF-148-ListRepositories.patch, KARAF-148.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.