You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/08/30 11:34:30 UTC

[GitHub] [solr] danrosher opened a new pull request, #988: SOLR-16361

danrosher opened a new pull request, #988:
URL: https://github.com/apache/solr/pull/988

   https://issues.apache.org/jira/browse/SOLR-16361
   
   # Description
   
   use double instead of float for modulus
   
   # Solution
   
   use double instead of float for modulus
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request title.
   - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] danrosher commented on pull request #988: SOLR-16361

Posted by GitBox <gi...@apache.org>.
danrosher commented on PR #988:
URL: https://github.com/apache/solr/pull/988#issuecomment-1231546337

   mistakenly opened


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] epugh commented on a diff in pull request #988: SOLR-16361

Posted by GitBox <gi...@apache.org>.
epugh commented on code in PR #988:
URL: https://github.com/apache/solr/pull/988#discussion_r958365604


##########
solr/core/src/java/org/apache/solr/search/ValueSourceParser.java:
##########
@@ -100,12 +100,7 @@
 import org.apache.solr.search.facet.UniqueBlockFieldAgg;
 import org.apache.solr.search.facet.UniqueBlockQueryAgg;
 import org.apache.solr.search.facet.VarianceAgg;
-import org.apache.solr.search.function.CollapseScoreFunction;
-import org.apache.solr.search.function.ConcatStringFunction;
-import org.apache.solr.search.function.EqualFunction;
-import org.apache.solr.search.function.OrdFieldSource;
-import org.apache.solr.search.function.ReverseOrdFieldSource;
-import org.apache.solr.search.function.SolrComparisonBoolFunction;
+import org.apache.solr.search.function.*;

Review Comment:
   we actually use explicit imports ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org

[GitHub] [solr] danrosher closed pull request #988: SOLR-16361

Posted by GitBox <gi...@apache.org>.
danrosher closed pull request #988: SOLR-16361
URL: https://github.com/apache/solr/pull/988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org