You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/07/13 03:27:00 UTC
[kudu-CR] [net util] fix comment on maximum PID in 18-bit space
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13859
Change subject: [net_util] fix comment on maximum PID in 18-bit space
......................................................................
[net_util] fix comment on maximum PID in 18-bit space
This changelist does not contain any functional modifications.
Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
---
M src/kudu/util/net/net_util.cc
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/13859/1
--
To view, visit http://gerrit.cloudera.org:8080/13859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Gerrit-Change-Number: 13859
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [net util] fix comment on maximum PID in 18-bit space
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [net_util] fix comment on maximum PID in 18-bit space
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Gerrit-Change-Number: 13859
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [net util] fix comment on maximum PID in 18-bit space
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13859 )
Change subject: [net_util] fix comment on maximum PID in 18-bit space
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Gerrit-Change-Number: 13859
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 15 Jul 2019 21:06:03 +0000
Gerrit-HasComments: No
[kudu-CR] [net util] fix comment on maximum PID in 18-bit space
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13859 )
Change subject: [net_util] fix comment on maximum PID in 18-bit space
......................................................................
Patch Set 2: Verified+1
Unrelated flake in Params/ScanCorruptedDeltasParamTest.Test/0
--
To view, visit http://gerrit.cloudera.org:8080/13859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Gerrit-Change-Number: 13859
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 15 Jul 2019 21:57:51 +0000
Gerrit-HasComments: No
[kudu-CR] [net util] fix comment on maximum PID in 18-bit space
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13859 )
Change subject: [net_util] fix comment on maximum PID in 18-bit space
......................................................................
[net_util] fix comment on maximum PID in 18-bit space
This changelist does not contain any functional modifications.
Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Reviewed-on: http://gerrit.cloudera.org:8080/13859
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Gerrit-Change-Number: 13859
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [net util] fix comment on maximum PID in 18-bit space
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13859
to look at the new patch set (#2).
Change subject: [net_util] fix comment on maximum PID in 18-bit space
......................................................................
[net_util] fix comment on maximum PID in 18-bit space
This changelist does not contain any functional modifications.
Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
---
M src/kudu/util/net/net_util.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/13859/2
--
To view, visit http://gerrit.cloudera.org:8080/13859
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3226c1b8c928e1558c9e62b7e43c80bdd8745e9
Gerrit-Change-Number: 13859
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)