[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #715: feat: add label-selector for watching namespace

[GitBox <gi...@apache.org>]

tao12345666333 commented on a change in pull request #715:
URL: https://github.com/apache/apisix-ingress-controller/pull/715#discussion_r731475754



##########
File path: pkg/ingress/compare.go
##########
@@ -50,17 +50,17 @@ func (c *Controller) CompareResources(ctx context.Context) error {
 			log.Error(err.Error())
 			ctx.Done()
 		} else {
-			wns := make(map[string]struct{}, len(nsList.Items))
+			//wns := make(map[string]struct{}, len(nsList.Items))

Review comment:
       Remove this comment 

##########
File path: docs/en/latest/practices/the-hard-way.md
##########
@@ -623,6 +623,8 @@ data:
       resync_interval: "30s"
       app_namespaces:
       - "*"

Review comment:
       this one should be deleted?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org