You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sam Okrent (Code Review)" <ge...@cloudera.org> on 2017/07/25 22:24:26 UTC
[kudu-CR] Add security dashboard to web UI
Sam Okrent has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7505
Change subject: Add security dashboard to web UI
......................................................................
Add security dashboard to web UI
Adds a new "Configuration" page to the web UI
that displays a list of security configuration
options, their current values, whether or not
they're the most secure settings, and
explanations of what flags control them.
Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
---
M src/kudu/server/default-path-handlers.cc
A www/config.mustache
2 files changed, 80 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/7505/1
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
[kudu-CR] Add security dashboard to web UI
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add security dashboard to web UI
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7505/1/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
Line 200: rpc_encryption["secure"] = (FLAGS_rpc_encryption == "required");
Use boost::iequals in order to do a case insensitive compare here and below.
PS1, Line 218: via
'Configure with' to keep it consistent
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] Add security dashboard to web UI
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Sam Okrent has posted comments on this change.
Change subject: Add security dashboard to web UI
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7505/1/src/kudu/server/default-path-handlers.cc
File src/kudu/server/default-path-handlers.cc:
Line 200: rpc_encryption["secure"] = (FLAGS_rpc_encryption == "required");
> Use boost::iequals in order to do a case insensitive compare here and below
Done
PS1, Line 218: via
> 'Configure with' to keep it consistent
Done
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-HasComments: Yes
[kudu-CR] Add security dashboard to web UI
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add security dashboard to web UI
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-HasComments: No
[kudu-CR] Add security dashboard to web UI
Posted by "Sam Okrent (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7505
to look at the new patch set (#2).
Change subject: Add security dashboard to web UI
......................................................................
Add security dashboard to web UI
Adds a new "Configuration" page to the web UI
that displays a list of security configuration
options, their current values, whether or not
they're the most secure settings, and
explanations of what flags control them.
Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
---
M src/kudu/server/default-path-handlers.cc
A www/config.mustache
M www/kudu.css
3 files changed, 85 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/7505/2
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add security dashboard to web UI
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Add security dashboard to web UI
......................................................................
Add security dashboard to web UI
Adds a new "Configuration" page to the web UI
that displays a list of security configuration
options, their current values, whether or not
they're the most secure settings, and
explanations of what flags control them.
Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Reviewed-on: http://gerrit.cloudera.org:8080/7505
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/server/default-path-handlers.cc
A www/config.mustache
M www/kudu.css
3 files changed, 85 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
[kudu-CR] Add security dashboard to web UI
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Add security dashboard to web UI
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7505
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I632c3b757386e0282000bcb9562b6dc3622dde93
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sam Okrent <sa...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sam Okrent <sa...@cloudera.com>
Gerrit-HasComments: No