[GitHub] [cassandra] adelapena commented on a change in pull request #800: CASSANDRA-16186 (3.11): Remove the SEPExecutor blocking behavior

[GitBox <gi...@apache.org>]

adelapena commented on a change in pull request #800:
URL: https://github.com/apache/cassandra/pull/800#discussion_r518229958



##########
File path: src/java/org/apache/cassandra/concurrent/SEPExecutor.java
##########
@@ -35,16 +35,13 @@
 
     public final int maxWorkers;
     public final String name;
-    private final int maxTasksQueued;
     private final SEPMetrics metrics;
 
     // stores both a set of work permits and task permits:
     //  bottom 32 bits are number of queued tasks, in the range [0..maxTasksQueued]   (initially 0)
     //  top 32 bits are number of work permits available in the range [0..maxWorkers]   (initially maxWorkers)
     private final AtomicLong permits = new AtomicLong();
 
-    // producers wait on this when there is no room on the queue
-    private final WaitQueue hasRoom = new WaitQueue();

Review comment:
       Nit: This leaves a unused import of `WaitQueue`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org