You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/05 14:01:12 UTC
[GitHub] [inlong] GanfengTan opened a new pull request, #5383: [INLONG-5382][Manager][Agent] Optimized the file collection configuration
GanfengTan opened a new pull request, #5383:
URL: https://github.com/apache/inlong/pull/5383
1.The collection mode of configuration file content can be incremental or full.
2.Line ends the regular expression.
3.Data source separator.
4.Appends file metadata parameters.
- Fixes #5382
### Motivation
Enhance the ability to collect files.
### Modifications
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap merged pull request #5383: [INLONG-5382][Manager][Agent] Optimized the file collection configuration
Posted by GitBox <gi...@apache.org>.
EMsnap merged PR #5383:
URL: https://github.com/apache/inlong/pull/5383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #5383: [INLONG-5382][Manager][Agent] Optimized the file collection configuration
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5383:
URL: https://github.com/apache/inlong/pull/5383#discussion_r939518152
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/FileJob.java:
##########
@@ -88,6 +90,12 @@ public static class FileJobTaskConfig {
private String envList;
private List<Map<String, String>> metaFields;
+ // Type of data result for column separator
+ // for example: separator(,),(|),(,)--CSV or json
Review Comment:
What does `--CSV or json` mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] GanfengTan commented on a diff in pull request #5383: [INLONG-5382][Manager][Agent] Optimized the file collection configuration
Posted by GitBox <gi...@apache.org>.
GanfengTan commented on code in PR #5383:
URL: https://github.com/apache/inlong/pull/5383#discussion_r939520451
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/FileJob.java:
##########
@@ -88,6 +90,12 @@ public static class FileJobTaskConfig {
private String envList;
private List<Map<String, String>> metaFields;
+ // Type of data result for column separator
+ // for example: separator(,),(|),(,)--CSV or json
Review Comment:
Modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org