You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Noorul Islam K M <no...@collab.net> on 2011/06/23 12:32:23 UTC

[PATCH] Fix for issue 3931.

Log 

[[[ 

Fix for issue 3931. 'svn log' is returning log of unrelated path when
peg revision is not related to operative revision. This is happening
when HEAD is used in operative range. This commit fixes this.

* subversion/libsvn_client/log.c
  (svn_client_log5): Handle HEAD in operative revision range.

* subversion/tests/cmdline/log_tests.py
  (log_with_unrelated_peg_and_operative_revs): Remove XFail marker.
    Fix expected error message.

Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
]]]

Re: [PATCH] Fix for issue 3931.

Posted by Noorul Islam K M <no...@collab.net>.

Stefan Sperling <st...@elego.de> writes:

> On Thu, Jun 23, 2011 at 04:02:23PM +0530, Noorul Islam K M wrote:
>
>> 
>> Log 
>> 
>> [[[ 
>> 
>> Fix for issue 3931. 'svn log' is returning log of unrelated path when
>> peg revision is not related to operative revision. This is happening
>> when HEAD is used in operative range. This commit fixes this.
>> 
>> * subversion/libsvn_client/log.c
>>   (svn_client_log5): Handle HEAD in operative revision range.
>> 
>> * subversion/tests/cmdline/log_tests.py
>>   (log_with_unrelated_peg_and_operative_revs): Remove XFail marker.
>>     Fix expected error message.
>> 
>> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
>> ]]]
>> 
>
> Thanks, committed in r1138830.
>
> I was trying to fix this myself yesterday but I could not find
> the bug :(  Good catch!
>

Thank you!

> BTW, in the future, please include more information in the subject
> line than just an issue number. E.g. does no harm to copy the issue
> description field into the Subject line, like this:
>
>   Subject: [PATCH] Fix issue 3931: svn log returns log of unrelated path
>
> This provides a lot more context for those browsing their email
> or the archive for interesting threads.

Sure, I will keep this in mind.

Thanks and Regards
Noorul

Re: [PATCH] Fix for issue 3931.

Posted by Stefan Sperling <st...@elego.de>.

On Thu, Jun 23, 2011 at 04:02:23PM +0530, Noorul Islam K M wrote:
> 
> Log 
> 
> [[[ 
> 
> Fix for issue 3931. 'svn log' is returning log of unrelated path when
> peg revision is not related to operative revision. This is happening
> when HEAD is used in operative range. This commit fixes this.
> 
> * subversion/libsvn_client/log.c
>   (svn_client_log5): Handle HEAD in operative revision range.
> 
> * subversion/tests/cmdline/log_tests.py
>   (log_with_unrelated_peg_and_operative_revs): Remove XFail marker.
>     Fix expected error message.
> 
> Patch by: Noorul Islam K M <noorul{_AT_}collab.net>
> ]]]
> 

Thanks, committed in r1138830.

I was trying to fix this myself yesterday but I could not find
the bug :(  Good catch!

BTW, in the future, please include more information in the subject
line than just an issue number. E.g. does no harm to copy the issue
description field into the Subject line, like this:

  Subject: [PATCH] Fix issue 3931: svn log returns log of unrelated path

This provides a lot more context for those browsing their email
or the archive for interesting threads.