You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/07/19 13:09:05 UTC
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull
request #2683: NO-JIRA typo on logger
clebertsuconic commented on a change in pull request #2683: NO-JIRA typo on logger
URL: https://github.com/apache/activemq-artemis/pull/2683#discussion_r305348770
##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationManager.java
##########
@@ -613,7 +613,7 @@ private void flushReplicationStream(FlushAction action) throws Exception {
action.reset();
replicationStream.execute(action);
if (!action.await(this.timeout, TimeUnit.MILLISECONDS)) {
Review comment:
@wy96f / @michaelandrepearce from what I looked, the correct fix would be:
```java
if (!action.await(this.initialReplicationTimeout, TimeUnit.MILLISECONDS))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services