You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2012/07/04 02:07:34 UTC
[jira] [Created] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol define at application startup
Howard M. Lewis Ship created TAP5-1965:
------------------------------------------
Summary: Replace use of Request.getContextPath() with a symbol define at application startup
Key: TAP5-1965
URL: https://issues.apache.org/jira/browse/TAP5-1965
Project: Tapestry 5
Issue Type: Task
Components: tapestry-core
Affects Versions: 5.4
Reporter: Howard M. Lewis Ship
This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol define at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407272#comment-13407272 ]
Howard M. Lewis Ship commented on TAP5-1965:
--------------------------------------------
Fixed in 5.4-js-rewrite branch.
> Replace use of Request.getContextPath() with a symbol define at application startup
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol defined at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1965:
---------------------------------------
Labels: fixed-in-5.4-js-rewrite (was: )
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol defined at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1965:
---------------------------------------
Summary: Replace use of Request.getContextPath() with a symbol defined at application startup (was: Replace use of Request.getContextPath() with a symbol define at application startup)
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol define at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407272#comment-13407272 ]
Howard M. Lewis Ship edited comment on TAP5-1965 at 7/5/12 4:56 PM:
--------------------------------------------------------------------
Fixed in 5.4-js-rewrite branch, will close issue when merged into master.
was (Author: hlship):
Fixed in 5.4-js-rewrite branch.
> Replace use of Request.getContextPath() with a symbol define at application startup
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol defined at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1965:
---------------------------------------
Labels: fixed-in-5.4-js-rewrite (was: )
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol defined at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1965:
---------------------------------------
Summary: Replace use of Request.getContextPath() with a symbol defined at application startup (was: Replace use of Request.getContextPath() with a symbol define at application startup)
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol define at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407272#comment-13407272 ]
Howard M. Lewis Ship commented on TAP5-1965:
--------------------------------------------
Fixed in 5.4-js-rewrite branch.
> Replace use of Request.getContextPath() with a symbol define at application startup
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol define at application startup
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407272#comment-13407272 ]
Howard M. Lewis Ship edited comment on TAP5-1965 at 7/5/12 4:56 PM:
--------------------------------------------------------------------
Fixed in 5.4-js-rewrite branch, will close issue when merged into master.
was (Author: hlship):
Fixed in 5.4-js-rewrite branch.
> Replace use of Request.getContextPath() with a symbol define at application startup
> -----------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol defined at application startup
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491329#comment-13491329 ]
Jochen Kemnade commented on TAP5-1965:
--------------------------------------
I think, the fix might not be entirely correct. In AssetPathConstructorImpl:59/60 [1], the context path is expected to end with a slash, which it doesn't. The ServletContext API [2] says that it starts with a slash but doesn't end with one. Currently, for a context "app" it produces paths like //appassets/...
[1] https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java;h=3d81b8f2d6b13693984c3ef716e28a96a39f3c10;hb=3d81b8f2d6b13693984c3ef716e28a96a39f3c10#l59
[2] http://docs.oracle.com/javaee/5/api/javax/servlet/ServletContext.html#getContextPath%28%29
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1965) Replace use of
Request.getContextPath() with a symbol defined at application startup
Posted by "Jochen Kemnade (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491329#comment-13491329 ]
Jochen Kemnade commented on TAP5-1965:
--------------------------------------
I think, the fix might not be entirely correct. In AssetPathConstructorImpl:59/60 [1], the context path is expected to end with a slash, which it doesn't. The ServletContext API [2] says that it starts with a slash but doesn't end with one. Currently, for a context "app" it produces paths like //appassets/...
[1] https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;a=blob;f=tapestry-core/src/main/java/org/apache/tapestry5/internal/services/assets/AssetPathConstructorImpl.java;h=3d81b8f2d6b13693984c3ef716e28a96a39f3c10;hb=3d81b8f2d6b13693984c3ef716e28a96a39f3c10#l59
[2] http://docs.oracle.com/javaee/5/api/javax/servlet/ServletContext.html#getContextPath%28%29
> Replace use of Request.getContextPath() with a symbol defined at application startup
> ------------------------------------------------------------------------------------
>
> Key: TAP5-1965
> URL: https://issues.apache.org/jira/browse/TAP5-1965
> Project: Tapestry 5
> Issue Type: Task
> Components: tapestry-core
> Affects Versions: 5.4
> Reporter: Howard M. Lewis Ship
> Labels: fixed-in-5.4-js-rewrite
>
> This was not possible in earlier versions of the Servlet API, but since 2.5, it it possible to identify the context path from the ServletContext object.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira