You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Davide Giannella <da...@apache.org> on 2015/02/05 10:37:34 UTC
[X-POST] integrationTesting on check-release
Hello team,
cross posting as it actually affects both jackrabbit as well as oak.
They both share the check-release.sh.
My suggestion is to add the integrationTesting profile on the check
release process to ensure a higher checks before actually providing a +1.
below a suggested (not tested yet) change on the script.
Thoughts?
Cheers
Davide
Index: check-release.sh
===================================================================
--- check-release.sh (revision 7939)
+++ check-release.sh (working copy)
@@ -149,10 +149,10 @@
info ""
info " Running the Maven build..."
info ""
-if (cd $ZIPDIR; exec mvn verify -Ppedantic) 2>> "$LOGFILE" 1>&2; then
- info " OK: mvn verify -Ppedantic"
+if (cd $ZIPDIR; exec mvn verify -Ppedantic,integrationTesting) 2>>
"$LOGFILE" 1>&2; then
+ info " OK: mvn verify -Ppedantic,integrationTesting"
else
- error " NOT OK: mvn verify -Ppedantic"
+ error " NOT OK: mvn verify -Ppedantic,integrationTesting"
fi
info ""
Re: [X-POST] integrationTesting on check-release
Posted by Michael Dürig <md...@apache.org>.
On 9.2.15 9:55 , Davide Giannella wrote:
> for some reasons I don't have enough privileges for assigning it to myself.
I added you to the PMC role in the JCR project. This should fix it.
Michael
Re: [X-POST] integrationTesting on check-release
Posted by Davide Giannella <da...@apache.org>.
On 06/02/2015 17:00, Michael Dürig wrote:
>
>
> On 6.2.15 10:28 , Michael Dürig wrote:
>>
>> I'd prefer not to run ITs during the release check as it potentially
>> takes a long time. The release check process is mainly about checking
>> the validity of the release artefacts [1]. Passing ITs should mainly be
>> enforced by our CIs (aka OAK-2476).
>>
>> Maybe a good option is to add a flag to the script so people could run
>> ITs volunteerly.
>>
>> [1] https://www.apache.org/dev/release-publishing#valid
>
> Created https://issues.apache.org/jira/browse/JCR-3849 to track this.
Thanks Michael,
for some reasons I don't have enough privileges for assigning it to myself.
Can someone please add my account to the JCR project? Get in touch with
me directly for additional details if are needed.
Cheers
Davide
Re: [X-POST] integrationTesting on check-release
Posted by Michael Dürig <md...@apache.org>.
On 6.2.15 10:28 , Michael Dürig wrote:
>
> I'd prefer not to run ITs during the release check as it potentially
> takes a long time. The release check process is mainly about checking
> the validity of the release artefacts [1]. Passing ITs should mainly be
> enforced by our CIs (aka OAK-2476).
>
> Maybe a good option is to add a flag to the script so people could run
> ITs volunteerly.
>
> [1] https://www.apache.org/dev/release-publishing#valid
Created https://issues.apache.org/jira/browse/JCR-3849 to track this.
Michael
>
> Michael
>
> On 5.2.15 10:37 , Davide Giannella wrote:
>> Hello team,
>>
>> cross posting as it actually affects both jackrabbit as well as oak.
>> They both share the check-release.sh.
>>
>> My suggestion is to add the integrationTesting profile on the check
>> release process to ensure a higher checks before actually providing a +1.
>>
>> below a suggested (not tested yet) change on the script.
>>
>> Thoughts?
>>
>> Cheers
>> Davide
>>
>> Index: check-release.sh
>> ===================================================================
>> --- check-release.sh (revision 7939)
>> +++ check-release.sh (working copy)
>> @@ -149,10 +149,10 @@
>> info ""
>> info " Running the Maven build..."
>> info ""
>> -if (cd $ZIPDIR; exec mvn verify -Ppedantic) 2>> "$LOGFILE" 1>&2; then
>> - info " OK: mvn verify -Ppedantic"
>> +if (cd $ZIPDIR; exec mvn verify -Ppedantic,integrationTesting) 2>>
>> "$LOGFILE" 1>&2; then
>> + info " OK: mvn verify -Ppedantic,integrationTesting"
>> else
>> - error " NOT OK: mvn verify -Ppedantic"
>> + error " NOT OK: mvn verify -Ppedantic,integrationTesting"
>> fi
>> info ""
>>
>>
Re: [X-POST] integrationTesting on check-release
Posted by Davide Giannella <da...@apache.org>.
On 06/02/2015 09:28, Michael Dürig wrote:
>
> ...
> Maybe a good option is to add a flag to the script so people could run
> ITs volunteerly.
+1.
Could you please file a ticket somewhere? Don't know if JCR or OAK. Just
for not loosing it. You can even assign it to me. I'll have a look when
I'll be less loaded.
D.
Re: [X-POST] integrationTesting on check-release
Posted by Michael Dürig <md...@apache.org>.
I'd prefer not to run ITs during the release check as it potentially
takes a long time. The release check process is mainly about checking
the validity of the release artefacts [1]. Passing ITs should mainly be
enforced by our CIs (aka OAK-2476).
Maybe a good option is to add a flag to the script so people could run
ITs volunteerly.
[1] https://www.apache.org/dev/release-publishing#valid
Michael
On 5.2.15 10:37 , Davide Giannella wrote:
> Hello team,
>
> cross posting as it actually affects both jackrabbit as well as oak.
> They both share the check-release.sh.
>
> My suggestion is to add the integrationTesting profile on the check
> release process to ensure a higher checks before actually providing a +1.
>
> below a suggested (not tested yet) change on the script.
>
> Thoughts?
>
> Cheers
> Davide
>
> Index: check-release.sh
> ===================================================================
> --- check-release.sh (revision 7939)
> +++ check-release.sh (working copy)
> @@ -149,10 +149,10 @@
> info ""
> info " Running the Maven build..."
> info ""
> -if (cd $ZIPDIR; exec mvn verify -Ppedantic) 2>> "$LOGFILE" 1>&2; then
> - info " OK: mvn verify -Ppedantic"
> +if (cd $ZIPDIR; exec mvn verify -Ppedantic,integrationTesting) 2>>
> "$LOGFILE" 1>&2; then
> + info " OK: mvn verify -Ppedantic,integrationTesting"
> else
> - error " NOT OK: mvn verify -Ppedantic"
> + error " NOT OK: mvn verify -Ppedantic,integrationTesting"
> fi
> info ""
>
>