[GitHub] [incubator-doris] imay commented on a change in pull request #1967: Lost rowset during tablet revise tablet meta

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1967: Lost rowset during tablet revise tablet meta
URL: https://github.com/apache/incubator-doris/pull/1967#discussion_r334233846
 
 

 ##########
 File path: be/src/olap/tablet.h
 ##########
 @@ -242,6 +242,8 @@ class Tablet : public std::enable_shared_from_this<Tablet> {
 
     void build_tablet_report_info(TTabletInfo* tablet_info);
 
+    OLAPStatus clone_tablet_meta(TabletMetaSharedPtr new_tablet_meta);
 
 Review comment:
   What locks does caller need to hold? one or two?
   And why not implement as a TabletMeta static function? which like
   static copy(const TabletMeta& src, TabletMeta* dest)?
   
   If the function name is clone, I don't know the direction of clone operation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org