[jira] [Commented] (FLINK-10127) Add TypeInformation and serializers for JDK8 Instant

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16578935#comment-16578935 ] 

ASF GitHub Bot commented on FLINK-10127:
----------------------------------------

alexeyt820 opened a new pull request #6549: [FLINK-10127] Add Instant to basic types
URL: https://github.com/apache/flink/pull/6549
 
 
   ## What is the purpose of the change
   This pull requests add JDK8 Instant type as basic type to Flink type system
   ## Brief change log
     - *InstantSerializer* added 
     - *InstantComparator* added
     - *BasicTypeInfo* modified to include *INSTANT_TYPE_INFO*
     - "Types" modified to include *INSTANT*
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - *Added unit tests for InstantSerializer and InstantComparator*
   - *Modified BasicTypeInfoTest to include Instant*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes
     - The serializers: yes
     - The runtime per-record code paths (performance sensitive):  don't know
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: don't know
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - https://ci.apache.org/projects/flink/flink-docs-release-1.6/dev/types_serialization.html#flinks-typeinformation-class should be modified to include Instant  
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add TypeInformation  and serializers for JDK8 Instant
> -----------------------------------------------------
>
>                 Key: FLINK-10127
>                 URL: https://issues.apache.org/jira/browse/FLINK-10127
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Alexey Trenikhin
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently Flink's basic types include all Java primitives and their boxed form, plus {{void}}, {{String}}, {{Date}}, {{BigDecimal}}, and {{BigInteger}}. New JDK8 Instance type should be added as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)