You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/26 10:14:00 UTC

[GitHub] [kafka] cadonna commented on a diff in pull request #12562: KAFKA-10199: Remove tasks from state updater on shutdown

cadonna commented on code in PR #12562:
URL: https://github.com/apache/kafka/pull/12562#discussion_r955892807


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##########
@@ -60,6 +60,7 @@ private class StateUpdaterThread extends Thread {
         private final ChangelogReader changelogReader;
         private final AtomicBoolean isRunning = new AtomicBoolean(true);
         private final Map<TaskId, Task> updatingTasks = new ConcurrentHashMap<>();
+        private final Map<TaskId, Task> pausedTasks = new ConcurrentHashMap<>();

Review Comment:
   I moved the map of paused tasks from the state update to the state updater thread since it actually is -- as the map of updating tasks -- an internal data structure of the thread.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org