You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhannngchen (via GitHub)" <gi...@apache.org> on 2023/03/09 11:00:27 UTC

[GitHub] [doris] zhannngchen commented on a diff in pull request #17617: [fix](merge-on-write) when if publish and be down, need recalc delete bitmap for MoW

zhannngchen commented on code in PR #17617:
URL: https://github.com/apache/doris/pull/17617#discussion_r1130827357


##########
be/src/olap/tablet.cpp:
##########
@@ -2590,7 +2590,8 @@ Status Tablet::update_delete_bitmap_without_lock(const RowsetSharedPtr& rowset)
     return Status::OK();
 }
 
-Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const TabletTxnInfo* load_info) {
+Status Tablet::update_delete_bitmap(const RowsetSharedPtr& rowset, const TabletTxnInfo* load_info,
+                                    bool need_recalc_delete_bitmap) {

Review Comment:
   Don't need to add an extra parameter, just set load_info->num_keys=-1, and only check correctness when num_keys >=0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org