[GitHub] [spark] gengliangwang commented on a change in pull request #24738: [SPARK-23098][SQL] Migrate Kafka Batch source to v2.

[GitBox <gi...@apache.org>]

gengliangwang commented on a change in pull request #24738: [SPARK-23098][SQL] Migrate Kafka Batch source to v2.
URL: https://github.com/apache/spark/pull/24738#discussion_r298474502
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
 ##########
 @@ -212,8 +213,14 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging {
         f.fallbackFileFormat
       case _ => lookupCls
     }
+    val clsMustUseV1Source = cls.newInstance() match {
+      case f: DataSourceRegister if useV1Sources.contains(f.shortName()) ||
 
 Review comment:
   Yes, I  think we can update the code in line 210 directly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org