Re: svn commit: r631669 - in /incubator/sling/trunk: api/src/main/java/org/apache/sling/api/ api/src/main/java/org/apache/sling/api/scripting/ api/src/main/java/org/apache/sling/api/services/ api/src/main/java/org/apache/sling/api/servlets/ api/src/main/ja...

[Felix Meschberger <Fe...@day.com>]

Hi,

Am Mittwoch, den 27.02.2008, 18:24 +0000 schrieb cziegeler@apache.org:
> Author: cziegeler
> Date: Wed Feb 27 10:24:23 2008
> New Revision: 631669
> 
> URL: http://svn.apache.org/viewvc?rev=631669&view=rev
> Log:
> IN PROGRESS - issue SLING-279: ServiceLocator clean up 
> https://issues.apache.org/jira/browse/SLING-279
> Remove ServiceLocator interface and from request.
> 
> ...
> Modified:
> incubator/sling/trunk/launchpad/launchpad-servlets/src/main/java/org/apache/sling/ujax/UjaxPostServlet.java
> URL: http://svn.apache.org/viewvc/incubator/sling/trunk/launchpad/launchpad-servlets/src/main/java/org/apache/sling/ujax/UjaxPostServlet.java?rev=631669&r1=631668&r2=631669&view=diff
> ==============================================================================
> --- incubator/sling/trunk/launchpad/launchpad-servlets/src/main/java/org/apache/sling/ujax/UjaxPostServlet.java (original)
> +++ incubator/sling/trunk/launchpad/launchpad-servlets/src/main/java/org/apache/sling/ujax/UjaxPostServlet.java Wed Feb 27 10:24:23 2008
> @@ -145,6 +146,11 @@
>      private final NodeNameGenerator nodeNameGenerator = new NodeNameGenerator();
>  
>      /**
> +     * @scr.reference
> +     */
> +    private MimeTypeService mimeTypeService;
> +
> +    /**
>       * utility class for parsing date strings
>       */
>      private final DateParser dateParser = new DateParser(); {

This makes the MimeTypeService reference a static mandatory, that is the
UjaxPostServlet will only be available when the MimeTypeService is
available (which it generally is but from the use inside the
UjaxFileUploadHandler is not required).

I think, we can safely define this reference optional as in:

   @scr.reference cardinality="0..1" policy="dynamic"

WDYT ?

Regards
Felix