You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/11/04 13:57:44 UTC
[jira] Created: (LUCENE-2739) Refactor TestIndexWriter
Refactor TestIndexWriter
------------------------
Key: LUCENE-2739
URL: https://issues.apache.org/jira/browse/LUCENE-2739
Project: Lucene - Java
Issue Type: Test
Components: Build
Reporter: Robert Muir
Priority: Minor
Fix For: 3.1, 4.0
Attachments: LUCENE-2739.patch
TestIndexWriter is getting a bit unwieldy:
* 5,315 lines of code
* 116 test methods
* runtimes frequently between 1 and 2 minutes.
It starts to be pretty scary to merge changes because its so massive.
A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
But here is a start:
# Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
# Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2739) Refactor TestIndexWriter
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2739.
---------------------------------
Resolution: Fixed
Committed revision 1031496, 1031500.
> Refactor TestIndexWriter
> ------------------------
>
> Key: LUCENE-2739
> URL: https://issues.apache.org/jira/browse/LUCENE-2739
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2739.patch, LUCENE-2739.patch, LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2739) Refactor TestIndexWriter
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2739:
--------------------------------
Attachment: LUCENE-2739.patch
here's a second patch: moves the exceptions tests into TestIndexWriterExceptions,
and the addIndexes tests into TestAddIndexes
> Refactor TestIndexWriter
> ------------------------
>
> Key: LUCENE-2739
> URL: https://issues.apache.org/jira/browse/LUCENE-2739
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2739.patch, LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2739) Refactor TestIndexWriter
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2739:
--------------------------------
Attachment: LUCENE-2739.patch
> Refactor TestIndexWriter
> ------------------------
>
> Key: LUCENE-2739
> URL: https://issues.apache.org/jira/browse/LUCENE-2739
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2739) Refactor TestIndexWriter
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2739:
--------------------------------
Attachment: LUCENE-2739.patch
here's a final patch to move termvectors-writing tests to TestTermVectorsWriter.
(sure some were really bugs in IW, but some were in TVWriter too, and i think it makes logical sense)
i'd like to resolve the issue with this one, TestIW is about half its former self.
> Refactor TestIndexWriter
> ------------------------
>
> Key: LUCENE-2739
> URL: https://issues.apache.org/jira/browse/LUCENE-2739
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2739.patch, LUCENE-2739.patch, LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2739) Refactor TestIndexWriter
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928234#action_12928234 ]
Michael McCandless commented on LUCENE-2739:
--------------------------------------------
Yay! This is badly needed!
> Refactor TestIndexWriter
> ------------------------
>
> Key: LUCENE-2739
> URL: https://issues.apache.org/jira/browse/LUCENE-2739
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2739) Refactor TestIndexWriter
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928274#action_12928274 ]
Robert Muir commented on LUCENE-2739:
-------------------------------------
Ok, i'll commit + merge, then take a look if there's any other obvious steps we can make here.
but this one is simple and speeds up the tests a lot :)
> Refactor TestIndexWriter
> ------------------------
>
> Key: LUCENE-2739
> URL: https://issues.apache.org/jira/browse/LUCENE-2739
> Project: Lucene - Java
> Issue Type: Test
> Components: Build
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2739.patch
>
>
> TestIndexWriter is getting a bit unwieldy:
> * 5,315 lines of code
> * 116 test methods
> * runtimes frequently between 1 and 2 minutes.
> It starts to be pretty scary to merge changes because its so massive.
> A lot of the tests arguably belong somewhere else (e.g. the addIndex* tests belong in TestAddIndexes)
> But here is a start:
> # Pulls out the *OnDiskFull tests into TestIndexWriterOnDiskFull
> # Pulls out the multithreaded tests into TestIndexWriterWithThreads
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org