[jira] [Created] (MESOS-920) Set GLOG_drop_log_memory=false in environment prior to logging initialization.

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

Benjamin Mahler created MESOS-920:
-------------------------------------

             Summary: Set GLOG_drop_log_memory=false in environment prior to logging initialization.
                 Key: MESOS-920
                 URL: https://issues.apache.org/jira/browse/MESOS-920
             Project: Mesos
          Issue Type: Improvement
    Affects Versions: 0.16.0, 0.15.0
            Reporter: Benjamin Mahler


We've observed performance scaling issues attributed to the posix_fadvise calls made by glog. This can currently only disabled via the environment:

GLOG_DEFINE_bool(drop_log_memory, true, "Drop in-memory buffers of log contents. "
                 "Logs can grow very quickly and they are rarely read before they "
                 "need to be evicted from memory. Instead, drop them from memory "
                 "as soon as they are flushed to disk.");


    if (FLAGS_drop_log_memory) {
      if (file_length_ >= logging::kPageSize) {
        // don't evict the most recent page
        uint32 len = file_length_ & ~(logging::kPageSize - 1);
        posix_fadvise(fileno(file_), 0, len, POSIX_FADV_DONTNEED);
      }
    }

We should set GLOG_drop_log_memory=false prior to making our call to google::InitGoogleLogging.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)