You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Robert Scholte (Jira)" <ji...@apache.org> on 2021/04/18 19:02:00 UTC

[jira] [Closed] (JXR-158) StringEntry shouldn't be Comparable

     [ https://issues.apache.org/jira/browse/JXR-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed JXR-158.
------------------------------
    Fix Version/s: 3.1.1
         Assignee: Robert Scholte
       Resolution: Fixed

I had a look and it doesn't make sense that StringEntry was Comparable, nor was that functionality used.
Hence I removed the interface, confirmed it had no impact.

> StringEntry shouldn't be Comparable
> -----------------------------------
>
>                 Key: JXR-158
>                 URL: https://issues.apache.org/jira/browse/JXR-158
>             Project: Maven JXR
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Assignee: Robert Scholte
>            Priority: Minor
>             Fix For: 3.1.1
>
>
> Edit: original title was: StringEntry should implement equals and hashcode
> Because it implements Comparable.  Per Oracle,
> bq. It is strongly recommended, but _not_ strictly required that {{(x.compareTo(y)==0) == (x.equals(y))}}. Generally speaking, any class that implements the {{Comparable}} interface and violates this condition should clearly indicate this fact. The recommended language is "Note: this class has a natural ordering that is inconsistent with equals."



--
This message was sent by Atlassian Jira
(v8.3.4#803005)