You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Lee-W (via GitHub)" <gi...@apache.org> on 2026/07/10 14:15:12 UTC
[PR] Update retired model ids and fill doc gaps in common.ai provider docs [airflow]
Lee-W opened a new pull request, #69711:
URL: https://github.com/apache/airflow/pull/69711
Examples referenced claude-3-7-sonnet (retired) and a deprecated Sonnet 4 id, which now fail outright. Also documents the HITL and approval parameters missing from the operator guides, adds MCPHook to the hook-selection table, and fixes Dag spelling in prose.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update retired model ids and fill doc gaps in common.ai provider docs [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #69711:
URL: https://github.com/apache/airflow/pull/69711#discussion_r3576921325
##########
providers/common/ai/docs/connections/pydantic_ai.rst:
##########
@@ -38,9 +38,12 @@ Model
dedicated input in the connection form (via ``conn-fields``) and stores its
value in ``extra["model"]``.
- Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-4-20250514``,
+ Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-5``,
Review Comment:
Should we also update gpt model?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update retired model ids and fill doc gaps in common.ai provider docs [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W merged PR #69711:
URL: https://github.com/apache/airflow/pull/69711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update retired model ids and fill doc gaps in common.ai provider docs [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #69711:
URL: https://github.com/apache/airflow/pull/69711#discussion_r3576971754
##########
providers/common/ai/docs/connections/pydantic_ai.rst:
##########
@@ -38,9 +38,12 @@ Model
dedicated input in the connection form (via ``conn-fields``) and stores its
value in ``extra["model"]``.
- Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-4-20250514``,
+ Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-5``,
Review Comment:
Yep, sounds like a good idea. Just found their definition in https://github.com/openai/openai-python/blob/main/src/openai/types/shared/chat_model.py#L7. not sure whehter we have a better reference somehwere. but i'll add it there for now
##########
providers/common/ai/docs/connections/pydantic_ai.rst:
##########
@@ -38,7 +38,7 @@ Model
dedicated input in the connection form (via ``conn-fields``) and stores its
value in ``extra["model"]``.
- Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-4-20250514``,
+ Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-5``,
Review Comment:
https://platform.claude.com/docs/en/about-claude/models/overview#latest-models-comparison
##########
providers/common/ai/docs/connections/pydantic_ai.rst:
##########
@@ -38,9 +38,12 @@ Model
dedicated input in the connection form (via ``conn-fields``) and stores its
value in ``extra["model"]``.
- Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-4-20250514``,
+ Examples: ``openai:gpt-5.3``, ``anthropic:claude-sonnet-5``,
Review Comment:
maybe https://developers.openai.com/api/docs/models/all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org