You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2018/01/19 00:46:04 UTC
[kudu-CR] [java] add test to reproduce KUDU-2267
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9071
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
[java] add test to reproduce KUDU-2267
Currently, if a master has never been a leader from the very start of
the cluster, it has just self-signed cert. In that case if a client
does not have any valid Kerberos credential but only authenticated
token, then the client may see negotiaition failure error and is not
able to connect that masters. This patch add a test to reproduce this
issue in TestSecurity.
Change-Id: I4879749988dc884fe81cf36838819379db91ae72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 59 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/9071/1
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 25 Jan 2018 01:01:17 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 22:56:45 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@11
PS1, Line 11: credential
> nit: in English it usually goes plural, i.e. 'credentials'
Done
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@13
PS1, Line 13: o r
> nit: adds
Done
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@13
PS1, Line 13: . This patch
> nit: drop
Done
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@14
PS1, Line 14:
> nit: drop
Done
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 19:41:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 1:
> (4 comments)
>
> What are we going to do with this test once the server-side issue
> with not having CA-signed certs for follower masters is fixed?
I added a TODO in TestSecurity so once KUDU-2267/2265 is fixed, assert that there are no exceptions when connecting to masters.
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 19:34:50 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 4:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@10
PS3, Line 10: serv
> nit: server TLS certificate
Done
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@11
PS3, Line 11: entials but o
> nit: 'authentication' or just 'authn' for brevity
Done
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@12
PS3, Line 12: y see negoti
> nit: seems to be a typo, should be 'negotiation'
Done
http://gerrit.cloudera.org:8080/#/c/9071/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9071/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@80
PS3, Line 80: credential
> nit: credentials
Done
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 25 Jan 2018 00:25:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 3:
(4 comments)
lgtm, just a couple of nits
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@10
PS3, Line 10: cert
nit: server TLS certificate
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@11
PS3, Line 11: authenticated
nit: 'authentication' or just 'authn' for brevity
http://gerrit.cloudera.org:8080/#/c/9071/3//COMMIT_MSG@12
PS3, Line 12: negotiaition
nit: seems to be a typo, should be 'negotiation'
http://gerrit.cloudera.org:8080/#/c/9071/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9071/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@80
PS3, Line 80: credential
nit: credentials
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 25 Jan 2018 00:14:29 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 1:
> > (4 comments)
> >
> > What are we going to do with this test once the server-side issue
> > with not having CA-signed certs for follower masters is fixed?
> I added a TODO in TestSecurity so once KUDU-2267/2265 is fixed,
> assert that there are no exceptions when connecting to masters.
Oh, indeed -- that makes sense. It seems I overlooked that comment, sorry.
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 23 Jan 2018 19:39:53 +0000
Gerrit-HasComments: No
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9071
to look at the new patch set (#3).
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
[java] add test to reproduce KUDU-2267
Currently, if a master has never been a leader from the very start of
the cluster, it has just self-signed cert. In that case if a client
does not have any valid Kerberos credentials but only authenticated
token, then the client may see negotiaition failure error and is not
able to connect. This patch adds a regression test for this issue.
Change-Id: I4879749988dc884fe81cf36838819379db91ae72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 59 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/9071/3
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
[java] add test to reproduce KUDU-2267
Currently, if a master has never been a leader from the very start of
the cluster, it has just self-signed server TLS certificate. In that
case if a client does not have any valid Kerberos credentials but only
authn token, then the client may see negotiation failure error and is
not able to connect. This patch adds a regression test for this issue.
Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Reviewed-on: http://gerrit.cloudera.org:8080/9071
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 59 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9071
to look at the new patch set (#4).
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
[java] add test to reproduce KUDU-2267
Currently, if a master has never been a leader from the very start of
the cluster, it has just self-signed server TLS certificate. In that
case if a client does not have any valid Kerberos credentials but only
authn token, then the client may see negotiation failure error and is
not able to connect. This patch adds a regression test for this issue.
Change-Id: I4879749988dc884fe81cf36838819379db91ae72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 59 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/9071/4
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9071/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9071/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@94
PS5, Line 94: assertEventuallyTrue("Not able to connect to all the masters",
: new BooleanExpression() {
: @Override
: public boolean get() throws Exception {
: ConnectToCluster connector = new ConnectToCluster(masterHostPorts);
: connector.connectToMasters(newClient.asyncClient.getMasterTable(), null,
: DEFAULT_SLEEP, Connection.CredentialsPolicy.ANY_CREDENTIALS);
: connector.getDeferred().join();
: List<Exception> s = connector.getExceptionsReceived();
: return s.size() == 0;
: }
: }, DEFAULT_SLEEP);
After discovering KUDU-2319, I guess that at some point the client might connected to the leader master really fast, while the outstanding requests to other masters could be cancelled; so no exceptions would be produced. So, I think this way of verifying that the client can connect to non-leader masters is not reliable. Also, it might happen that there were some re-elections among the masters, so eventually every master has played the leader role (but this might happen just for a small fraction of all runs, though).
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Feb 2018 19:04:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9071/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/9071/5/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@94
PS5, Line 94: assertEventuallyTrue("Not able to connect to all the masters",
: new BooleanExpression() {
: @Override
: public boolean get() throws Exception {
: ConnectToCluster connector = new ConnectToCluster(masterHostPorts);
: connector.connectToMasters(newClient.asyncClient.getMasterTable(), null,
: DEFAULT_SLEEP, Connection.CredentialsPolicy.ANY_CREDENTIALS);
: connector.getDeferred().join();
: List<Exception> s = connector.getExceptionsReceived();
: return s.size() == 0;
: }
: }, DEFAULT_SLEEP);
> After discovering KUDU-2319, I guess that at some point the client might co
Ok, after looking more carefully, I found the issue is we should wait for the deferred for all responses. Will put a patch to fix it.
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 00:20:18 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9071
to look at the new patch set (#2).
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
[java] add test to reproduce KUDU-2267
Currently, if a master has never been a leader from the very start of
the cluster, it has just self-signed cert. In that case if a client
does not have any valid Kerberos credentials but only authenticated
token, then the client may see negotiaition failure error and is not
able to connect. This patch adds a test to reproduce this issue.
Change-Id: I4879749988dc884fe81cf36838819379db91ae72
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
3 files changed, 59 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/9071/2
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] add test to reproduce KUDU-2267
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9071 )
Change subject: [java] add test to reproduce KUDU-2267
......................................................................
Patch Set 1:
(4 comments)
What are we going to do with this test once the server-side issue with not having CA-signed certs for follower masters is fixed?
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@11
PS1, Line 11: credential
nit: in English it usually goes plural, i.e. 'credentials'
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@13
PS1, Line 13: that masters
nit: drop
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@13
PS1, Line 13: add
nit: adds
http://gerrit.cloudera.org:8080/#/c/9071/1//COMMIT_MSG@14
PS1, Line 14: in TestSecurity
nit: drop
--
To view, visit http://gerrit.cloudera.org:8080/9071
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4879749988dc884fe81cf36838819379db91ae72
Gerrit-Change-Number: 9071
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Sat, 20 Jan 2018 02:39:00 +0000
Gerrit-HasComments: Yes