You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/07/16 17:37:31 UTC

[GitHub] [camel-k] phantomjinx commented on a change in pull request #2510: chore(release): bump version to 1.6.0-SNAPSHOT and remove deprecated …

phantomjinx commented on a change in pull request #2510:
URL: https://github.com/apache/camel-k/pull/2510#discussion_r671421689



##########
File path: script/Makefile
##########
@@ -14,7 +14,7 @@
 # limitations under the License.
 
 VERSIONFILE := pkg/util/defaults/defaults.go
-VERSION ?= 1.6.0-SNAPSHOT
+VERSION := 1.6.0-SNAPSHOT

Review comment:
       Can this not be changed since this is relied upon for using the kustomize installation method I've been working on at https://github.com/apache/camel-k/pull/2284.

##########
File path: script/Makefile
##########
@@ -23,7 +23,7 @@ KANIKO_VERSION := 0.17.1
 INSTALL_DEFAULT_KAMELETS := true
 BASE_IMAGE := adoptopenjdk/openjdk11:slim
 LOCAL_REPOSITORY := /tmp/artifacts/m2
-IMAGE_NAME ?= docker.io/apache/camel-k
+IMAGE_NAME := docker.io/apache/camel-k

Review comment:
       Same here. See above.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org