You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "w41ter (via GitHub)" <gi...@apache.org> on 2026/03/31 10:55:33 UTC
[PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
w41ter opened a new pull request, #61949:
URL: https://github.com/apache/doris/pull/61949
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4162501071
# BE UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/fa0670a75d086971ee55f774091a4c40c56d9a14_fa0670a75d086971ee55f774091a4c40c56d9a14/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/fa0670a75d086971ee55f774091a4c40c56d9a14_fa0670a75d086971ee55f774091a4c40c56d9a14/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.93% (19991/37768) |
| Line Coverage | 36.47% (187597/514436) |
| Region Coverage | 32.71% (145373/444493) |
| Branch Coverage | 33.89% (63797/188221) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "w41ter (via GitHub)" <gi...@apache.org>.
w41ter commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4161750174
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4168203660
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61949_fa0670a75d086971ee55f774091a4c40c56d9a14_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61949_fa0670a75d086971ee55f774091a4c40c56d9a14_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.54% (27199/36986) |
| Line Coverage | 57.06% (292662/512891) |
| Region Coverage | 54.24% (243342/448610) |
| Branch Coverage | 55.98% (105677/188787) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4162039539
<details>
<summary>TPC-DS: <b>Total hot run time: 168694 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fa0670a75d086971ee55f774091a4c40c56d9a14, data reload: false
query5 4342 659 522 522
query6 344 241 219 219
query7 4221 462 268 268
query8 349 243 245 243
query9 8754 2745 2711 2711
query10 499 396 345 345
query11 6947 5109 4840 4840
query12 185 128 123 123
query13 1291 468 353 353
query14 5778 3679 3434 3434
query14_1 2842 2795 2792 2792
query15 203 193 179 179
query16 1018 468 430 430
query17 1122 740 628 628
query18 2449 470 351 351
query19 221 220 199 199
query20 141 129 130 129
query21 210 140 112 112
query22 13356 13989 14476 13989
query23 16622 16639 16115 16115
query23_1 16163 16023 15722 15722
query24 7160 1580 1235 1235
query24_1 1246 1235 1222 1222
query25 602 459 406 406
query26 1239 258 155 155
query27 2773 479 293 293
query28 4485 1838 1843 1838
query29 820 564 460 460
query30 300 228 188 188
query31 1008 939 869 869
query32 77 74 68 68
query33 504 333 279 279
query34 876 863 524 524
query35 636 698 598 598
query36 1063 1147 931 931
query37 126 93 77 77
query38 2933 2891 2882 2882
query39 856 832 814 814
query39_1 795 797 794 794
query40 230 147 135 135
query41 64 60 58 58
query42 261 255 255 255
query43 245 240 220 220
query44
query45 194 189 183 183
query46 886 997 609 609
query47 2110 2562 2097 2097
query48 304 361 241 241
query49 658 470 389 389
query50 704 277 211 211
query51 4145 4171 4013 4013
query52 273 272 256 256
query53 295 346 295 295
query54 303 270 266 266
query55 102 87 93 87
query56 327 322 318 318
query57 1945 1827 1604 1604
query58 284 287 272 272
query59 2837 2997 2799 2799
query60 340 339 328 328
query61 161 156 155 155
query62 639 581 508 508
query63 314 280 270 270
query64 5066 1319 1010 1010
query65
query66 1469 467 394 394
query67 24257 24304 24134 24134
query68
query69 407 326 277 277
query70 997 924 974 924
query71 331 311 291 291
query72 2803 2712 2489 2489
query73 547 539 319 319
query74 9674 9593 9390 9390
query75 2825 2752 2454 2454
query76 2287 1036 672 672
query77 363 403 309 309
query78 10929 11062 10483 10483
query79 3048 770 569 569
query80 1783 618 540 540
query81 562 259 225 225
query82 992 153 118 118
query83 325 261 244 244
query84 255 121 97 97
query85 914 490 444 444
query86 421 301 288 288
query87 3214 3107 2995 2995
query88 3519 2641 2627 2627
query89 416 370 350 350
query90 2062 175 174 174
query91 172 161 135 135
query92 77 74 72 72
query93 1295 871 509 509
query94 646 322 280 280
query95 580 335 372 335
query96 641 509 225 225
query97 2455 2517 2421 2421
query98 249 220 218 218
query99 1012 1009 951 951
Total cold run time: 252238 ms
Total hot run time: 168694 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4168370983
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61949_fa0670a75d086971ee55f774091a4c40c56d9a14_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61949_fa0670a75d086971ee55f774091a4c40c56d9a14_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.58% (27214/36986) |
| Line Coverage | 57.11% (292919/512891) |
| Region Coverage | 54.31% (243650/448610) |
| Branch Coverage | 56.05% (105814/188787) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4169343023
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4162612981
# BE Regression && UT Coverage Report
Increment line coverage `100% (0/0)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/61949_fa0670a75d086971ee55f774091a4c40c56d9a14_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/61949_fa0670a75d086971ee55f774091a4c40c56d9a14_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.54% (27199/36986) |
| Line Coverage | 57.06% (292662/512891) |
| Region Coverage | 54.24% (243342/448610) |
| Branch Coverage | 55.98% (105677/188787) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4161749741
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4161977531
<details>
<summary>TPC-H: <b>Total hot run time: 26507 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fa0670a75d086971ee55f774091a4c40c56d9a14, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17635 4486 4291 4291
q2 q3 10640 771 516 516
q4 4673 354 252 252
q5 7573 1196 1017 1017
q6 189 178 144 144
q7 773 863 671 671
q8 9291 1460 1352 1352
q9 4875 4761 4718 4718
q10 6311 1922 1622 1622
q11 475 258 232 232
q12 747 586 459 459
q13 18035 2699 1938 1938
q14 228 231 214 214
q15 q16 740 746 662 662
q17 740 850 460 460
q18 6058 5451 5292 5292
q19 1152 978 618 618
q20 545 489 394 394
q21 4532 1819 1364 1364
q22 350 291 430 291
Total cold run time: 95562 ms
Total hot run time: 26507 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4740 4660 4579 4579
q2 q3 3881 4396 3871 3871
q4 878 1248 876 876
q5 4049 4427 4335 4335
q6 190 177 140 140
q7 1750 1614 1515 1515
q8 2441 2706 2595 2595
q9 7685 7330 7358 7330
q10 3821 4051 3571 3571
q11 500 439 425 425
q12 492 602 462 462
q13 2480 3006 2077 2077
q14 292 306 289 289
q15 q16 715 750 739 739
q17 1182 1349 1368 1349
q18 7126 6728 6618 6618
q19 879 844 884 844
q20 2101 2180 1985 1985
q21 3938 3541 3280 3280
q22 470 433 370 370
Total cold run time: 49610 ms
Total hot run time: 47250 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #61949:
URL: https://github.com/apache/doris/pull/61949#issuecomment-4168638061
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](snapshot) skip link binlog files if binlog is not enabled [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #61949:
URL: https://github.com/apache/doris/pull/61949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org