You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by guoyuepeng <gi...@git.apache.org> on 2018/12/17 09:10:59 UTC
[GitHub] griffin pull request #472: Mysql as storage profile
GitHub user guoyuepeng opened a pull request:
https://github.com/apache/griffin/pull/472
Mysql as storage profile
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/guoyuepeng/griffin mysql_as_storage_profile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/griffin/pull/472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #472
----
commit 5182e9a5920ab900008de8f1a34a88e9b3b8457e
Author: William Guo <gu...@...>
Date: 2018-12-10T23:57:56Z
fix docs
commit 81487af359a2710e672370f622fea51e833d6bf7
Author: William Guo <gu...@...>
Date: 2018-12-13T23:48:54Z
Merge branch 'master' of https://github.com/apache/griffin
commit f8f5162c19a388a80e9de9af649419716849ca80
Author: William Guo <gu...@...>
Date: 2018-12-17T08:57:31Z
use mysql in profile, build with -Dmysql
commit ada58b1f06b0085e937a1b84da5b306106457911
Author: William Guo <gu...@...>
Date: 2018-12-17T09:02:03Z
remove duplicated declaration
commit 57d5e2265e32d1e95f67f46d90221cc3272e118a
Author: William Guo <gu...@...>
Date: 2018-12-17T09:09:51Z
dev profile with h2 database
----
---
[GitHub] griffin issue #472: Mysql as storage profile
Posted by guoyuepeng <gi...@git.apache.org>.
Github user guoyuepeng commented on the issue:
https://github.com/apache/griffin/pull/472
thanks, fixed
---
[GitHub] griffin pull request #472: Mysql as storage profile
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/griffin/pull/472
---
[GitHub] griffin issue #472: Mysql as storage profile
Posted by toyboxman <gi...@git.apache.org>.
Github user toyboxman commented on the issue:
https://github.com/apache/griffin/pull/472
please double-check build conflict in this pr
thx
---
[GitHub] griffin issue #472: Mysql as storage profile
Posted by toyboxman <gi...@git.apache.org>.
Github user toyboxman commented on the issue:
https://github.com/apache/griffin/pull/472
LGTM, please go ahead
---
[GitHub] griffin pull request #472: Mysql as storage profile
Posted by jzonthemtn <gi...@git.apache.org>.
Github user jzonthemtn commented on a diff in the pull request:
https://github.com/apache/griffin/pull/472#discussion_r242672001
--- Diff: service/pom.xml ---
@@ -103,20 +105,23 @@ under the License.
<artifactId>org.eclipse.persistence.jpa</artifactId>
<version>${eclipselink.version}</version>
</dependency>
-
- <dependency>
- <groupId>org.springframework.retry</groupId>
- <artifactId>spring-retry</artifactId>
- </dependency>
-
- <!--prod db-->
- <!--<dependency>-->
- <!--<groupId>mysql</groupId>-->
- <!--<artifactId>mysql-connector-java</artifactId>-->
- <!--</dependency>-->
<dependency>
<groupId>org.postgresql</groupId>
<artifactId>postgresql</artifactId>
+ <version>${postgresql.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>mysql</groupId>
--- End diff --
The MySQL connector is licensed under the GPL.
---