You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kevingurney (via GitHub)" <gi...@apache.org> on 2023/11/09 20:01:12 UTC
[PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
kevingurney opened a new pull request, #38660:
URL: https://github.com/apache/arrow/pull/38660
### PLEASE DO NOT MERGE
We are actively testing the `crossbow` packaging and release scripts for the MATLAB interface using this PR. We will update the PR when ready for review.
### Rationale for this change
To enable releases of the MATLAB interface, we should add `crossbow` packaging workflows and post release scripts for the MATLAB interface code.
See mailing list discussion for more info: https://lists.apache.org/thread/0xyow40h7b1bptsppb0rxd4g9r1xpmh6
### What changes are included in this PR?
TBD
### Are these changes tested?
TBD
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027649178
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397886639
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Yes. We must add `LICENSE.txt` and `NOTICE.txt` into the MLTBX file.
See also:
* The ASF release policy:
* Artifacts https://www.apache.org/legal/release-policy.html#artifacts (The MLTBX file is a compiled package in this document)
* Licencing https://www.apache.org/legal/release-policy.html#licensing
* Licensing Documentation https://www.apache.org/legal/release-policy.html#licensing-documentation
* Assembling LICENSE and NOTICE files https://infra.apache.org/licensing-howto.html
* The MLTBX file is a binary distribution in this document: https://infra.apache.org/licensing-howto.html#binary
* I think that the MLTBX file includes (bundles) at least https://github.com/mathworks/libmexclass . We need add license information for it. https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804694840
Revision: 2cff4db0d37cb344383c049cac1a12c8a6f7d634
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f0fa84c1be](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f0fa84c1be)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817497917/job/18541124088)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806173468
> macros.github_upload_releases this uploads the artifacts to the crossbow repo [release area](https://github.com/ursacomputing/crossbow/releases), not the jfrog artifactory. From there we can use archery to download them and upload them to the artifactory.
Ah, sorry for the confusion! That makes more sense. We didn't realize the artifacts were getting released via GitHub Releases in ursacomputing/crossbow first.
> IIRC every committer can upload things to the artifactory, either via the webgui or via curl (? check the other release scripts). We would only upload things there for releases/rcs (for testing now would also be fine). If you want to provide a 'nightly' version of the mtlbx files you can checkout the way we upload nightlies for r and java to https://nightlies.apache.org/ in .github/workflows/r|java_nightly.yml
It's good to hear that committers can upload to artifactory.
We are certainly interested in "nightly" builds in the long term, so thank you for pointing us in the direction of the R and Java nightly workflows for reference! This is really useful.
> FYI: If we want to provide nightly packages, we should follow the following ASF requirement: https://www.apache.org/legal/release-policy.html#publication
Thanks for pointing this out @kou. We will make sure we account for these ASF policies whenever we work on the "nightly" builds and not distribute the nightly builds.
Our interpretation of this is that we should *not* distribute "nightly" builds of the MATLAB interface through mathworks/arrow or other non-ASF operated infrastructure. Rather, we should distribute them via https://nightlies.apache.org. Is our understanding correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806262946
Revision: 2c7f85bb7e08987c59f41993e090be098737475b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-24bee36623](https://github.com/ursacomputing/crossbow/branches/all?query=actions-24bee36623)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6828547842/job/18572905360)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1456048561
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
I agree! I'll start a discussion on the mailing list. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1997683762
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525651207
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
Ah, we should recheck existing entries such as the zlib's one in `LICENSE.txt`...
> Also, we noted the following instructions in https://infra.apache.org/licensing-howto.html#permissive-deps:
It seems that this description is for "bundled" dependency not "non-bundled" dependency.
https://infra.apache.org/licensing-howto.html#step-by-step
> For any [bundled](https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled) dependency, consider whether LICENSE and/or NOTICE need to be modified. Do not modify LICENSE or NOTICE for non-bundled dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813199451
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "royfielding (via GitHub)" <gi...@apache.org>.
royfielding commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2025873909
I know you are trying really hard to make sure this is done right, and I truly appreciate that, but we can rely on the terms of our license. There is no need to ask legal discuss to approve our own license. The mailing list can only supply our own opinions, whereas you already obtained the only opinion that matters here (that of the copyright owner). They gave permission to contribute and distribute via the Apache License 2.0, and the Apache License 2.0 has the terms under which other recipients may redistribute what they receive in any package we distribute. No other case matters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027722903
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2030024240
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit ce11e561d37db3cdbc8c55e000ca46256f504dc1.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23307196695) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1997991776
Revision: 4aae606db1e035de44d986999a701cc2948796b5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-be78361249](https://github.com/ursacomputing/crossbow/branches/all?query=actions-be78361249)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8285165845/job/22672290582)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1997690061
Revision: 4aae606db1e035de44d986999a701cc2948796b5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-70e8d8f5a9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-70e8d8f5a9)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8283111072/job/22665526556)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804767029
Thank you so much for offering to help @assignUser! We will definitely reach out to you when needed. We think we are getting pretty close to something that mostly works... but we might run into unexpected issues.
Here is a brief summary of the current state:
1. We have a MATLAB script (`packageMatlabInterface.m`) that automatically packages an MLTBX file from a MATLAB source directory. This can be called from a GitHub Actions workflow.
2. We've added a `crossbow` task named `matlab` (name TBD) which builds the MATLAB interface code on Windows, macOS, and Linux, compresses all the build artifacts, uploads to the GitHub Artifacts area, downloads them, and then packages them into an MLTBX file using `packageMatlabInterface.m`.
3. The last step should involve this MTLBX file being uploaded to JFrog Artifactory using `macros.github_upload_releases`.
4. We've also started working on a post-release script `16-post-matlab.sh`, but haven't been able to fully test it yet because we haven't been able to successfully upload artifacts to JFrog Artifactory yet (our working assumption has been that we won't have the permissions to upload to Artifactory - but, we wanted to try to at least get to the point where that would be happening in the CI workflow first before asking others for help).
Hopefully this makes some sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1814779390
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1812798332
Revision: c9a77e849807989ee5bb1a0f084999f13d4e8450
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9e6840c8c7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9e6840c8c7)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6879702464/job/18712226854)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1812794419
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804719574
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806214366
Revision: fd5743ae1287806eb4aa2082c8a71432ddf76ece
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d5dd8cd01a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d5dd8cd01a)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6828369891/job/18572365101)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806492533
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1809095250
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1454804607
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Thanks for sharing this!
Let's discuss this on `dev@arrow.apache.org` to get more attention. We should think about license carefully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397886639
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Yes. We must add `LICENSE.txt` and `NOTICE.txt` into the MLTBX file.
See also:
* The ASF release policy:
* Artifacts https://www.apache.org/legal/release-policy.html#artifacts (The MLTBX file is a compiled package in this document)
* Licencing https://www.apache.org/legal/release-policy.html#licensing
* Licensing Documentation https://www.apache.org/legal/release-policy.html#licensing-documentation
* Assembling LICENSE and NOTICE files https://infra.apache.org/licensing-howto.html
* The MLTBX file is a binary distribution ihttps://infra.apache.org/licensing-howto.html#binary n this document
* I think that the MLTBX file includes (bundles) at least https://github.com/mathworks/libmexclass . We need add license information for it. https://infra.apache.org/licensing-howto.html#bundled-vs-non-bundled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397618956
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813277961
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804647128
Revision: 45db0635c762b4ad12d698abfe028a34fccc1fef
Submitted crossbow builds: [ursacomputing/crossbow @ actions-08f7c2e125](https://github.com/ursacomputing/crossbow/branches/all?query=actions-08f7c2e125)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817153089/job/18540026099)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1388640556
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,171 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get install ninja-build
Review Comment:
I'd recommend apt update at least once in the job to avoid stuff failing when the image hasn't been updated in a bit.
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,171 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Install ccache
+ run: sudo apt-get install ccache
+ - name: Setup ccache
+ shell: bash
+ run: arrow/ci/scripts/ccache_setup.sh
+ - name: ccache info
+ id: ccache-info
+ shell: bash
+ run: echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+ - name: Cache ccache
+ uses: actions/cache@v3
+ with:
+ path: ${{ '{{' }} steps.ccache-info.outputs.cache-dir {{ '}}' }}
+ key: matlab-ccache-ubuntu-${{ '{{' }} hashFiles('arrow/cpp/**', 'arrow/matlab/**') {{ '}}' }}
+ restore-keys: matlab-ccache-ubuntu-
Review Comment:
Due to the way actions/cache's security model is setup it doesn't work to cache the ccache in the same way we do in apche/arrow. That's why we use sccache there. We have a jinja macro that sets the right envvars etc. and a script to install it.
You can checkout the java jars job on how to set it up on all three OSes `dev/tasks/java-jars/github.yml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806477710
Revision: 0137b0b32ce9026ca089108d5d6423425d4b3f78
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ce7ab243c8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ce7ab243c8)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6829889844/job/18576885993)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804596090
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995304183
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1997736016
Revision: 4aae606db1e035de44d986999a701cc2948796b5
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8920f25e02](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8920f25e02)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8283414224/job/22666535665)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1998740761
Let me confirm to make sure what is "software from The MathWorks, Inc. (Apache 2.0)" in the binary artifact.
Here are files in the binary artifact:
https://github.com/ursacomputing/crossbow/releases?q=actions-0a0da0ec08-github-matlab&expanded=true
```text
matlab-arrow-15.0.0.dev121
matlab-arrow-15.0.0.dev121/[Content_Types].xml
matlab-arrow-15.0.0.dev121/_rels
matlab-arrow-15.0.0.dev121/_rels/.rels
matlab-arrow-15.0.0.dev121/_xmlsignatures
matlab-arrow-15.0.0.dev121/_xmlsignatures/_rels
matlab-arrow-15.0.0.dev121/_xmlsignatures/_rels/origin.sigs.rels
matlab-arrow-15.0.0.dev121/_xmlsignatures/origin.sigs
matlab-arrow-15.0.0.dev121/_xmlsignatures/sig1.xml
matlab-arrow-15.0.0.dev121/fsroot
matlab-arrow-15.0.0.dev121/fsroot/+arrow
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+display
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+display/getHeader.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list/ClassTypeValidator.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list/DatetimeValidator.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list/TableValidator.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list/Validator.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list/createValidator.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+list/findFirstNonMissingElement.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+temporal
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/+temporal/convertDatetimeToEpochTime.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/+internal/getArrayProxyIDs.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/BooleanArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/ChunkedArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Date32Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Date64Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Float32Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Float64Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Int16Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Int32Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Int64Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Int8Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/ListArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/NumericArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/StringArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/StructArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Time32Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/Time64Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/TimestampArray.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/UInt16Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/UInt32Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/UInt64Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/UInt8Array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+array/ValidationMode.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+buffer
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+buffer/Buffer.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+display
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+display/boldFontIfPossible.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+display/pluralizeStringIfNeeded.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+io
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+io/+feather
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+io/+feather/Reader.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+io/+feather/Writer.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+proxy
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+proxy/create.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+proxy/validate.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+display
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+display/makeDimensionString.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+display/makeLinkString.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+display/verify.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+io
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+io/+feather
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+io/+feather/roundtrip.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+tabular
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+tabular/createAllSupportedArrayTypes.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+test/+tabular/createTableWithSupportedTypes.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/+index
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/+index/numeric.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/+index/numericOrString.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/+index/string.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/+temporal
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/+temporal/timeUnit.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/nonsparse.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/numeric.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/parseValid.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/parseValidElements.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/realnumeric.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/shape.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+internal/+validate/type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+io
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+io/+csv
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+io/+csv/TableReader.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+io/+csv/TableWriter.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/+display
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/+display/getSchemaString.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/+display/getTabularDisplay.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/+display/getTabularHeader.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/decompose.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/isequal.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/makeValidDimensionNames.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/makeValidVariableNames.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/validateArrayLengths.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/+internal/validateColumnNames.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/RecordBatch.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/Schema.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+tabular/Table.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/BooleanTraits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Date32Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Date64Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Float32Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Float64Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Int16Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Int32Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Int64Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Int8Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/ListTraits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/StringTraits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/StructTraits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Time32Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/Time64Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/TimestampTraits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/TypeTraits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/UInt16Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/UInt32Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/UInt64Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/UInt8Traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/+traits/traits.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/BooleanType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Date32Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Date64Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/DateType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/DateUnit.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Field.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/FixedWidthType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Float32Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Float64Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/ID.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Int16Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Int32Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Int64Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Int8Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/ListType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/NumericType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/StringType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/StructType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/TemporalType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Time32Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Time64Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/TimeType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/TimeUnit.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/TimestampType.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/UInt16Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/UInt32Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/UInt64Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+type/UInt8Type.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+util
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+util/createMetadataStruct.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+util/createVariableStruct.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+util/makeValidMATLABTableVariableNames.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/+util/table2mlarrow.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/array.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/arrow.dll
matlab-arrow-15.0.0.dev121/fsroot/+arrow/boolean.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/date32.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/date64.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/field.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/float32.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/float64.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/int16.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/int32.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/int64.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/int8.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/libarrow.1500.0.0.dylib
matlab-arrow-15.0.0.dev121/fsroot/+arrow/libarrow.so.1500.0.0
matlab-arrow-15.0.0.dev121/fsroot/+arrow/list.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/recordBatch.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/schema.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/string.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/struct.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/table.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/time32.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/time64.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/timestamp.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/uint16.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/uint32.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/uint64.m
matlab-arrow-15.0.0.dev121/fsroot/+arrow/uint8.m
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/Identifier.m
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/Proxy.m
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/arrow.dll
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/arrowproxy.dll
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/arrowproxy.lib
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/gateway.lib
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/gateway.mexa64
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/gateway.mexmaci64
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/gateway.mexw64
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/libarrow.1500.0.0.dylib
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/libarrow.so.1500.0.0
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/libarrowproxy.dylib
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/libarrowproxy.so
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/libmexclass.dylib
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/libmexclass.so
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/mexclass.dll
matlab-arrow-15.0.0.dev121/fsroot/+libmexclass/+proxy/mexclass.lib
matlab-arrow-15.0.0.dev121/fsroot/LICENSE.txt
matlab-arrow-15.0.0.dev121/fsroot/NOTICE.txt
matlab-arrow-15.0.0.dev121/fsroot/featherread.m
matlab-arrow-15.0.0.dev121/fsroot/featherwrite.m
matlab-arrow-15.0.0.dev121/metadata
matlab-arrow-15.0.0.dev121/metadata/addonProperties.xml
matlab-arrow-15.0.0.dev121/metadata/configuration.xml
matlab-arrow-15.0.0.dev121/metadata/coreProperties.xml
matlab-arrow-15.0.0.dev121/metadata/filesystemManifest.xml
matlab-arrow-15.0.0.dev121/metadata/mwcoreProperties.xml
matlab-arrow-15.0.0.dev121/metadata/mwcorePropertiesExtension.xml
matlab-arrow-15.0.0.dev121/metadata/mwcorePropertiesReleaseInfo.xml
matlab-arrow-15.0.0.dev121/metadata/systemRequirements.xml
```
My assumptions:
* `fsroot/*` except `fsroot/+libmexclass/*` are Apache-2.0 by ASF (Our codes)
* `fsroot/+libmexclass/*` are 3-clause BSD by The MathWorks, Inc.
* `[Content_Types].xml`, `_rels/*`, `_xmlsignatures/*` and `metadata/*` are Apache-2.0 by The MathWorks, Inc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804687938
Revision: 4f7365f3ed3d2bfed3310536a6e5ae96b708c5e0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-94bb08d1ec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-94bb08d1ec)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817441498/job/18540952771)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806494635
Revision: 0d46d1684d8bb3b9313feafd28ab5481a8a3b7e0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-581606b59c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-581606b59c)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6830012015/job/18577232126)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804653005
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1388644477
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,171 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Install ccache
+ run: sudo apt-get install ccache
+ - name: Setup ccache
+ shell: bash
+ run: arrow/ci/scripts/ccache_setup.sh
+ - name: ccache info
+ id: ccache-info
+ shell: bash
+ run: echo "cache-dir=$(ccache --get-config cache_dir)" >> $GITHUB_OUTPUT
+ - name: Cache ccache
+ uses: actions/cache@v3
+ with:
+ path: ${{ '{{' }} steps.ccache-info.outputs.cache-dir {{ '}}' }}
+ key: matlab-ccache-ubuntu-${{ '{{' }} hashFiles('arrow/cpp/**', 'arrow/matlab/**') {{ '}}' }}
+ restore-keys: matlab-ccache-ubuntu-
Review Comment:
Thanks for explaining this! We were puzzled as to why the `ccache` step didn't seem to be working as expected, so that clarifies things!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1809060005
Revision: 2d041912c4a8c5f35ab9d0f842a20ff5bea3646d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f3f0d59c21](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f3f0d59c21)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6855456275/job/18640514144)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1811357915
Revision: 9d948b8e14720e5a82bf891da436c26834894272
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ed20167545](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ed20167545)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6869745763/job/18683177415)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1544740588
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
Created #40895 as a follow up to address this.
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
Marking this as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2007665315
Hi Kou,
> If "I" not the Apache Software Foundation creates a MLTBX file, the MLTBX file includes proprietary object code and it's "not" licensed under the Apache-2.0. Right? (I'm not sure whether this is a problem or not.)
If we are understanding your question correctly, there are two points we think are worth noting:
1. If "I" (not the Apache Software Foundation and not on behalf of the Apache Software Foundation) receieve/download the MLTBX file that the Apache Software Foundation is planning to distribute via the official ASF release channels (i.e. the MLTBX file for the MATLAB bindings), then the terms of the Apache V2 / 3-Clause BSD licenses apply (i.e. "I" can use/modify/redistribute any of the contents of the MLTBX file under the terms of the Apache V2 / 3-Clause BSD licenses).
2. If "I" (not the Apache Software Foundation and not on behalf of the Apache Software Foundation):
2.1 create a *separate* MLTBX file or
2.2 receive/download a MLTBX file that does originate from the Apache Software Foundation's official release channels and
2.3 the MLTBX file bundles MathWorks proprietary bits
2.4 then those proprietary bits would still be under a MathWorks proprietary license.
**In Summary**: Generally speaking, MathWorks proprietary bits inside of a MLTBX file are under a MathWorks proprietary license. However, MathWorks is granting the Apache Software Foundation the right to distribute the proprietary bits (e.g. the object code required by `mathworks/libmexclass`) inside of the MLTBX file for the Arrow bindings via its official release channels under the Apache V2 license.
We hope that clarifies things! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525006318
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
Thanks for clarifying how to assemble the `NOTICE.txt` and `LICENSE.txt` files, @kinow
For reference - we based our original changes off the fact that other third party libraries that are bundled and dynamically linked against in certain binary distributions are noted in the `LICENSE.txt`.
For example:
```
3rdparty dependency zlib is redistributed as a dynamically linked shared
library in certain binary distributions, like the python wheels.
...
```
Also, we noted the following instructions in https://infra.apache.org/licensing-howto.html#permissive-deps:
```
Bundling a dependency which is issued under one of the following licenses is straightforward, assuming that license applies uniformly to all files within the dependency:
BSD (without advertising clause)
MIT/X11
In LICENSE, add a [pointer](http://s.apache.org/Hqj) to the dependency's license within the distribution and a short note summarizing its licensing:
This product bundles SuperWidget 1.2.3, which is available under a
"3-clause BSD" license. For details, see deps/superwidget/.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1523730994
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
After reviewing the relevant sections from https://www.apache.org/legal/release-policy.html and https://infra.apache.org/licensing-howto.html, we updated the `LICENSE.txt` and `NOTICE.txt` files as detailed below:
1. Added a "pointer" to `mathworks/libmexclass` at the bottom of `LICENSE.txt`.
2. Added a note about the fact that the project includes software from The MathWorks, Inc. (i.e. all of the contents of the distributed MLTBX files, other than mathworks/libmexclass and libarrow) which MathWorks is granting the Apache Software Foundation the right to distribute under the standard Apache Version 2.0 license.
We believe these updates should be sufficient to address the bundling of the `mathworks/libmexclass` binaries and all other contents in the distributed MLTBX files. However, please let us know if there is anything else we should be including in the `LICENSE.txt` or `NOTICE.txt` files.
Thanks again for everyone's help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995307509
```
Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8269793784
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `task.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1396737172
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
Review Comment:
If we want to use `regex`, we should escape `.`.
BTW, can we simplify this?
```suggestion
SYMLINK_ARROW_LIB="$(find . -name 'libarrow.so.*' -type l | xargs basename)"
REGULAR_ARROW_LIB="$(echo libarrow.so.*.*)"
```
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-ubuntu.tar.gz
+ path: matlab-arrow-ubuntu.tar.gz
+
+ macos:
+ name: AMD64 macOS 11 MATLAB
+ runs-on: macos-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: brew install ninja
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].dylib" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].[0-9].[0-9].dylib" | xargs basename)"
+ install_name_tool -change @rpath/$SYMLINK_ARROW_LIB @rpath/$REGULAR_ARROW_LIB libarrowproxy.dylib
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-macos.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-macos.tar.gz
+ path: matlab-arrow-macos.tar.gz
+
+ windows:
+ name: AMD64 Windows 2022 MATLAB
+ runs-on: windows-2022
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Download Timezone Database
+ shell: bash
+ run: arrow/ci/scripts/download_tz_database.sh
Review Comment:
Do we need this?
I think that this is needless because we don't run Apache Arrow C++ test.
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Can we set `Apache Arrow` as `AuthorName` and `dev@arrow.apache.org` as `AuthorEmail`?
Can we set license information too?
It seems that `License` doesn't exist...:
https://jp.mathworks.com/help/matlab/ref/matlab.addons.toolbox.toolboxoptions.html
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-ubuntu.tar.gz
+ path: matlab-arrow-ubuntu.tar.gz
+
+ macos:
+ name: AMD64 macOS 11 MATLAB
+ runs-on: macos-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: brew install ninja
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].dylib" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].[0-9].[0-9].dylib" | xargs basename)"
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `task.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1396739666
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
Review Comment:
Could you add a comment why we need this described in the PR description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397617224
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-ubuntu.tar.gz
+ path: matlab-arrow-ubuntu.tar.gz
+
+ macos:
+ name: AMD64 macOS 11 MATLAB
+ runs-on: macos-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: brew install ninja
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].dylib" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].[0-9].[0-9].dylib" | xargs basename)"
+ install_name_tool -change @rpath/$SYMLINK_ARROW_LIB @rpath/$REGULAR_ARROW_LIB libarrowproxy.dylib
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-macos.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-macos.tar.gz
+ path: matlab-arrow-macos.tar.gz
+
+ windows:
+ name: AMD64 Windows 2022 MATLAB
+ runs-on: windows-2022
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Download Timezone Database
+ shell: bash
+ run: arrow/ci/scripts/download_tz_database.sh
Review Comment:
Ah, I think we added this for ccache, but now that we are using sccache, this shouldn't be necessary. I'll remove the step!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1812950941
Revision: 931f54eee800255dafa139db4a90757778eb030f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8f37a7e611](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8f37a7e611)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6880707143/job/18715487796)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804657904
Revision: 481bc0c8a8f077cabe414845a2ccfe2a61a676b2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6b603a1bef](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6b603a1bef)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817208079/job/18540205183)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804669548
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804691463
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525018741
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
@kinow - yes, sorry about that! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1523730994
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
After reviewing the relevant sections from https://www.apache.org/legal/release-policy.html and https://infra.apache.org/licensing-howto.html, we i[dated the `LICENSE.txt` and `NOTICE.txt` files as detailed below:
1. Added a "pointer" to `mathworks/libmexclass` at the bottom of `LICENSE.txt`.
2. Added a note about the fact that the project includes software from The MathWorks, Inc. (i.e. all of the contents of the distributed MLTBX files, other than mathworks/libmexclass and libarrow) which MathWorks is granting the Apache Software Foundation the right to distribute under the standard Apache Version 2.0 license.
We believe these updates should be sufficient to address the bundling of the `mathworks/libmexclass` binaries and all other contents in the distributed MLTBX files. However, please let us know if there is anything else we should be including in the `LICENSE.txt` or `NOTICE.txt` files.
Thanks again for everyone's help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995331189
@assignUser - we saw that you made a change to the permissions model for running crossbow jobs in January (https://github.com/apache/arrow/commit/b59082a72094f112f95914a1d8ad469db87a34c9). Since we haven't moved this pull request forward in a few months, it's understandable that things have changed.
@sgilmore10 wasn't able to run a job, which makes sense, because she is not currently a Committer.
However, I am a Committer, and I can't seem to run a crossbow job, either. Is there something additional I need to do to be able to run crossbow jobs?
Thanks for your help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1811354828
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1812947253
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1399707634
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Hi @kou,
Thanks for linking all of this information to us! We'll read through these documents and respond on the PR as soon as we can.
Best,
Sarah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1402702291
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Hi @kou,
Just wanted to provide a quick status update on this. We've been working on trying to understand what we need to include in LICENSE.txt/NOTICE.txt from a MEX perspective. We know we need to include a pointer about libmexclass, but we're still evaluating if there is more we should be including relating to MEX build artifacts.
Note, we are approaching the holiday season in the US, so there may be a bit of a delay in moving this PR forward. Apologies for any inconvenience this delay causes. Thanks for helping us move this PR forward!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1811434621
Revision: 47dd3ab7341782b471de2e20d0401b4c16eb8c26
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8d99a6dd91](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8d99a6dd91)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6870026972/job/18684078458)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813191516
Revision: d7f369d17440d4389f1176a4c5d6b6377534fc3e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5cae9f1453](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5cae9f1453)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6882376477/job/18720757598)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1412304809
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Quick Update:
We're still consulting with other MathWorkers about the re-distribution of MEX binaries in order to ensure we are doing the right thing with respect to the ASF's licensing policies. Unfortunately, this is taking longer than we expected, but we will update this PR as soon as we can. We really appreciate everyone's support in helping us figure this out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1456048561
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
I agree! I'll start a discussion on the mailing list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804601362
Revision: e7e73375502702e664b5630ce8278c76e06f3372
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e9322b54d7](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e9322b54d7)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/tree/actions-e9322b54d7-github-matlab)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804664840
Revision: 6f8246dceb50ec388425e1eaeb743b5c42d8effd
Submitted crossbow builds: [ursacomputing/crossbow @ actions-99c4ca0454](https://github.com/ursacomputing/crossbow/branches/all?query=actions-99c4ca0454)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817259673/job/18540375994)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804722177
Revision: 35598744b784da8aa014bedd83446beccb47b51e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a06dc1513b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a06dc1513b)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817710362/job/18541778644)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2018164238
Does anyone have any additional questions about the licensing of the MLTBX contents? Or, does the community feel comfortable with these changes at this point?
We wanted to make sure others are comfortable with these changes before merging the PR in.
Thanks again for helping us work through all of this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2019329123
(I'll add a comment in a few days. I haven't read your answer carefully yet. Sorry...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2007244431
Thanks for clarifying!
One more question:
> MathWorks is explicitly granting the Apache Software Foundation the right to distribute any of the MathWorks proprietary object code which is required by `mathworks/libmexclass` _and_ bundled in the distributed MLTBX files under the Apache V2 license.
If "I" not the Apache Software Foundation creates a MLTBX file, the MLTBX file includes proprietary object code and it's "not" licensed under the Apache-2.0. Right? (I'm not sure whether this is a problem or not.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027586008
Before merging this in, @sgilmore10 and I were just reviewing the code changes one last time to make sure there weren't any lingering technical issues since this pull request has had a lot of comments over time.
We noticed that `libarrow.1500.0.0.dylib` and `libarrow.so.1500.0.0` are for some reason being copied to `fsroot/+arrow` as well as `fsroot/+libmexclass/+proxy/`. They should only be copied once to `fsroot/+libmexclass/+proxy/`. This is likely a result of a bug in the `CMakeLists.txt` for the MATLAB bindings.
We are going to take a quick look at this to see if we can push a fix before merging this PR.
Our apologies for the slight delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027721732
Ok, the duplcated arrow C++ shared libraries issue is fixed now.
Here is the list all files that are included in the MLTBX file:
```shell
./fsroot/featherread.m
./fsroot/LICENSE.txt
./fsroot/+arrow/int32.m
./fsroot/+arrow/field.m
./fsroot/+arrow/schema.m
./fsroot/+arrow/+buffer/Buffer.m
./fsroot/+arrow/+util/createMetadataStruct.m
./fsroot/+arrow/+util/table2mlarrow.m
./fsroot/+arrow/+util/createVariableStruct.m
./fsroot/+arrow/+util/makeValidMATLABTableVariableNames.m
./fsroot/+arrow/int8.m
./fsroot/+arrow/string.m
./fsroot/+arrow/uint64.m
./fsroot/+arrow/uint32.m
./fsroot/+arrow/+type/Time64Type.m
./fsroot/+arrow/+type/StructType.m
./fsroot/+arrow/+type/Time32Type.m
./fsroot/+arrow/+type/BooleanType.m
./fsroot/+arrow/+type/Float64Type.m
./fsroot/+arrow/+type/UInt8Type.m
./fsroot/+arrow/+type/+traits/Int8Traits.m
./fsroot/+arrow/+type/+traits/BooleanTraits.m
./fsroot/+arrow/+type/+traits/ListTraits.m
./fsroot/+arrow/+type/+traits/Int32Traits.m
./fsroot/+arrow/+type/+traits/StringTraits.m
./fsroot/+arrow/+type/+traits/Float32Traits.m
./fsroot/+arrow/+type/+traits/UInt32Traits.m
./fsroot/+arrow/+type/+traits/Date64Traits.m
./fsroot/+arrow/+type/+traits/Float64Traits.m
./fsroot/+arrow/+type/+traits/UInt16Traits.m
./fsroot/+arrow/+type/+traits/StructTraits.m
./fsroot/+arrow/+type/+traits/Int64Traits.m
./fsroot/+arrow/+type/+traits/TypeTraits.m
./fsroot/+arrow/+type/+traits/UInt8Traits.m
./fsroot/+arrow/+type/+traits/Int16Traits.m
./fsroot/+arrow/+type/+traits/traits.m
./fsroot/+arrow/+type/+traits/TimestampTraits.m
./fsroot/+arrow/+type/+traits/Date32Traits.m
./fsroot/+arrow/+type/+traits/UInt64Traits.m
./fsroot/+arrow/+type/+traits/Time32Traits.m
./fsroot/+arrow/+type/+traits/Time64Traits.m
./fsroot/+arrow/+type/TemporalType.m
./fsroot/+arrow/+type/TimeType.m
./fsroot/+arrow/+type/NumericType.m
./fsroot/+arrow/+type/FixedWidthType.m
./fsroot/+arrow/+type/Int64Type.m
./fsroot/+arrow/+type/Date32Type.m
./fsroot/+arrow/+type/ID.m
./fsroot/+arrow/+type/Field.m
./fsroot/+arrow/+type/UInt32Type.m
./fsroot/+arrow/+type/Int16Type.m
./fsroot/+arrow/+type/Float32Type.m
./fsroot/+arrow/+type/StringType.m
./fsroot/+arrow/+type/TimeUnit.m
./fsroot/+arrow/+type/Int32Type.m
./fsroot/+arrow/+type/TimestampType.m
./fsroot/+arrow/+type/Int8Type.m
./fsroot/+arrow/+type/ListType.m
./fsroot/+arrow/+type/DateUnit.m
./fsroot/+arrow/+type/DateType.m
./fsroot/+arrow/+type/Type.m
./fsroot/+arrow/+type/Date64Type.m
./fsroot/+arrow/+type/UInt16Type.m
./fsroot/+arrow/+type/UInt64Type.m
./fsroot/+arrow/uint16.m
./fsroot/+arrow/uint8.m
./fsroot/+arrow/recordBatch.m
./fsroot/+arrow/date64.m
./fsroot/+arrow/table.m
./fsroot/+arrow/time64.m
./fsroot/+arrow/float64.m
./fsroot/+arrow/+internal/+test/+display/makeLinkString.m
./fsroot/+arrow/+internal/+test/+display/verify.m
./fsroot/+arrow/+internal/+test/+display/makeDimensionString.m
./fsroot/+arrow/+internal/+test/+io/+feather/roundtrip.m
./fsroot/+arrow/+internal/+test/+tabular/createTableWithSupportedTypes.m
./fsroot/+arrow/+internal/+test/+tabular/createAllSupportedArrayTypes.m
./fsroot/+arrow/+internal/+validate/+index/numericOrString.m
./fsroot/+arrow/+internal/+validate/+index/string.m
./fsroot/+arrow/+internal/+validate/+index/numeric.m
./fsroot/+arrow/+internal/+validate/shape.m
./fsroot/+arrow/+internal/+validate/realnumeric.m
./fsroot/+arrow/+internal/+validate/parseValid.m
./fsroot/+arrow/+internal/+validate/nonsparse.m
./fsroot/+arrow/+internal/+validate/parseValidElements.m
./fsroot/+arrow/+internal/+validate/+temporal/timeUnit.m
./fsroot/+arrow/+internal/+validate/type.m
./fsroot/+arrow/+internal/+validate/numeric.m
./fsroot/+arrow/+internal/+display/pluralizeStringIfNeeded.m
./fsroot/+arrow/+internal/+display/boldFontIfPossible.m
./fsroot/+arrow/+internal/+io/+feather/Reader.m
./fsroot/+arrow/+internal/+io/+feather/Writer.m
./fsroot/+arrow/+internal/+proxy/validate.m
./fsroot/+arrow/+internal/+proxy/create.m
./fsroot/+arrow/timestamp.m
./fsroot/+arrow/list.m
./fsroot/+arrow/boolean.m
./fsroot/+arrow/int16.m
./fsroot/+arrow/float32.m
./fsroot/+arrow/int64.m
./fsroot/+arrow/date32.m
./fsroot/+arrow/+io/+csv/TableReader.m
./fsroot/+arrow/+io/+csv/TableWriter.m
./fsroot/+arrow/time32.m
./fsroot/+arrow/struct.m
./fsroot/+arrow/+array/Int64Array.m
./fsroot/+arrow/+array/Date64Array.m
./fsroot/+arrow/+array/ValidationMode.m
./fsroot/+arrow/+array/StringArray.m
./fsroot/+arrow/+array/ChunkedArray.m
./fsroot/+arrow/+array/Date32Array.m
./fsroot/+arrow/+array/BooleanArray.m
./fsroot/+arrow/+array/Int32Array.m
./fsroot/+arrow/+array/UInt16Array.m
./fsroot/+arrow/+array/Array.m
./fsroot/+arrow/+array/UInt64Array.m
./fsroot/+arrow/+array/+internal/+list/createValidator.m
./fsroot/+arrow/+array/+internal/+list/TableValidator.m
./fsroot/+arrow/+array/+internal/+list/DatetimeValidator.m
./fsroot/+arrow/+array/+internal/+list/ClassTypeValidator.m
./fsroot/+arrow/+array/+internal/+list/findFirstNonMissingElement.m
./fsroot/+arrow/+array/+internal/+list/Validator.m
./fsroot/+arrow/+array/+internal/+display/getHeader.m
./fsroot/+arrow/+array/+internal/getArrayProxyIDs.m
./fsroot/+arrow/+array/+internal/+temporal/convertDatetimeToEpochTime.m
./fsroot/+arrow/+array/UInt8Array.m
./fsroot/+arrow/+array/UInt32Array.m
./fsroot/+arrow/+array/Int8Array.m
./fsroot/+arrow/+array/NumericArray.m
./fsroot/+arrow/+array/Time64Array.m
./fsroot/+arrow/+array/ListArray.m
./fsroot/+arrow/+array/Float32Array.m
./fsroot/+arrow/+array/Float64Array.m
./fsroot/+arrow/+array/TimestampArray.m
./fsroot/+arrow/+array/Time32Array.m
./fsroot/+arrow/+array/StructArray.m
./fsroot/+arrow/+array/Int16Array.m
./fsroot/+arrow/array.m
./fsroot/+arrow/+tabular/RecordBatch.m
./fsroot/+arrow/+tabular/+internal/decompose.m
./fsroot/+arrow/+tabular/+internal/makeValidVariableNames.m
./fsroot/+arrow/+tabular/+internal/validateColumnNames.m
./fsroot/+arrow/+tabular/+internal/isequal.m
./fsroot/+arrow/+tabular/+internal/makeValidDimensionNames.m
./fsroot/+arrow/+tabular/+internal/validateArrayLengths.m
./fsroot/+arrow/+tabular/+internal/+display/getSchemaString.m
./fsroot/+arrow/+tabular/+internal/+display/getTabularDisplay.m
./fsroot/+arrow/+tabular/+internal/+display/getTabularHeader.m
./fsroot/+arrow/+tabular/Schema.m
./fsroot/+arrow/+tabular/Table.m
./fsroot/featherwrite.m
./fsroot/NOTICE.txt
./fsroot/+libmexclass/+proxy/gateway.mexmaci64
./fsroot/+libmexclass/+proxy/arrowproxy.lib
./fsroot/+libmexclass/+proxy/gateway.lib
./fsroot/+libmexclass/+proxy/libmexclass.dylib
./fsroot/+libmexclass/+proxy/Proxy.m
./fsroot/+libmexclass/+proxy/libarrow.so.1500.0.0
./fsroot/+libmexclass/+proxy/arrow.dll
./fsroot/+libmexclass/+proxy/libarrowproxy.so
./fsroot/+libmexclass/+proxy/libarrowproxy.dylib
./fsroot/+libmexclass/+proxy/libmexclass.so
./fsroot/+libmexclass/+proxy/Identifier.m
./fsroot/+libmexclass/+proxy/arrowproxy.dll
./fsroot/+libmexclass/+proxy/mexclass.lib
./fsroot/+libmexclass/+proxy/gateway.mexa64
./fsroot/+libmexclass/+proxy/libarrow.1500.0.0.dylib
./fsroot/+libmexclass/+proxy/mexclass.dll
./fsroot/+libmexclass/+proxy/gateway.mexw64
./[Content_Types].xml
./_xmlsignatures/sig1.xml
./_xmlsignatures/origin.sigs
./_xmlsignatures/_rels/origin.sigs.rels
./metadata/configuration.xml
./metadata/systemRequirements.xml
./metadata/mwcoreProperties.xml
./metadata/filesystemManifest.xml
./metadata/mwcorePropertiesExtension.xml
./metadata/mwcorePropertiesReleaseInfo.xml
./metadata/addonProperties.xml
./metadata/coreProperties.xml
./_rels/.rels
```
Note that the arrow shared libraries are only included in `fsroot/+libmexclass/+proxy/`.
We should probably prevent the `.lib` files under `./fsroot/+libmexclass/+proxy/` from being included in the MLTBX file, as well, since those shouldn't be required as runtime dependencies. We suspect that the fact that these are being included may be due to a bug in `mathworks/libmexclass` somewhere in the implementation of the `install_imported_target` function defined here: https://github.com/mathworks/libmexclass/blob/main/libmexclass/cpp/CMakeLists.txt#L18.
We can follow up with another PR once we have identified the source of this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027719444
@royfielding - thank you again for clarifying.
Based on this discussion, I am going to go ahead and merge in these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027560556
@royfielding - thank you for taking the time to respond to this thread.
First off - I want to emphasize that we in no way intended to waste the time of ASF Legal, nor that of any other ASF community members. Our intent was only to ensure we are doing the right thing for the ASF. The Apache Arrow community and ASF Legal has been extremely patient and supportive throughout this process, and we sincerely appreciate everyone's support.
Perhaps, the follow up question about the "general case" that we asked to ASF Legal was in some way not clear enough. I would like to explicitly clarify that our intent was in no way to ask ASF Legal for clarification on the terms of the Apache V2 license itself. Nor were we in any way trying to question whether we can rely on the terms of the license.
We were specifically seeking clarification on whether the ASF was OK with the fact that the proprietary MathWorks bits that would be distributed via the ASF are not normally licensed under the Apache V2 license in the "general case". We asked this follow up question specifically because we wanted to address Kou's earlier comment to the best of our ability. We thought Kou's question was a very reasonable one, and we didn't want to merge in these changes prematurely.
That being said, we appreciate you providing assurance that we can move ahead with merging in these changes.
Thanks again for sharing your expertise.
Best,
Kevin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397609401
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Hi @kou,
I'll update the script to set `AuthorName` to `Apache Arrow` and `AuthorEmail` to `dev@arrow.apache.org`.
Regarding including the license, the following repository lists best practices for MATLAB Toolboxes: [mathworks/toolboxdesign](https://github.com/mathworks/toolboxdesign). The recommendation is to put a `License.txt` file in the root directory of the toolbox. Should we include the top-level [`LICENSE.txt`](https://github.com/apache/arrow/blob/main/LICENSE.txt) and [`NOTICE.txt`](https://github.com/apache/arrow/blob/main/NOTICE.txt) files within the MLTBX file? We looked at the Python wheel(s) files for reference, and they seem to package both files.
Best,
Sarah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397615803
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
Review Comment:
Ah, yeah this is much simpler. Will make this change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1814768676
Revision: e08319cd13aae44942466d7f917ade45b46c9827
Submitted crossbow builds: [ursacomputing/crossbow @ actions-26e36c8c3d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-26e36c8c3d)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6893403698/job/18752895806)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813187381
Revision: 609bafbc564338dfaee3b90d94d934e762ee215b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-60dcfd53ec](https://github.com/ursacomputing/crossbow/branches/all?query=actions-60dcfd53ec)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6882341656/job/18720651306)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813188866
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813280659
Revision: 64a13f6b345af6dbbdd434bf3e5a037a01c26cff
Submitted crossbow builds: [ursacomputing/crossbow @ actions-324d553a0d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-324d553a0d)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6883071623/job/18722864874)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1811360919
Revision: 98a655dbeda6d142e10381b46cfe9a2d9777ef10
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a80a35f9e8](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a80a35f9e8)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6869772223/job/18683255481)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1811432026
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1402215712
##########
.github/workflows/matlab.yml:
##########
@@ -42,7 +42,7 @@ jobs:
ubuntu:
name: AMD64 Ubuntu 20.04 MATLAB
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
Review Comment:
This is a great point. We will definitely add a comment here to explain why we are pinning back to use `ubuntu-20.04`. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995420691
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995428878
Revision: bb0ef54e47e8eb8618afa09a9ada144b1612b50e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d0b701251f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d0b701251f)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8270208836/job/22627228647)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995431955
@assignUser - thanks for the quick and helpful response! That seems to have fixed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney merged PR #38660:
URL: https://github.com/apache/arrow/pull/38660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027560698
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804579305
Revision: 54f771586f27e8c768e491c60c2546a463b8d122
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e85d018cce](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e85d018cce)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/tree/actions-e85d018cce-github-matlab)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804640056
Revision: 02253b78f98ebfb10c9863f786d8c4637e18938d
Submitted crossbow builds: [ursacomputing/crossbow @ actions-db9baeddea](https://github.com/ursacomputing/crossbow/branches/all?query=actions-db9baeddea)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817096987/job/18539863238)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804779503
We could of course also upload the nightly builds to the mathworks/arrow repo directly from the nightly job by adding a fine grained PAT with the necessary permission to the crossbow repo. But I don't know how the matlab ecosystem handles dev/nightly versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804912290
FYI: If we want to provide nightly packages, we should follow the following ASF requirement: https://www.apache.org/legal/release-policy.html#publication
> Projects SHALL publish official releases and SHALL NOT publish unreleased materials outside the development community.
>
> During the process of developing software and preparing a release, various packages are made available to the development community for testing purposes. Projects MUST direct outsiders towards official releases rather than raw source repositories, nightly builds, snapshots, release candidates, or any other similar packages. Projects SHOULD make available developer resources to support individuals actively participating in development or following the dev list and thus aware of the conditions placed on unreleased materials.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804574154
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804776447
`macros.github_upload_releases` this uploads the artifacts to the crossbow repo [release area](https://github.com/ursacomputing/crossbow/releases), not the jfrog artifactory. From there we can use `archery` to download them and upload them to the artifactory.
IIRC every committer can upload things to the artifactory, either via the webgui or via curl (? check the other release scripts). We would only upload things there for releases/rcs (for testing now would also be fine). If you want to provide a 'nightly' version of the mtlbx files you can checkout the way we upload nightlies for r and java to https://nightlies.apache.org in `.github/workflows/r|java_nightly.yml`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804772233
Revision: fa6d1b2ff6b854fd2aefbd3e808d09c3b1171116
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0d4aa5a62e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0d4aa5a62e)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6818076475/job/18542918158)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804769326
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806255924
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1816783165
Revision: a9cfe644567cdf60383c963136ec04cd2dbd6cbc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ed22ecd880](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ed22ecd880)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6906905693/job/18792959902)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1453961078
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Hi Everyone,
Thanks very much for patiently waiting on us to move this forward.
We realized that we need to ensure that the licenses of any MEX artifacts bundled with the released MLTBX file must be compatible with the ASF 3rd Party License Policy.
After several rounds of discussion with some colleagues at MathWorks (unfortunately delayed due to the holiday season in the US), we came up with a license ([attached to this comment](https://github.com/apache/arrow/files/13955180/license.txt)) that we hope will allow us to ensure that we are abiding by the ASF's 3rd Party License Policy.
The attached license is a modified version of the standard MathWorks license that applies to MEX files. The intent of these modifications is to meet the requirements for inclusion as a ["Category B"](https://www.apache.org/legal/resolved.html#category-b) license according to the ASF 3rd Party License Policy.
Our goal is to make sure we are doing the right thing here, and we understand this may need further input from ASF Legal and the rest of the community. Please let us know what we can do to help move this forward. We sincerely appreciate everyone's support as we navigate these licensing requirements.
**Link to proposed license:** [license.txt](https://github.com/apache/arrow/files/13955180/license.txt)
Best,
Sarah and Kevin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027651128
Revision: 4c4511b6333ffee9fa70cf33ed64e0fe98f1e36b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-7a8caf7ce2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-7a8caf7ce2)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8484729821/job/23248200524)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027609913
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kinow (via GitHub)" <gi...@apache.org>.
kinow commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525011293
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
I think I was tagged by accident, @kevingurney :slightly_smiling_face: ? :point_up: @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1997987854
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995297662
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1524408214
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
We don't need this because we don't bundle mathworks/libmexclass (our source archive, apache-arrow-X.Y.Z.tar.gz, doesn't include mathworks/libmexclass.).
##########
NOTICE.txt:
##########
@@ -82,3 +82,8 @@ its NOTICE file:
This product includes software developed by Hewlett-Packard:
(c) Copyright [2014-2015] Hewlett-Packard Development Company, L.P
+
+---------------------------------------------------------------------------------
+
+This product includes software from The MathWorks, Inc. (Apache 2.0)
+ * Copyright (C) 2024 The MathWorks, Inc.
Review Comment:
We need this only for `NOTICE.txt` in `.mltbx` because our source archive doesn't include software from The MathWorks, Inc. See also: https://infra.apache.org/licensing-howto.html#binary
Can we add this in `/dev/tasks/matlab/github.yml` dynamically instead of adding this to `/NOTICE.txt` statially? We use `/NOTICE.txt` for source archive too.
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,162 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ # MATLAB's programmatic packaging interface does not properly
+ # include symbolic link files in the package MLTBX - this is a
+ # bug. As a temporary workaround, change the expected name of the
+ # Arrow C++ library which libarrowproxy.so depends on. For example,
+ # change libarrow.so.1500 to libarrow.so.1500.0.0.
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -name 'libarrow.so.*' -type l | xargs basename)"
+ REGULAR_ARROW_LIB="$(echo libarrow.so.*.*)"
+ echo "SYMLINK_ARROW_LIB = ${SYMLINK_ARROW_LIB}"
+ echo "REGULAR_ARROW_LIB = ${REGULAR_ARROW_LIB}"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
Review Comment:
Could you use the latest version?
See also: https://github.com/actions/upload-artifact
```suggestion
uses: actions/upload-artifact@v4
```
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,162 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ # MATLAB's programmatic packaging interface does not properly
+ # include symbolic link files in the package MLTBX - this is a
+ # bug. As a temporary workaround, change the expected name of the
+ # Arrow C++ library which libarrowproxy.so depends on. For example,
+ # change libarrow.so.1500 to libarrow.so.1500.0.0.
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -name 'libarrow.so.*' -type l | xargs basename)"
+ REGULAR_ARROW_LIB="$(echo libarrow.so.*.*)"
+ echo "SYMLINK_ARROW_LIB = ${SYMLINK_ARROW_LIB}"
+ echo "REGULAR_ARROW_LIB = ${REGULAR_ARROW_LIB}"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-ubuntu.tar.gz
+ path: matlab-arrow-ubuntu.tar.gz
+
+ macos:
+ name: AMD64 macOS 11 MATLAB
Review Comment:
`macos-latest` is 12 now. :-)
```suggestion
name: AMD64 macOS 12 MATLAB
```
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,60 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
+opts.ToolboxName = "MATLAB Arrow Interface";
+opts.ToolboxVersion = toolboxVersion;
+opts.AuthorName = "Apache Arrow";
Review Comment:
Could you use ASF?
```suggestion
opts.AuthorName = "The Apache Software Foundation";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804619717
Revision: 698385f54ea88ddc4c1ca755af5af77fe0673577
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0a6cd1c971](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0a6cd1c971)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/tree/actions-0a6cd1c971-github-matlab)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1807235405
> > FYI: If we want to provide nightly packages, we should follow the following ASF requirement: https://www.apache.org/legal/release-policy.html#publication
>
> Our interpretation of this is that we should _not_ distribute "nightly" builds of the MATLAB interface through mathworks/arrow or other non-ASF operated infrastructure. Rather, we should distribute them via https://nightlies.apache.org. Is our understanding correct?
The important part is "Projects MUST direct outsiders towards official releases rather than raw source repositories, nightly builds, snapshots, release candidates, or any other similar packages." We must not mention the nightly builds in documents for users. We can mention it only in documents for developers. Location isn't important because they aren't "official" material. For example, we use conda-forge for PyArrow nightly packages: https://arrow.apache.org/docs/developers/python.html#installing-nightly-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804633960
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1809099614
Revision: d754fb46f036c73fe8315d28b93362331f138fa0
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a6114a2fd5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a6114a2fd5)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6855623549/job/18641068732)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1812967435
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813184665
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813202203
Revision: bb1de7b5d40cfac260db5d76fbc5539a12f5e697
Submitted crossbow builds: [ursacomputing/crossbow @ actions-63c1786773](https://github.com/ursacomputing/crossbow/branches/all?query=actions-63c1786773)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6882468173/job/18721029149)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `task.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1815218479
@assignUser, @raulcd, and @kou, would any of you be willing to take a look at this PR now? @kevingurney and I have incorporated feedback from this PR and the mailing list discussion, and we think it's ready for review. We appreciate all the help and advice!
Best,
Sarah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397618453
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
Review Comment:
Fixed.
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-ubuntu.tar.gz
+ path: matlab-arrow-ubuntu.tar.gz
+
+ macos:
+ name: AMD64 macOS 11 MATLAB
+ runs-on: macos-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: brew install ninja
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].dylib" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].[0-9].[0-9].dylib" | xargs basename)"
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397618302
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
Review Comment:
Will do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1402702291
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Hi @kou,
Just wanted to provide a quick status update on this. We've been working on trying to understand what we need to include in LICENSE.txt/NOTICE.txt from a MEX perspective. We know we need to include a pointer about libmexclass, but we're still evaluating if there is more we should be including relating to MEX build artifacts.
Note, we are approaching the holiday season in the US, so there may be a bit of a delay in moving this PR forward. Apologies for any inconvenience this delay causes. Thanks for helping us with this PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806290383
Revision: 0ef30fd99d09352d639401ca9f8053c74ee3f46b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cb24f80640](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cb24f80640)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6828685662/job/18573329618)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806288216
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1814764969
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1814783343
Revision: 5d61b571fa9300479b840bfeaf209287117d9151
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a566783657](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a566783657)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6893506432/job/18753227453)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1397619295
##########
dev/tasks/matlab/github.yml:
##########
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+{% import 'macros.jinja' as macros with context %}
+
+{{ macros.github_header() }}
+
+jobs:
+
+ ubuntu:
+ name: AMD64 Ubuntu 20.04 MATLAB
+ runs-on: ubuntu-20.04
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: sudo apt-get update && sudo apt-get install ninja-build
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy/
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9]" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.so.[0-9][0-9][0-9][0-9].[0-9].[0-9]" | xargs basename)"
+ patchelf --replace-needed $SYMLINK_ARROW_LIB $REGULAR_ARROW_LIB libarrowproxy.so
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-ubuntu.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-ubuntu.tar.gz
+ path: matlab-arrow-ubuntu.tar.gz
+
+ macos:
+ name: AMD64 macOS 11 MATLAB
+ runs-on: macos-latest
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install ninja-build
+ run: brew install ninja
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Build MATLAB Interface
+ env:
+ {{ macros.github_set_sccache_envvars()|indent(8) }}
+ run: arrow/ci/scripts/matlab_build.sh $(pwd)/arrow
+ - name: Change shared library dependency name
+ run: |
+ pushd arrow/matlab/install/arrow_matlab/+libmexclass/+proxy
+ SYMLINK_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].dylib" | xargs basename)"
+ REGULAR_ARROW_LIB="$(find . -regex "./libarrow.[0-9][0-9][0-9][0-9].[0-9].[0-9].dylib" | xargs basename)"
+ install_name_tool -change @rpath/$SYMLINK_ARROW_LIB @rpath/$REGULAR_ARROW_LIB libarrowproxy.dylib
+ popd
+ - name: Compress into single artifact
+ run: tar -cvzf matlab-arrow-macos.tar.gz arrow/matlab/install/arrow_matlab
+ - name: Upload artifacts
+ uses: actions/upload-artifact@v2
+ with:
+ name: matlab-arrow-macos.tar.gz
+ path: matlab-arrow-macos.tar.gz
+
+ windows:
+ name: AMD64 Windows 2022 MATLAB
+ runs-on: windows-2022
+ steps:
+ {{ macros.github_checkout_arrow()|indent }}
+ - name: Install MATLAB
+ uses: matlab-actions/setup-matlab@v1
+ with:
+ release: R2023a
+ - name: Download Timezone Database
+ shell: bash
+ run: arrow/ci/scripts/download_tz_database.sh
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1816779713
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813179460
Revision: d254e81b3ff3ad0163f2813338c7de5d7293cd7e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-e5dbb1ba40](https://github.com/ursacomputing/crossbow/branches/all?query=actions-e5dbb1ba40)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6882268633/job/18720436639)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804662217
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804685210
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804758604
Wow what a cool feature:
> [!WARNING]
> I didn't know about this :D
Let me know if I can help :rocket:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804672809
Revision: b100c5f73a5fd8bdbde94717df8edcdc6656b12f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-27f3584761](https://github.com/ursacomputing/crossbow/branches/all?query=actions-27f3584761)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6817318305/job/18540566673)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027722860
I've created #40903 to capture the issue with `.lib` files being included in the MLTBX file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2025606675
@kou - thanks for taking the time to provide a thoughtful response.
Based on your comment, it sounds like it might just be worth clarifying one more time with ASF Legal about whether case #2 (i.e. the "general case") poses any issues.
We will add a comment to the original Legal Ticket (https://issues.apache.org/jira/browse/LEGAL-665) to get more explicit clarification for the community on this point.
We want to make sure we are doing the right thing here, so we will wait on merging this PR until we hear back from ASF Legal on this point.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027616346
Revision: d3026b676b20b70b78ebf35660712b85f21be6e4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-65852cf029](https://github.com/ursacomputing/crossbow/branches/all?query=actions-65852cf029)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8484511203/job/23247613928)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1998063056
Revision: 43d82780e5ad51edf78e70f909efda59c3b6c05f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0a0da0ec08](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0a0da0ec08)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/8285700852/job/22674013752)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525006318
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
Thanks for clarifying how to assemble the `NOTICE.txt` and `LICENSE.txt` files, @kou.
For reference - we based our original changes off the fact that other third party libraries that are bundled and dynamically linked against in certain binary distributions are noted in the `LICENSE.txt`.
For example:
```
3rdparty dependency zlib is redistributed as a dynamically linked shared
library in certain binary distributions, like the python wheels.
...
```
Also, we noted the following instructions in https://infra.apache.org/licensing-howto.html#permissive-deps:
```
Bundling a dependency which is issued under one of the following licenses is straightforward, assuming that license applies uniformly to all files within the dependency:
BSD (without advertising clause)
MIT/X11
In LICENSE, add a [pointer](http://s.apache.org/Hqj) to the dependency's license within the distribution and a short note summarizing its licensing:
This product bundles SuperWidget 1.2.3, which is available under a
"3-clause BSD" license. For details, see deps/superwidget/.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525017128
##########
NOTICE.txt:
##########
@@ -82,3 +82,8 @@ its NOTICE file:
This product includes software developed by Hewlett-Packard:
(c) Copyright [2014-2015] Hewlett-Packard Development Company, L.P
+
+---------------------------------------------------------------------------------
+
+This product includes software from The MathWorks, Inc. (Apache 2.0)
+ * Copyright (C) 2024 The MathWorks, Inc.
Review Comment:
Updated the `packageMATLABInterface.m` to dynamically append the required text to packaged copies of `NOTICE.txt` and `LICENSE.txt`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1997730536
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1521900400
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Just an fyi, we now have a path forward. We've determined that we can license MEX binaries and all contents included within the MLTBX file under the Apache V2 license. Here's a [link](https://lists.apache.org/thread/bz8bspro0ddts9bconsh9t0nw54p06ns) to the mailing list discussion.
Now that we are unblocked, Kevin and I will start working on this pull request again. It took some time for us to work through the details with our colleagues at MathWorks and we appreciate everyone's patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "royfielding (via GitHub)" <gi...@apache.org>.
royfielding commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2027689624
> We were specifically seeking clarification on whether the ASF was OK with the fact that the proprietary MathWorks bits that would be distributed via the ASF are not normally licensed under the Apache V2 license in the "general case". We asked this follow up question specifically because we wanted to address Kou's earlier comment to the best of our ability. We thought Kou's question was a very reasonable one, and we didn't want to merge in these changes prematurely.
I know, but copyright law is not about bits. It is about copyrightable expressions and their control. A license doesn't change the bits -- it gives permission from the controller, to us and our downstream recipients, to do things that they have the right to control. The same bits can be covered by a hundred different licenses and it doesn't matter. We only need one permission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995411073
You likely have to set your membership in the ASF org to public (default is private and it's hard to spot that that is the case) see https://docs.github.com/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/publicizing-or-hiding-organization-membership
Sorry for the inconvenience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1995299913
```
Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in.
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/8269771707
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1525006318
##########
LICENSE.txt:
##########
@@ -2252,3 +2252,13 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+
+--------------------------------------------------------------------------------
+
+3rdparty dependency mathworks/libmexclass is redistributed as a dynamically
+linked shared library in certain binary distributions, like the MATLAB
+distribution.
+
+Copyright: 2022-2024 The MathWorks, Inc. All rights reserved.
+Homepage: https://github.com/mathworks/libmexclass
+License: 3-clause BSD
Review Comment:
Thanks for clarifying how to assemble the `NOTICE.txt` and `LICENSE.txt` files, @kinow
For reference - we based our original changes off the fact that other third party libraries that are bundled and dynamically linked against in certain binary distributions are noted in the `LICENSE.txt`.
For example:
```
3rdparty dependency zlib is redistributed as a dynamically linked shared
library in certain binary distributions, like the python wheels.
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1998059389
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1523776382
##########
.github/workflows/matlab.yml:
##########
@@ -42,7 +42,7 @@ jobs:
ubuntu:
name: AMD64 Ubuntu 20.04 MATLAB
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
Review Comment:
Added a comment explaining why we are pinning the operating system version to `ubuntu-20.04` explicitly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-2004674928
Hi Kou,
Your understanding and assumptions seem mostly correct to us.
However, we would like to provide a few notes for clarification.
[`mathworks/libmexclass`](https://github.com/mathworks/libmexclass) is licensed under the 3-Clause BSD license. This implies that the `mathworks/libmexclass` source code and any binary object code that is derived directly from this source code can be freely redistributed under the terms of the 3-Clause BSD license.
However, when building MATLAB programs that use `mathworks/libmexclass`, there is some proprietary MathWorks object code that is linked against / compiled into the resulting binaries in order to integrate with the MATLAB MEX functionality. MathWorks is explicitly granting the Apache Software Foundation the right to distribute any of the MathWorks proprietary object code which is required by `mathworks/libmexclass` *and* bundled in the distributed MLTBX files under the Apache V2 license. In addition, MathWorks is explicitly granting the Apache Software Foundation the right to distribute any of the files generated by the MLTBX packaging infrastructure (e.g. files under the `metadata/`, `_rels/`, and `_xmlsignatures/` directories), which are included in the resulting MLTBX files, under the Apache V2 license.
**To summarize**: our understanding is that *ALL* contents of the distributed MLTBX files would be licensed under either, 3-Clause BSD, or Apache V2, which should make the MLTBX contents compatible with the ASF 3rd Party License Policy.
We hope this clarifies things. Please let us know if you have any other questions.
Thank you,
Sarah and Kevin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804613919
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "kevingurney (via GitHub)" <gi...@apache.org>.
kevingurney commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1804643715
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806474509
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806210442
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806379303
Revision: dc256eafd14ecb7184d48a29fd63c7062cb07a3a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-ab37048e95](https://github.com/ursacomputing/crossbow/branches/all?query=actions-ab37048e95)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6829246723/job/18575012861)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1806376638
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1811357516
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1809045409
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1812970579
Revision: 706f7b5369b886780018f691453ef3e4a5066def
Submitted crossbow builds: [ursacomputing/crossbow @ actions-9b617b7440](https://github.com/ursacomputing/crossbow/branches/all?query=actions-9b617b7440)
|Task|Status|
|----|------|
|matlab|[](https://github.com/ursacomputing/crossbow/actions/runs/6880857247/job/18715947463)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1402168947
##########
.github/workflows/matlab.yml:
##########
@@ -42,7 +42,7 @@ jobs:
ubuntu:
name: AMD64 Ubuntu 20.04 MATLAB
- runs-on: ubuntu-latest
+ runs-on: ubuntu-20.04
Review Comment:
I think the explanation on the issue summary is great on why we have to use Ubuntu 20.04 here. Could we add a comment summarizing the issue here so we have a reminder on why are pinning this Ubuntu version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB] Add MATLAB packaging and release scripts [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on PR #38660:
URL: https://github.com/apache/arrow/pull/38660#issuecomment-1813175817
@github-actions crossbow submit matlab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-38659: [CI][MATLAB][Packaging] Add MATLAB `packaging` task to crossbow `tasks.yml` [arrow]
Posted by "sgilmore10 (via GitHub)" <gi...@apache.org>.
sgilmore10 commented on code in PR #38660:
URL: https://github.com/apache/arrow/pull/38660#discussion_r1453961078
##########
matlab/tools/packageMatlabInterface.m:
##########
@@ -0,0 +1,58 @@
+% Licensed to the Apache Software Foundation (ASF) under one
+% or more contributor license agreements. See the NOTICE file
+% distributed with this work for additional information
+% regarding copyright ownership. The ASF licenses this file
+% to you under the Apache License, Version 2.0 (the
+% "License"); you may not use this file except in compliance
+% with the License. You may obtain a copy of the License at
+%
+% http://www.apache.org/licenses/LICENSE-2.0
+%
+% Unless required by applicable law or agreed to in writing,
+% software distributed under the License is distributed on an
+% "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+% KIND, either express or implied. See the License for the
+% specific language governing permissions and limitations
+% under the License.
+
+toolboxFolder = string(getenv("ARROW_MATLAB_TOOLBOX_FOLDER"));
+outputFolder = string(getenv("ARROW_MATLAB_TOOLBOX_OUTPUT_FOLDER"));
+toolboxVersionRaw = string(getenv("ARROW_MATLAB_TOOLBOX_VERSION"));
+
+% Output folder must exist.
+mkdir(outputFolder);
+
+disp("Toolbox Folder: " + toolboxFolder);
+disp("Output Folder: " + outputFolder);
+disp("Toolbox Version Raw: " + toolboxVersionRaw);
+
+% Note: This string processing heuristic may not be robust to future
+% changes in the Arrow versioning scheme.
+dotIdx = strfind(toolboxVersionRaw, ".");
+numDots = numel(dotIdx);
+if numDots >= 3
+ toolboxVersion = extractBefore(toolboxVersionRaw, dotIdx(3));
+else
+ toolboxVersion = toolboxVersionRaw;
+end
+
+disp("Toolbox Version:" + toolboxVersion);
+
+identifier = "ad1d0fe6-22d1-4969-9e6f-0ab5d0f12ce3";
+opts = matlab.addons.toolbox.ToolboxOptions(toolboxFolder, identifier);
Review Comment:
Hi Everyone,
Thanks very much for patiently waiting on us to move this forward.
We realized that we need to ensure that the licenses of any MEX artifacts bundled with the released MLTBX file are compatible with the ASF 3rd Party License Policy.
After several rounds of discussion with some colleagues at MathWorks (unfortunately delayed due to the holiday season in the US), we came up with a license ([attached to this comment](https://github.com/apache/arrow/files/13955180/license.txt)) that we hope will allow us to ensure that we are abiding by the ASF's 3rd Party License Policy.
The attached license is a modified version of the standard MathWorks license that applies to MEX files. The intent of these modifications is to meet the requirements for inclusion as a ["Category B"](https://www.apache.org/legal/resolved.html#category-b) license according to the ASF 3rd Party License Policy.
Our goal is to make sure we are doing the right thing here, and we understand this may need further input from ASF Legal and the rest of the community. Please let us know what we can do to help move this forward. We sincerely appreciate everyone's support as we navigate these licensing requirements.
**Link to proposed license:** [license.txt](https://github.com/apache/arrow/files/13955180/license.txt)
Best,
Sarah and Kevin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org