[GitHub] [camel-kafka-connector] aimiebell commented on a change in pull request #940: #873 initial cxf Source/Sink connectors test

[GitBox <gi...@apache.org>]

aimiebell commented on a change in pull request #940:
URL: https://github.com/apache/camel-kafka-connector/pull/940#discussion_r572622950



##########
File path: tests/itests-cxf/src/test/java/org/apache/camel/kafkaconnector/cxf/sink/GreeterImpl.java
##########
@@ -15,16 +15,16 @@
  * limitations under the License.
  */
 
-package org.apache.camel.kafkaconnector.common.test;
+package org.apache.camel.kafkaconnector.cxf.sink;
 
-import java.util.Map;
-import java.util.concurrent.ExecutionException;
+import java.util.logging.Logger;
 
-/**
- * A producer of test messages
- */
-public interface TestMessageProducer<T> {
-    Map<String, String> messageHeaders(T text, int current);
-    T testMessageContent(int current);
-    void produceMessages() throws ExecutionException, InterruptedException;
+
+public class GreeterImpl extends org.apache.hello_world_soap_http.GreeterImpl {

Review comment:
       I detect that this code is problematic. According to the [Bad practice (BAD_PRACTICE)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#bad-practice-bad-practice), [Nm: Class names shouldn’t shadow simple name of superclass (NM_SAME_SIMPLE_NAME_AS_SUPERCLASS)](https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#nm-class-names-shouldn-t-shadow-simple-name-of-superclass-nm-same-simple-name-as-superclass).
   This class has a simple name that is identical to that of its superclass, except that its superclass is in a different package (e.g., alpha.Foo extends beta.Foo). This can be exceptionally confusing, create lots of situations in which you have to look at import statements to resolve references and creates many opportunities to accidentally define methods that do not override methods in their superclasses.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org