You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2021/09/07 04:00:04 UTC
[incubator-doris] branch master updated: [Bug][Function] Fix pad
function wrong result when len.val==str_char_size (#6564)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 577ff01 [Bug][Function] Fix pad function wrong result when len.val==str_char_size (#6564)
577ff01 is described below
commit 577ff0109495f608641d889e1c69ec45759a30da
Author: Pxl <95...@qq.com>
AuthorDate: Tue Sep 7 11:55:49 2021 +0800
[Bug][Function] Fix pad function wrong result when len.val==str_char_size (#6564)
like #6563 and #6562
---
be/src/exprs/string_functions.cpp | 4 ++--
be/test/exprs/string_functions_test.cpp | 4 ++++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/be/src/exprs/string_functions.cpp b/be/src/exprs/string_functions.cpp
index 69d1898..2c72beb 100644
--- a/be/src/exprs/string_functions.cpp
+++ b/be/src/exprs/string_functions.cpp
@@ -217,7 +217,7 @@ StringVal StringFunctions::lpad(FunctionContext* context, const StringVal& str,
return StringVal::null();
}
if (len.val == str_index.size()) {
- return StringVal(str.ptr, len.val);
+ return StringVal(str.ptr, str.len);
}
return StringVal(str.ptr, str_index[len.val]);
}
@@ -268,7 +268,7 @@ StringVal StringFunctions::rpad(FunctionContext* context, const StringVal& str,
return StringVal::null();
}
if (len.val == str_index.size()) {
- return StringVal(str.ptr, len.val);
+ return StringVal(str.ptr, str.len);
}
return StringVal(str.ptr, str_index[len.val]);
}
diff --git a/be/test/exprs/string_functions_test.cpp b/be/test/exprs/string_functions_test.cpp
index e7bae96..d950f11 100644
--- a/be/test/exprs/string_functions_test.cpp
+++ b/be/test/exprs/string_functions_test.cpp
@@ -470,6 +470,8 @@ TEST_F(StringFunctionsTest, lpad) {
StringFunctions::lpad(ctx, StringVal("hi"), IntVal(1), StringVal("?")));
ASSERT_EQ(StringVal("你"),
StringFunctions::lpad(ctx, StringVal("你好"), IntVal(1), StringVal("?")));
+ ASSERT_EQ(StringVal("你"),
+ StringFunctions::lpad(ctx, StringVal("你"), IntVal(1), StringVal("?")));
ASSERT_EQ(StringVal(""),
StringFunctions::lpad(ctx, StringVal("hi"), IntVal(0), StringVal("?")));
ASSERT_EQ(StringVal::null(),
@@ -498,6 +500,8 @@ TEST_F(StringFunctionsTest, rpad) {
StringFunctions::rpad(ctx, StringVal("hi"), IntVal(1), StringVal("?")));
ASSERT_EQ(StringVal("你"),
StringFunctions::rpad(ctx, StringVal("你好"), IntVal(1), StringVal("?")));
+ ASSERT_EQ(StringVal("你"),
+ StringFunctions::rpad(ctx, StringVal("你"), IntVal(1), StringVal("?")));
ASSERT_EQ(StringVal(""),
StringFunctions::rpad(ctx, StringVal("hi"), IntVal(0), StringVal("?")));
ASSERT_EQ(StringVal::null(),
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org