You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fory.apache.org by "ayush00git (via GitHub)" <gi...@apache.org> on 2025/12/18 05:42:17 UTC
[PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
ayush00git opened a new pull request, #377:
URL: https://github.com/apache/fory-site/pull/377
Fixes #376
Changes i've made -
Edited the `static/img/navbar-logo.png`, now it's visually appealing in both the light and dark theme of the website.
Here's how it looks -
In the dark mode -
<img width="1920" height="536" alt="image" src="https://github.com/user-attachments/assets/275823ac-010b-4dfb-9bcf-fd9b1ace1040" />
In the light mode -
<img width="1920" height="536" alt="image" src="https://github.com/user-attachments/assets/5f30de48-4dd6-4e50-98b8-d6ce41c9884b" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3671316568
@chaokunyang
Thanks for approving : )
I would like to explore more about fory, could you please guide me through the issues or features i can contribute to..
That would be a great help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3668480315
Hey @chaokunyang have a look at the PR, and do let me know if there are any changes.
Thanks : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3669679766
Hey @chaokunyang,
Take a look now -
<img width="1905" height="491" alt="image" src="https://github.com/user-attachments/assets/f2259354-9fcf-4728-a94a-aa9aed18921c" />
<img width="1905" height="491" alt="Screenshot From 2025-12-18 16-18-28" src="https://github.com/user-attachments/assets/0c790127-8905-4628-898d-bdd27a20a6c7" />
Changes i made -
1. In `src/css/custom.css` I added CSS rules to make sure the correct logo is displayed based on the active theme.
2. In `docusaurus.config.ts` I updated the `navbar.logo` configuration to specify both a light and dark version of the logo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang merged PR #377:
URL: https://github.com/apache/fory-site/pull/377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3671120667
> 1. In `src/css/custom.css` I added CSS rules to make sure the correct logo is displayed based on the active theme.
> 2. In `docusaurus.config.ts` I updated the `navbar.logo` configuration to specify both a light and dark version of the logo.
this is great
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3668601335
> > o make it more dark for light m
>
> maybe we still need to implement this by css
Okk means i should try to render two different images for dark and light modes using css properties?
Should i go with this approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3668513411
<img width="1448" height="512" alt="image" src="https://github.com/user-attachments/assets/912a5217-6f9b-4827-ab9c-55b3316cf781" />
could we make this dark for light mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3669413570
> Yes, we should go with this approach
Okk, i'll try making the changes and let you know with a new commit.. : )
Actually i was making the doc for new comers to know what fory is as we discussed in slack. So i'll create a PR for it first : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "ayush00git (via GitHub)" <gi...@apache.org>.
ayush00git commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3668576398
> could we make this dark for light mode?
Actually i tried using a complete black image for the light mode and a white image for the dark mode, and explicitly writing the CSS but it didn't worked out.
If you want i can try editing the image once more, do make it more dark for light mode, but it may have effects in dark mode then.
Let me know how you would like me to proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3668593713
> o make it more dark for light m
maybe we still need to implement this by css
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [PR] Fix: Changes the navbar-logo for better visual appeal in both the dark and light themes. [fory-site]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on PR #377:
URL: https://github.com/apache/fory-site/pull/377#issuecomment-3669384233
> > > o make it more dark for light m
> >
> >
> > maybe we still need to implement this by css
>
> Okk means i should try to render two different images for dark and light modes using css properties? Should i go with this approach?
Yes, we should go with this approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org