You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Harsh J (Commented) (JIRA)" <ji...@apache.org> on 2012/01/04 07:20:39 UTC

[jira] [Commented] (AVRO-854) python DataFileWriter and DataFileReader should implement __enter__ and __exit__

    [ https://issues.apache.org/jira/browse/AVRO-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13179316#comment-13179316 ] 

Harsh J commented on AVRO-854:
------------------------------

Implemented a simple context manager (enter provides the instance itself, no frills, and exit closes the file if there was no exception waiting to be rethrown after) and added a test that runs for python > 2.5 (2.5 has with statement as a future import).

Ran tests with python 2.5 and python 2.6, and both pass (former skips it).
                
> python DataFileWriter and DataFileReader should implement __enter__ and __exit__
> --------------------------------------------------------------------------------
>
>                 Key: AVRO-854
>                 URL: https://issues.apache.org/jira/browse/AVRO-854
>             Project: Avro
>          Issue Type: New Feature
>          Components: python
>    Affects Versions: 1.5.1
>            Reporter: Jeremy Lewi
>            Assignee: Harsh J
>            Priority: Minor
>         Attachments: AVRO-854.patch
>
>
> I think The python classes 
> {noformat}
> avio.datafile.DataFileWriter
> avio.datafile.DataFileReader
> {noformat}
> should implement the methods
> {noformat}
> __enter__
> __exit__
> {noformat}
> So that they can be used in with statements as context managers
> see http://docs.python.org/release/2.5.2/lib/typecontextmanager.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira