[GitHub] [pulsar-client-go] codelipenghui commented on a diff in pull request #829: Enable seeking individual topic partitions

[GitBox <gi...@apache.org>]

codelipenghui commented on code in PR #829:
URL: https://github.com/apache/pulsar-client-go/pull/829#discussion_r948035080


##########
pulsar/consumer_impl.go:
##########
@@ -575,15 +575,21 @@ func (c *consumer) Seek(msgID MessageID) error {
 	c.Lock()
 	defer c.Unlock()
 
-	if len(c.consumers) > 1 {
-		return newError(SeekFailed, "for partition topic, seek command should perform on the individual partitions")
-	}
-
 	mid, ok := c.messageID(msgID)
 	if !ok {
 		return nil
 	}
 
+	if mid.partitionIdx < 0 {
+		return newError(SeekFailed, "partitionIdx is negative")
+	}

Review Comment:
   Will this break the non-partitioned topic message acknowledgment?
   The partition index -1 means the message from a non-partitioned topic.
   
   @freeznet @wolfstudy Please help confirm



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org