You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yukang-Lian (via GitHub)" <gi...@apache.org> on 2026/04/17 11:42:44 UTC
[PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Yukang-Lian opened a new pull request, #62596:
URL: https://github.com/apache/doris/pull/62596
## Summary
Unify the ``ADMIN COMPACT TABLE ... WHERE type = '...'`` SQL entry so that BASE, CUMULATIVE and FULL all work on both the local and cloud (storage-compute split) engines. Before this change, FULL was rejected in FE and cloud mode was blocked outright, forcing users to curl each BE's HTTP API to run manual compaction.
## What changes
### FE
- ``AdminCompactTableCommand``: add ``FULL`` to ``CompactionType``, relax ``analyzeWhere``, map ``FULL -> \"full\"`` in ``getCompactionType``, and drop the cloud-mode gate so the command dispatches via the normal Agent RPC path.
- ``CloudEnv.compactTable``: override ``Env.compactTable`` to walk partitions/indices/tablets, resolve the primary BE via ``Replica.getBackendId()``, skip tablets whose compute group has no available BE, and raise ``DdlException`` if nothing was dispatched.
### BE
- ``submit_table_compaction_callback``: strictly match ``base``/``cumulative``/``full`` instead of silently downgrading any non-``\"base\"`` value to ``CUMULATIVE_COMPACTION``. FULL goes through ``submit_compaction_task(force=false, eager=true, trigger_method=MANUAL)`` after setting ``last_full_compaction_schedule_time``, matching the HTTP API default.
- ``cloud_submit_table_compaction_callback``: new callback mirroring the local one but calling ``CloudStorageEngine::submit_compaction_task``; honors the cloud HTTP convention that base/cumu need ``sync_delete_bitmap`` while full does not.
- ``agent_server::cloud_start_workers``: register the previously stubbed-out ``SUBMIT_TABLE_COMPACTION`` worker (drops the ``// TODO(plat1ko)`` comment).
### Thrift / wire compatibility
``TCompactionReq.type`` remains ``optional string``, so no IDL change. A new FE against an old BE would see ``\"full\"`` silently downgraded (local) or dropped (cloud), so the release order is **all BEs upgraded first, then FE**. FE rollback can lead BE since the FE simply stops sending ``\"full\"``.
## Test plan
- [x] ``mvn -pl fe-core -am compile`` passes.
- [x] New regression suite ``regression-test/suites/compaction/test_admin_compact_table.groovy`` covers base / cumulative / full end-to-end on the local engine, plus negative cases (unknown type, missing WHERE).
- [x] New regression suite ``regression-test/suites/cloud_p0/compaction/test_cloud_admin_compact_table.groovy`` covers the same matrix on the cloud engine.
- [x] Design document and code reviewed independently by Codex (two rounds).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4278076299
# BE UT Coverage Report
Increment line coverage `0.00% (0/81)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/95a878fed50101f2fb5c155efaf16914f36a3caa_95a878fed50101f2fb5c155efaf16914f36a3caa/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/95a878fed50101f2fb5c155efaf16914f36a3caa_95a878fed50101f2fb5c155efaf16914f36a3caa/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.25% (20340/38198) |
| Line Coverage | 36.79% (191459/520424) |
| Region Coverage | 33.11% (148923/449825) |
| Branch Coverage | 34.19% (65054/190260) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4268287521
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/42)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62596_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62596_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62596:
URL: https://github.com/apache/doris/pull/62596#discussion_r3108107003
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudEnv.java:
##########
@@ -489,4 +499,57 @@ protected void cloneClusterSnapshot() throws Exception {
this.cloudSnapshotHandler.cloneSnapshot(this.clusterSnapshotFile);
}
}
+
+ @Override
+ public void compactTable(String dbName, String tableName, String type, List<String> partitionNames)
+ throws DdlException {
+ Database db = getInternalCatalog().getDbOrDdlException(dbName);
+ OlapTable olapTable = db.getOlapTableOrDdlException(tableName);
+
+ AgentBatchTask batchTask = new AgentBatchTask();
+ int dispatchedCount = 0;
+ olapTable.readLock();
+ try {
+ LOG.info("Cloud table compaction. db={}, table={}, partitions={}, type={}",
+ dbName, tableName, partitionNames, type);
+ for (String parName : partitionNames) {
+ Partition partition = olapTable.getPartition(parName);
+ if (partition == null) {
+ throw new DdlException("partition[" + parName + "] not exist in table[" + tableName + "]");
+ }
+
+ for (MaterializedIndex idx : partition.getMaterializedIndices(IndexExtState.VISIBLE)) {
+ for (Tablet tablet : idx.getTablets()) {
+ // Cloud: each tablet has only one CloudReplica (primary BE). The backend
+ // resolution depends on the current compute group (ConnectContext); skip
+ // the tablet rather than aborting so other tablets can still dispatch.
+ for (Replica replica : tablet.getReplicas()) {
+ long beId;
Review Comment:
`replica.getBackendId()` is not a pure metadata lookup in cloud mode. `CloudReplica.getBackendId()` goes through `getCloudClusterIdByName()`, which can call `CloudSystemInfoService.waitForAutoStart()` and block on Meta Service / retry sleeps while the compute group is being resumed. Because this happens under `olapTable.readLock()`, a suspended or recovering compute group can hold the table metadata lock for a long time and block unrelated operations on the same table. Please snapshot the partitions/tablets you need under the read lock, release it, and only then resolve backend ids / build agent tasks.
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudEnv.java:
##########
@@ -489,4 +499,57 @@ protected void cloneClusterSnapshot() throws Exception {
this.cloudSnapshotHandler.cloneSnapshot(this.clusterSnapshotFile);
}
}
+
+ @Override
+ public void compactTable(String dbName, String tableName, String type, List<String> partitionNames)
+ throws DdlException {
+ Database db = getInternalCatalog().getDbOrDdlException(dbName);
+ OlapTable olapTable = db.getOlapTableOrDdlException(tableName);
+
+ AgentBatchTask batchTask = new AgentBatchTask();
+ int dispatchedCount = 0;
+ olapTable.readLock();
+ try {
+ LOG.info("Cloud table compaction. db={}, table={}, partitions={}, type={}",
+ dbName, tableName, partitionNames, type);
+ for (String parName : partitionNames) {
+ Partition partition = olapTable.getPartition(parName);
+ if (partition == null) {
+ throw new DdlException("partition[" + parName + "] not exist in table[" + tableName + "]");
+ }
+
+ for (MaterializedIndex idx : partition.getMaterializedIndices(IndexExtState.VISIBLE)) {
+ for (Tablet tablet : idx.getTablets()) {
+ // Cloud: each tablet has only one CloudReplica (primary BE). The backend
+ // resolution depends on the current compute group (ConnectContext); skip
+ // the tablet rather than aborting so other tablets can still dispatch.
+ for (Replica replica : tablet.getReplicas()) {
+ long beId;
+ try {
Review Comment:
Catching every `UserException` here is too broad. `replica.getBackendId()` throws `ComputeGroupException` for cases like missing `USAGE` privilege, manually shut down compute groups, or missing compute groups, and this code currently downgrades all of those into `skip tablet ...` plus the generic `no tablet dispatched for compaction` message. That loses the real user-facing failure and can also turn a hard error into a partial dispatch. If we want to skip anything here, it should be only the specific transient no-BE cases; the other exceptions need to be propagated unchanged.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCompactTableCommand.java:
##########
@@ -51,7 +46,8 @@ public class AdminCompactTableCommand extends Command implements ForwardWithSync
*/
public enum CompactionType {
CUMULATIVE,
- BASE
Review Comment:
Allowing `FULL` / cloud dispatch here without a BE capability gate is not rolling-upgrade safe. On an older local BE, `submit_table_compaction_callback()` still treats any non-`"base"` type as cumulative compaction, so `type='FULL'` silently runs the wrong operation. On an older cloud BE, `cloud_start_workers()` still has no `TTaskType::COMPACTION` worker at all; BE returns `InvalidArgument`, but FE ignores `submit_tasks()` status in `AgentBatchTask.run()`, so the SQL can return success while nothing runs. We need a fail-fast FE-side version/capability check (or keep the old cloud-mode gate) until all BEs are guaranteed upgraded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4267748217
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4286972427
skip check_coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4285821506
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4280285538
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4267682179
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4278411186
# BE Regression && UT Coverage Report
Increment line coverage `45.24% (38/84)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62596_95a878fed50101f2fb5c155efaf16914f36a3caa_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62596_95a878fed50101f2fb5c155efaf16914f36a3caa_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.76% (27594/37412) |
| Line Coverage | 57.47% (298198/518848) |
| Region Coverage | 54.66% (248179/454009) |
| Branch Coverage | 56.21% (107281/190850) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4278445732
# FE Regression Coverage Report
Increment line coverage ` 80.39% (41/51)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62596_95a878fed50101f2fb5c155efaf16914f36a3caa_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62596_95a878fed50101f2fb5c155efaf16914f36a3caa_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4285535882
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4277578699
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4268809676
# BE Regression && UT Coverage Report
Increment line coverage `45.24% (38/84)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62596_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62596_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.74% (27512/37311) |
| Line Coverage | 57.47% (297933/518417) |
| Region Coverage | 54.81% (248648/453640) |
| Branch Coverage | 56.32% (107402/190706) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4279950172
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4277713298
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "luwei16 (via GitHub)" <gi...@apache.org>.
luwei16 merged PR #62596:
URL: https://github.com/apache/doris/pull/62596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4277563931
run nonConcurrent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4277713041
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "Yukang-Lian (via GitHub)" <gi...@apache.org>.
Yukang-Lian commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4279506264
run performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4268345310
# BE UT Coverage Report
Increment line coverage `0.00% (0/81)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/247e5ea4c7dfce671ccfc6c730dca58a67d73ce5_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/247e5ea4c7dfce671ccfc6c730dca58a67d73ce5_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.27% (20297/38101) |
| Line Coverage | 36.76% (191187/520029) |
| Region Coverage | 33.06% (148618/449528) |
| Branch Coverage | 34.14% (64920/190136) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62596:
URL: https://github.com/apache/doris/pull/62596#issuecomment-4268885879
# FE Regression Coverage Report
Increment line coverage ` 73.81% (31/42)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62596_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62596_247e5ea4c7dfce671ccfc6c730dca58a67d73ce5_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [feat](compaction) Support ADMIN COMPACT TABLE type='FULL' and enable it in cloud mode [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62596:
URL: https://github.com/apache/doris/pull/62596#discussion_r3108222743
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/AdminCompactTableCommand.java:
##########
@@ -51,7 +46,8 @@ public class AdminCompactTableCommand extends Command implements ForwardWithSync
*/
public enum CompactionType {
CUMULATIVE,
- BASE
Review Comment:
`FULL` / cloud enablement here is still not rolling-upgrade safe. On the older local BE implementation, `submit_table_compaction_callback()` maps every non-`"base"` request to cumulative compaction, so a new FE can silently run the wrong operation for `type='FULL'`. On the older cloud BE implementation, `cloud_start_workers()` still has no `TTaskType::COMPACTION` worker at all, and `AgentBatchTask.run()` ignores the non-OK `submit_tasks()` result, so the SQL can return success while nothing is dispatched. This needs a fail-fast FE-side capability/version gate (or the old cloud-mode restriction) until all BEs are guaranteed to understand the new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org