You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jihoonson <gi...@git.apache.org> on 2015/09/16 09:15:31 UTC
[GitHub] tajo pull request: TAJO-1853: Add tablespace syntax to the CREATE ...
GitHub user jihoonson opened a pull request:
https://github.com/apache/tajo/pull/762
TAJO-1853: Add tablespace syntax to the CREATE TABLE section of DDL page
I've also added some descriptions to other sections.
You can see at http://people.apache.org/~jihoonson/tajo-doc/sql_language/ddl.html.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jihoonson/tajo-2 TAJO-1853
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/762.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #762
----
commit 34c7948e8eb470fb557c40ff470142571160d1c8
Author: Jihoon Son <ji...@apache.org>
Date: 2015-09-16T07:12:04Z
TAJO-1853
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1853: Add tablespace syntax to the CREATE ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/762#issuecomment-140766923
+1 Ship it. I leaved one trivial comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1853: Add tablespace syntax to the CREATE ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on a diff in the pull request:
https://github.com/apache/tajo/pull/762#discussion_r39640120
--- Diff: tajo-docs/src/main/sphinx/sql_language/ddl.rst ---
@@ -34,12 +37,18 @@ CREATE TABLE
.. code-block:: sql
- CREATE TABLE [IF NOT EXISTS] <table_name> [(<column_name> <data_type>, ... )]
+ CREATE TABLE [IF NOT EXISTS] <table_name> [(<column_name> <data_type>, ... )] [TABLESPACE tablespace_name]
[using <storage_type> [with (<key> = <value>, ...)]] [AS <select_statement>]
CREATE EXTERNAL TABLE [IF NOT EXISTS] <table_name> (<column_name> <data_type>, ... )
using <storage_type> [with (<key> = <value>, ...)] LOCATION '<path>'
+*Description*
+
+In Tajo, there are two types of tables, `managed table` and `external table` (For more information, please refer to :doc:`/table_management/table_overview`.)
+
+Managed tables are placed on some predefined tablespaces. The ``TABLESPACE`` clause is to specify a tablespace for this table. For more information about tablespace, please refer to :doc:`/table_management/tablespaces`. For external tables, Tajo allows arbitrary table location with the ``LOCATION`` clause.
--- End diff --
``arbitrary table`` should be ``an arbitrary``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1853: Add tablespace syntax to the CREATE ...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/762#issuecomment-140959318
Thank you for the comment.
I'll reflect it and commit soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1853: Add tablespace syntax to the CREATE ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/762
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---